From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E1FE3B0AFD; Tue, 31 Mar 2026 08:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774945270; cv=none; b=kiAhB06apvskYEAw/g3GAjhTfH6PWQ5bg/G8wdqWzq0crj5IhkzhQoHpPoKl7ketWbmywbXslRLCIYLI0Up64k1c/wPkH/2fwga0ICTlsF6iNz0sLtzXZhoYO+5Dm35i31vewH8GlC5wLLm4sfojI6zF4VEUjA77nbAWwerzMh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774945270; c=relaxed/simple; bh=DbRAreIvNazq7fUJlTFdsMdk1QTVzgJhSGMqfeKUWuw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NTimfoYMIRg4RXqX1BeQf5M1QQHG0RPgySIiEQjQbdPbFvft4jMYUdCP/6Bj5CTuM7BHT24zqg2UqSD5s6xUO5w6LzbRjM7zwdJVV63gxavrj6e3QgcHpxw9T8y3V/coDYqHGn6vZMVoBrFYwDiK1W8z54kwAIwyu9cYobVJoWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lde4PH74; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lde4PH74" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8476BC19423; Tue, 31 Mar 2026 08:21:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774945270; bh=DbRAreIvNazq7fUJlTFdsMdk1QTVzgJhSGMqfeKUWuw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lde4PH74cD0jdvfvNKruYxpjcMcANTLYoRHdwBdIABD/iT8KOPIDZhbocPTgxy59o Nk+OCgjqvNt9Ljl3R4Yh9tVDhynBDjOvhdv2a9lS2iOiTdQ+Zz4zq8rT2TBdkpzJEV 0VIqpnsna06e+BSkodypUu2DTTMf18IoiaMltnHOilSeaLMeqLvndAt1VmI9NqlbBZ aXV+V9lyGfp2aRedeNB2OTibqS4g5um6lLQ/CxrqXdrUG+ktyaNv8CjZezy8W7LyEr 9me7dI35zLOQGjAKi7m54eKKk40x8ueiGhW5cgG6dT66feGUQDczRctl1ZmDAUIPbN dncm/WqftI6qA== Date: Tue, 31 Mar 2026 10:21:07 +0200 From: Krzysztof Kozlowski To: Thomas Richard Cc: Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Thomas Petazzoni , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 01/11] dt-bindings: regulator: ti,pbias-regulator: Convert to DT schema Message-ID: <20260331-demonic-boisterous-spider-5ed5c6@quoll> References: <20260330-omap4-fix-usb-support-v2-0-1c1e11b190dc@bootlin.com> <20260330-omap4-fix-usb-support-v2-1-1c1e11b190dc@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260330-omap4-fix-usb-support-v2-1-1c1e11b190dc@bootlin.com> On Mon, Mar 30, 2026 at 03:43:58PM +0200, Thomas Richard wrote: > +$id: http://devicetree.org/schemas/regulator/ti,pbias-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: PBIAS internal regulator > + > +maintainers: > + - Thomas Richard > + > +description: | Do not need '|' unless you need to preserve formatting. > + PBIAS internal regulator for SD card dual voltage i/o pads on OMAP SoCs. > + > +properties: > + compatible: > + items: > + - enum: > + - ti,pbias-dra7 > + - ti,pbias-omap2 > + - ti,pbias-omap3 > + - ti,pbias-omap4 > + - ti,pbias-omap5 > + - const: ti,pbias-omap > + > + reg: > + maxItems: 1 > + > + syscon: > + description: Phandle of the system control module > + $ref: /schemas/types.yaml#/definitions/phandle > + > +patternProperties: > + '^pbias_*': That wasn't in old binding and underscore is not allowed, so this needs explanation. Old binding mentioned only the names. > + type: object > + $ref: regulator.yaml# > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - syscon > + > +additionalProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - ti,pbias-omap2 > + then: > + patternProperties: > + '^pbias_*': > + properties: > + regulator-name: > + contains: > + enum: > + - pbias_mmc_omap2430 > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - ti,pbias-omap3 > + then: > + patternProperties: > + '^pbias_*': > + properties: > + regulator-name: > + contains: > + enum: > + - pbias_mmc_omap2430 > + - pbias_sim_omap3 > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - ti,pbias-omap4 > + then: > + patternProperties: > + '^pbias_*': > + properties: > + regulator-name: > + contains: > + enum: > + - pbias_mmc_omap4 > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - ti,pbias-dra7 > + - ti,pbias-omap5 > + then: > + patternProperties: > + '^pbias_*': > + properties: > + regulator-name: > + contains: > + enum: > + - pbias_mmc_omap5 > + > +examples: > + - | > + bus { > + #address-cells = <1>; > + #size-cells = <1>; > + > + pbias_regulator: pbias_regulator@0 { Drop unused labels Best regards, Krzysztof