From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41EC84035D3; Tue, 31 Mar 2026 15:21:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774970513; cv=none; b=cHQfXMbGhiFoTcOgsXqAT5iBbxpRxiKQEipTlW+WP4Z7IWX4dQpQ0wQScEplptH55CXpczW568lIdhWZ/UWXmGvRUmdQc8P+zx+uPVUGd1QEOKBiKc0GRuxe1LgTbPZ3IBa3Mc8W0nW8Us6hW1elOadNGZMAEnmDt9B/cTA9Q4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774970513; c=relaxed/simple; bh=5v9OyPvgtc1RqMsoJE+1aCJ6/rVCcLvQlIrIuGvvSTI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YHdCXPXdvjXEnz97wNpWTTIFBom0yUvlux4ML0O5jYYzJGSoGyOBmmb+NVZGG6hz9y8rEGKX8bZkkWfGefTo4Efv8YAHMJTP+q6B6S5tKn6XR+GWV7LBjO6/9ru7gXzQUm9voCmkHLOSuiTujnFSKZh5LVYUsNYu+hUfco47Vy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L1V49APZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L1V49APZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A18C7C19423; Tue, 31 Mar 2026 15:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774970512; bh=5v9OyPvgtc1RqMsoJE+1aCJ6/rVCcLvQlIrIuGvvSTI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L1V49APZjtqm8evpFPAkKJ1MYnFNfCfFxnPHV6oRPNpxA5rJvb8bsNGy9Bn06+85Z cPOmeL7f7uLosC3ZshJzkMTsQEJtCzXVrPFXe+/GiUrdX6mDtjkElm7Z+HPBhtCKuU 2ZB5TS8KGdOe1SjY8qsViU6ALmrMUKpO6w901AuZUcdafjhNTIj7EsmhjxzifISSl5 1LpL9W8U3DuQJa9lmKYb5p2dbztwzmPy4/LgAJguoCy+iOODc0fj5g+OXSrcbZJfdT 44CrAunQk8gmO424Rjraz7ScHSaqbjoJN+1IuqMFO6zMQcUeU/Nw2wweB48+aDshHE mUkRo3wKQ2rcQ== Date: Tue, 31 Mar 2026 10:21:50 -0500 From: Rob Herring To: Florian Eckert Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , Johan Hovold , Sajid Dalvi , Ajay Agarwal , Krzysztof Kozlowski , Conor Dooley , Rahul Tanwar , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Eckert.Florian@googlemail.com, ms@dev.tdt.de Subject: Re: [PATCH v2 6/7] dt-bindings: PCI: intel,lgm-pcie: Make atu resource mandatory Message-ID: <20260331152150.GA1255126-robh@kernel.org> References: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> <20260330-pcie-intel-gw-v2-6-8bd07367a298@dev.tdt.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260330-pcie-intel-gw-v2-6-8bd07367a298@dev.tdt.de> On Mon, Mar 30, 2026 at 11:07:16AM +0200, Florian Eckert wrote: > The ATU information is already set in the dwc core if it is specified in > the DTS. The driver uses its own value here [1]. This information is > hardware specific and should therefore be maintained in the DTS rather > than in the source. > > Backwards compatibility is not an issue here [5], as the driver is > exclusively used by Maxlinear. > > Old DTS entry for PCIe: > > reg = <0xd1000000 0x1000>, > <0xd3000000 0x20000>, > <0xd0c41000.0x1000>; > reg-names = "dbi", "config", "app"; > > New DTS entry for PCIe: > > reg = <0xd1000000 0x1000>, > <0xd10c0000 0x1000>, > <0xd3000000 0x20000>, > <0xd0c41000.0x1000>; > reg-names = "dbi", "atu", "config", "app"; > > [1] https://elixir.bootlin.com/linux/v6.19.10/source/drivers/pci/controller/dwc/pcie-intel-gw.c#L301 > [2] https://lore.kernel.org/all/BY3PR19MB507667CE7531D863E1E5F8AEBDD82@BY3PR19MB5076.namprd19.prod.outlook.com/ > > Signed-off-by: Florian Eckert > --- > Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml > index 54e2890ae6314ac6847fc23f49440d05d66d87d4..e4b781f57e8ae84a3ffc33635a421e1a5761587e 100644 > --- a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml > @@ -29,12 +29,14 @@ properties: > reg: > items: > - description: Controller control and status registers. > + - description: Internal Address Translation Unit (iATU) registers. > - description: PCIe configuration registers. > - description: Controller application registers. > > reg-names: > items: > - const: dbi > + - const: atu Put this at the end and add 'minItems: 3' and you avoid any ABI issues. > - const: config > - const: app >