From: Lee Jones <lee@kernel.org>
To: Thomas Richard <thomas.richard@bootlin.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Andreas Kemnade <andreas@kemnade.info>,
Kevin Hilman <khilman@baylibre.com>,
Roger Quadros <rogerq@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/8] mfd: omap-usb-host: Cleanup header includes
Date: Tue, 31 Mar 2026 16:45:30 +0100 [thread overview]
Message-ID: <20260331154530.GI3795166@google.com> (raw)
In-Reply-To: <20260323-omap4-fix-usb-support-v1-3-b668132124ac@bootlin.com>
On Mon, 23 Mar 2026, Thomas Richard wrote:
> Remove unused includes (linux/kernel.h, linux/types.h and linux/delay.h).
> Sort the remaining ones alphabetically.
What about 'linux/slab.h'?
> Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
> ---
> drivers/mfd/omap-usb-host.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 4d29a6e2ed87abf2a0f6d5a704525baaa6f0cbcb..4e066a17cef0400edbfcb3012a16ceee06e52140 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -6,19 +6,15 @@
> * Author: Keshava Munegowda <keshava_mgowda@ti.com>
> * Author: Roger Quadros <rogerq@ti.com>
> */
> -#include <linux/kernel.h>
> -#include <linux/module.h>
> -#include <linux/types.h>
> -#include <linux/slab.h>
> -#include <linux/delay.h>
> #include <linux/clk.h>
> #include <linux/dma-mapping.h>
> -#include <linux/platform_device.h>
> +#include <linux/err.h>
> +#include <linux/module.h>
> #include <linux/platform_data/usb-omap.h>
> +#include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/of.h>
> #include <linux/of_platform.h>
This is still not alphabetical.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2026-03-31 15:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 15:02 [PATCH 0/8] Add SIM pbias regulator support for USB on OMAP4 Thomas Richard
2026-03-23 15:02 ` [PATCH 1/8] regulator: pbias: Add pbias SIM regulator for OMAP4 Thomas Richard
2026-03-23 17:29 ` Mark Brown
2026-03-27 12:36 ` Andreas Kemnade
2026-03-27 13:18 ` Thomas Richard
2026-03-23 15:02 ` [PATCH 2/8] ARM: dts: ti: omap4: Add pbias SIM regulator Thomas Richard
2026-03-23 15:02 ` [PATCH 3/8] mfd: omap-usb-host: Cleanup header includes Thomas Richard
2026-03-31 15:45 ` Lee Jones [this message]
2026-03-23 15:02 ` [PATCH 4/8] mfd: omap-usb-host: Sanitize error path in the probe() Thomas Richard
2026-03-23 15:02 ` [PATCH 5/8] dt-bindings: mfd: ti,omap-usb-host: Convert to DT schema Thomas Richard
2026-03-23 19:55 ` Conor Dooley
2026-03-23 15:02 ` [PATCH 6/8] dt-bindings: mfd: ti,omap-usb-host: Add 'pbias-supply' property Thomas Richard
2026-03-23 15:02 ` [PATCH 7/8] mfd: omap-usb-host: Add pbias regulator support Thomas Richard
2026-03-31 16:55 ` Lee Jones
2026-03-31 18:19 ` Thomas Richard
2026-03-23 15:02 ` [PATCH 8/8] ARM: dts: ti: omap4: Add pbias regulator to the HS USB Host Thomas Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331154530.GI3795166@google.com \
--to=lee@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox