[PATCH v5 0/2] Add support for Texas Instruments INA4230 power monitor

[PATCH v5 0/2] Add support for Texas Instruments INA4230 power monitor

[Alexey Charkov]

TI INA4230 is a 4-channel power monitor with I2C interface, similar in
operation to INA3221 (3-channel) and INA219 (single-channel) but with
a different register layout, different alerting mechanism and slightly
different support for directly reading calculated current/power/energy
values (pre-multiplied by the device itself and needing only to be scaled
by the driver depending on its selected LSB unit values).

In this initial implementation, the driver supports reading voltage,
current, power and energy values, but does not yet support alerts, which
can be added separately if needed. Also the overflows during hardware
calculations are not yet handled, nor is the support for the device's
internal 32-bit energy counter reset.

An example device tree using this binding and driver is available at [1]
(not currently upstreamed, as the device in question is in engineering
phase and not yet publicly available)

[1] https://github.com/flipperdevices/flipper-linux-kernel/blob/flipper-devel/arch/arm64/boot/dts/rockchip/rk3576-flipper-one-rev-f0b0c1.dts

Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
Changes in v5:
- Reworded per-channel subnodes description in the binding for clarity (Sashiko)
- NB: Sashiko's suggestion to allow interrupts in the binding sounds premature,
  as the alerts mechanism is not implemented yet and there are no known users
  to test it. If anyone has hardware with the alert pins wired to an interrupt
  line - please shout and we can test/extend it together
- Avoid division by zero when setting the conversion time with all inputs
  disabled (Sashiko)
- Added the missed HWMON_I_ENABLE bits (Sashiko)
- Dropped extra sysfs attributes for reading/writing shunt values, as the
  implementation was potentially racy and it's unlikely anyone would resolder
  the shunts on a running system (Sashiko)
- Skip pm_runtime_put_noidle() for disabled (not just disconnected) channels
  in remove and probe error path to avoid refcount underflow (Sashiko)
- Mark CONFIG2 register as volatile, as the reset bits in it are self-clearing
- NB: Sashiko's inquiry about the update interval being underreported due to
  not accounting for the number of averaging samples: no, the hardware still
  reports updates after each channels * (vbus_ct + vsh_ct), but the reported
  value changes slowly due to the averaging
- NB: Sashiko's inquiry about regmap_noinc_read(): same as Guenter's AI
  feedback. No, it doesn't break the byte order, as it uses byte-sized reads
- NB: Sashiko's inquiry about potential falling of ina->reg_config1 out of sync
  with the hardware upon failed regmap_write() calls: yes, but it will be
  written at the next successful write call, so the worst that can happen is
  the averaging / conversion time can be wrong for a while. And it will return
  a failed status for the failed write call too, so no big deal.
- NB: Sashiko's inquiry about reg_config1 not being written out during probe:
  it is written out when the device is runtime-resumed as the refcount gets
  incremented during the probe function
- Link to v4: https://lore.kernel.org/r/20260326-ina4230-v4-0-c1e312c09de7@flipper.net

Changes in v4:
- Aligned the maximum value of ti,maximum-expected-current-microamp property
  in the binding with the one expected by the driver (Guenter Roeck)
  "2147A ought to be enough for anybody (c)"
- Actually requested the optional vs-supply regulator in the driver (Guenter Roeck)
- Program the ALERT_POL bit according to the value of ti,alert-polarity-active-high
  even though the alerts themselves are not yet implemented (Guenter Roeck)
- Added a check for manually disabled channels in the is_enabled() function to
  avoid reading invalid data from them (Guenter Roeck)
- Dropped support for the single-shot mode as its operation is not clearly
  documented in the datasheet and there is no pressing need to support it (Guenter Roeck)
- NB: AI feedback regarding regmap_noinc_read() producing incorrect byte order on LE
  hosts is incorrect, as its implementation does a byte-wise read and doesn't care
  about the regmap value width or endianness flags, so it produces a 4-byte output
  buffer in the same byte order as the device returns, which is BE in this case
- NB: AI feedback regarding fail-path pm_runtime_put_noidle() potentially being
  unbalanced if the probe loop failed early is technically correct but practically
  irrelevant, as the driver will simply fail to load, and the usage count won't
  decrease beyond zero anyway. The alternatives are cumbersome for no real benefit
- Link to v3: https://lore.kernel.org/r/20260310-ina4230-v3-0-06ab3a77c570@flipper.net

Changes in v3:
- Updated the description of the ti,maximum-expected-current-microamp property
  in the binding to clarify how it is used, and drop the irrelevant mention of
  the PMbus (Guenter Roeck)
- Use div64_u64() instead of do_div() for the final division in the calibration value
  calculation to avoid overflows in the denominator (Guenter Roeck)
- Avoid overflow while scaling the voltage values on 32-bit platforms (Guenter Roeck)
- Use regmap_noinc_read() instead of regmap_raw_read() for reading the energy values
  to ensure that the regmap / bus driver don't wander off to adjacent registers
  during the read operation (on INA4230 the whole 32 bits should be read from
  the same register offset) (Guenter Roeck)
- Remove redundant call to ina4230_set_calibration() in the current read path,
  as the calibration value is already set when enabling the channel and restored
  across PM changes via regcache_sync() (Guenter Roeck)
- Add missing write_enable() function to make hwmon_in_enable writes work as
  advertised in is_visible() (Guenter Roeck)
- Add a check for disabled channels before calling pm_runtime_put_noidle() on them
  to avoid refcount underflow due to imbalanced get_sync/put_noidle calls (Guenter Roeck)
- Dropped unused include of linux/debugfs.h
- Add missing return checks on regmap_write() calls
- uO -> uOhm in the error message to avoid confusion
- Move probe-time calibration after enabling runtime PM to avoid it being reverted
  by the PM sync
- Link to v2: https://lore.kernel.org/r/20260302-ina4230-v2-0-55b49d19d2ab@flipper.net

Changes in v2:
- Replace u64/u64 division with do_div() (kernel test robot)
- Add an example with ti,maximum-expected-current-microamp property in
  bindings (Krzysztof Kozlowski)
- Include the newly added binding in MAINTAINERS file (Krzysztof Kozlowski)
- Use dev_err_probe() where appropriate in the driver (Krzysztof Kozlowski)
- Switch to devm_regmap_field_bulk_alloc() instead of an open-coded loop
- Add a bounds check for the calculated calibration value,
  and a corresponding error message
- Link to v1: https://lore.kernel.org/r/20260225-ina4230-v1-0-92b1de981d46@flipper.net

---
Alexey Charkov (2):
      dt-bindings: hwmon: Add TI INA4230 4-channel I2C power monitor
      hwmon: Add support for TI INA4230 power monitor

 .../devicetree/bindings/hwmon/ti,ina4230.yaml      | 134 +++
 MAINTAINERS                                        |   7 +
 drivers/hwmon/Kconfig                              |  11 +
 drivers/hwmon/Makefile                             |   1 +
 drivers/hwmon/ina4230.c                            | 986 +++++++++++++++++++++
 5 files changed, 1139 insertions(+)
---
base-commit: 3b058d1aeeeff27a7289529c4944291613b364e9
change-id: 20260219-ina4230-74a02409153d

Best regards,
-- 
Alexey Charkov <alchark@flipper.net>

[PATCH v5 1/2] dt-bindings: hwmon: Add TI INA4230 4-channel I2C power monitor

[Alexey Charkov]

Add TI INA4230, which is a 48V 4-channel 16-bit I2C-based
current/voltage/power/energy monitor with alert function.

Link: https://www.ti.com/product/INA4230
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
 .../devicetree/bindings/hwmon/ti,ina4230.yaml      | 134 +++++++++++++++++++++
 MAINTAINERS                                        |   6 +
 2 files changed, 140 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina4230.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina4230.yaml
new file mode 100644
index 000000000000..d9b5f9857249
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/ti,ina4230.yaml
@@ -0,0 +1,134 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/ti,ina4230.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments INA4230 quad-channel power monitors
+
+maintainers:
+  - Alexey Charkov <alchark@flipper.net>
+
+description: |
+  The INA4230 is a 48V quad-channel 16-bit current, voltage, power and energy
+  monitor with an I2C interface.
+
+  Datasheet:
+    https://www.ti.com/product/INA4230
+
+properties:
+  compatible:
+    enum:
+      - ti,ina4230
+
+  reg:
+    maxItems: 1
+
+  "#address-cells":
+    description: Required only if a child node is present.
+    const: 1
+
+  "#size-cells":
+    description: Required only if a child node is present.
+    const: 0
+
+  vs-supply:
+    description: phandle to the regulator that provides the VS supply typically
+      in range from 1.7 V to 5.5 V.
+
+  ti,alert-polarity-active-high:
+    description: Alert pin is asserted based on the value of Alert polarity Bit
+      of the CONFIG2 register. Default value is 0, for which the alert pin
+      toggles from high to low during faults. When this property is set, the
+      corresponding register bit is set to 1, and the alert pin toggles from
+      low to high during faults.
+    $ref: /schemas/types.yaml#/definitions/flag
+
+patternProperties:
+  "^input@[0-3]$":
+    description: Optional subnodes for four input channels. Each subnode
+      describes one input channel. Input channels default to enabled in the
+      chip. Unless channels are explicitly disabled in device-tree, input
+      channels will be enabled.
+    type: object
+    additionalProperties: false
+    properties:
+      reg:
+        description: Must be 0, 1, 2 or 3, corresponding to the IN1, IN2, IN3
+          or IN4 ports of the INA4230, respectively.
+        enum: [ 0, 1, 2, 3 ]
+
+      label:
+        description: name of the input source
+
+      shunt-resistor-micro-ohms:
+        description: shunt resistor value in micro-Ohm
+
+      ti,maximum-expected-current-microamp:
+        description: |
+          This value indicates the maximum current in microamps that you can
+          expect to measure with ina4230 in your circuit.
+
+          This value will be used to calculate the Current_LSB to maximize the
+          available precision while ensuring your expected maximum current fits
+          within the chip's ADC range. It will also enable built-in shunt gain
+          to increase ADC granularity by a factor of 4 if the provided maximum
+          current / shunt resistance combination does not produce more than
+          20.48 mV drop at the shunt.
+        minimum: 32768
+        maximum: 2147483647
+        default: 32768000
+
+    required:
+      - reg
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: hwmon-common.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        power-sensor@44 {
+            compatible = "ti,ina4230";
+            reg = <0x44>;
+            vs-supply = <&vdd_3v0>;
+            ti,alert-polarity-active-high;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            input@0 {
+                reg = <0x0>;
+                /*
+                 * Input channels are enabled by default in the device and so
+                 * to disable, must be explicitly disabled in device-tree.
+                 */
+                status = "disabled";
+            };
+
+            input@1 {
+                reg = <0x1>;
+                shunt-resistor-micro-ohms = <50000>;
+                ti,maximum-expected-current-microamp = <300000>;
+            };
+
+            input@2 {
+                reg = <0x2>;
+                label = "VDD_5V";
+                shunt-resistor-micro-ohms = <10000>;
+                ti,maximum-expected-current-microamp = <5000000>;
+            };
+
+            input@3 {
+                reg = <0x3>;
+            };
+        };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index ff935e197c21..acfa0b0585a5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12574,6 +12574,12 @@ S:	Maintained
 F:	Documentation/hwmon/ina233.rst
 F:	drivers/hwmon/pmbus/ina233.c
 
+INA4230 HWMON DRIVER
+M:	Alexey Charkov <alchark@flipper.net>
+L:	linux-hwmon@vger.kernel.org
+S:	Maintained
+F:	Documentation/devicetree/bindings/hwmon/ti,ina4230.yaml
+
 INDEX OF FURTHER KERNEL DOCUMENTATION
 M:	Carlos Bilbao <carlos.bilbao@kernel.org>
 S:	Maintained

-- 
2.52.0

[PATCH v5 2/2] hwmon: Add support for TI INA4230 power monitor

[Alexey Charkov]

Add a driver for the TI INA4230, a 4-channel power monitor with I2C
interface.

The driver supports voltage, current, power and energy measurements, but
skips the alert functionality in this initial implementation.

Signed-off-by: Alexey Charkov <alchark@flipper.net>
---
 MAINTAINERS             |   1 +
 drivers/hwmon/Kconfig   |  11 +
 drivers/hwmon/Makefile  |   1 +
 drivers/hwmon/ina4230.c | 986 ++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 999 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index acfa0b0585a5..9fc627b809a4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12579,6 +12579,7 @@ M:	Alexey Charkov <alchark@flipper.net>
 L:	linux-hwmon@vger.kernel.org
 S:	Maintained
 F:	Documentation/devicetree/bindings/hwmon/ti,ina4230.yaml
+F:	drivers/hwmon/ina4230.c
 
 INDEX OF FURTHER KERNEL DOCUMENTATION
 M:	Carlos Bilbao <carlos.bilbao@kernel.org>
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 9d49cfd4ef3d..4649f00f24ca 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -2296,6 +2296,17 @@ config SENSORS_INA3221
 	  This driver can also be built as a module. If so, the module
 	  will be called ina3221.
 
+config SENSORS_INA4230
+	tristate "Texas Instruments INA4230 Quad Current/Voltage Monitor"
+	depends on I2C
+	select REGMAP_I2C
+	help
+	  If you say yes here you get support for the TI INA4230 Quad
+	  Current/Voltage Monitor.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called ina4230.
+
 config SENSORS_SPD5118
 	tristate "SPD5118 Compliant Temperature Sensors"
 	depends on I2C
diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
index 556e86d277b1..3d83eba94bec 100644
--- a/drivers/hwmon/Makefile
+++ b/drivers/hwmon/Makefile
@@ -104,6 +104,7 @@ obj-$(CONFIG_SENSORS_INA209)	+= ina209.o
 obj-$(CONFIG_SENSORS_INA2XX)	+= ina2xx.o
 obj-$(CONFIG_SENSORS_INA238)	+= ina238.o
 obj-$(CONFIG_SENSORS_INA3221)	+= ina3221.o
+obj-$(CONFIG_SENSORS_INA4230)	+= ina4230.o
 obj-$(CONFIG_SENSORS_INTEL_M10_BMC_HWMON) += intel-m10-bmc-hwmon.o
 obj-$(CONFIG_SENSORS_ISL28022)	+= isl28022.o
 obj-$(CONFIG_SENSORS_IT87)	+= it87.o
diff --git a/drivers/hwmon/ina4230.c b/drivers/hwmon/ina4230.c
new file mode 100644
index 000000000000..a31a3f995afc
--- /dev/null
+++ b/drivers/hwmon/ina4230.c
@@ -0,0 +1,986 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * INA4230 Quad Current/Voltage Monitor
+ *
+ * Based on INA3221 driver by Texas Instruments Incorporated - https://www.ti.com/
+ * Adapted for INA4230 by Alexey Charkov <alchark@flipper.net>
+ */
+
+#include <linux/bitfield.h>
+#include <linux/byteorder/generic.h>
+#include <linux/hwmon.h>
+#include <linux/hwmon-sysfs.h>
+#include <linux/i2c.h>
+#include <linux/math.h>
+#include <linux/math64.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <linux/util_macros.h>
+
+#define INA4230_DRIVER_NAME			"ina4230"
+
+#define INA4230_SHUNT_VOLTAGE_CH1		0x00
+#define INA4230_BUS_VOLTAGE_CH1			0x01
+#define INA4230_CURRENT_CH1			0x02
+#define INA4230_POWER_CH1			0x03
+#define INA4230_ENERGY_CH1			0x04
+#define INA4230_CALIBRATION_CH1			0x05
+#define INA4230_ALERT_LIMIT1			0x06
+#define INA4230_ALERT_CONFIG1			0x07
+#define INA4230_SHUNT_VOLTAGE_CH2		0x08
+#define INA4230_BUS_VOLTAGE_CH2			0x09
+#define INA4230_CURRENT_CH2			0x0A
+#define INA4230_POWER_CH2			0x0B
+#define INA4230_ENERGY_CH2			0x0C
+#define INA4230_CALIBRATION_CH2			0x0D
+#define INA4230_ALERT_LIMIT2			0x0E
+#define INA4230_ALERT_CONFIG2			0x0F
+#define INA4230_SHUNT_VOLTAGE_CH3		0x10
+#define INA4230_BUS_VOLTAGE_CH3			0x11
+#define INA4230_CURRENT_CH3			0x12
+#define INA4230_POWER_CH3			0x13
+#define INA4230_ENERGY_CH3			0x14
+#define INA4230_CALIBRATION_CH3			0x15
+#define INA4230_ALERT_LIMIT3			0x16
+#define INA4230_ALERT_CONFIG3			0x17
+#define INA4230_SHUNT_VOLTAGE_CH4		0x18
+#define INA4230_BUS_VOLTAGE_CH4			0x19
+#define INA4230_CURRENT_CH4			0x1A
+#define INA4230_POWER_CH4			0x1B
+#define INA4230_ENERGY_CH4			0x1C
+#define INA4230_CALIBRATION_CH4			0x1D
+#define INA4230_ALERT_LIMIT4			0x1E
+#define INA4230_ALERT_CONFIG4			0x1F
+#define INA4230_CONFIG1				0x20
+#define INA4230_CONFIG2				0x21
+#define INA4230_FLAGS				0x22
+#define INA4230_MANUFACTURER_ID			0x7E
+
+#define INA4230_CALIBRATION_MASK		GENMASK(14, 0)
+
+#define INA4230_ALERT_CHANNEL_MASK		GENMASK(4, 3)
+#define INA4230_ALERT_MASK			GENMASK(2, 0)
+/* Shunt voltage over limit */
+#define INA4230_ALERT_MASK_SOL			0x1
+/* Shunt voltage under limit */
+#define INA4230_ALERT_MASK_SUL			0x2
+/* Bus voltage over limit */
+#define INA4230_ALERT_MASK_BOL			0x3
+/* Bus voltage under limit */
+#define INA4230_ALERT_MASK_BUL			0x4
+/* Power over limit */
+#define INA4230_ALERT_MASK_POL			0x5
+
+#define INA4230_CONFIG1_ACTIVE_CHANNEL_MASK	GENMASK(15, 12)
+#define INA4230_CONFIG1_AVG_MASK		GENMASK(11, 9)
+#define INA4230_CONFIG1_VBUSCT_MASK		GENMASK(8, 6)
+#define INA4230_CONFIG1_VSHCT_MASK		GENMASK(5, 3)
+#define INA4230_CONFIG1_MODE_MASK		GENMASK(2, 0)
+#define INA4230_MODE_POWERDOWN			0
+#define INA4230_MODE_SHUNT_SINGLE		1
+#define INA4230_MODE_BUS_SINGLE			2
+#define INA4230_MODE_BUS_SHUNT_SINGLE		3
+#define INA4230_MODE_POWERDOWN1			4
+#define INA4230_MODE_SHUNT_CONTINUOUS		5
+#define INA4230_MODE_BUS_CONTINUOUS		6
+#define INA4230_MODE_BUS_SHUNT_CONTINUOUS	7
+
+#define INA4230_CONFIG2_RST			BIT(15)
+#define INA4230_CONFIG2_ACC_RST_MASK		GENMASK(11, 8)
+#define INA4230_CONFIG2_CNVR_MASK		BIT(7)
+#define INA4230_CONFIG2_ENOF_MASK		BIT(6)
+#define INA4230_CONFIG2_ALERT_LATCH		BIT(5)
+#define INA4230_CONFIG2_ALERT_POL		BIT(4)
+#define INA4230_CONFIG2_RANGE_MASK		GENMASK(3, 0)
+#define INA4230_CONFIG2_RANGE_CH(x) \
+		FIELD_PREP(INA4230_CONFIG2_RANGE_MASK, BIT((x)))
+
+#define INA4230_FLAGS_LIMIT4_ALERT		BIT(15)
+#define INA4230_FLAGS_LIMIT3_ALERT		BIT(14)
+#define INA4230_FLAGS_LIMIT2_ALERT		BIT(13)
+#define INA4230_FLAGS_LIMIT1_ALERT		BIT(12)
+#define INA4230_FLAGS_ENERGY_OVERFLOW_CH4	BIT(11)
+#define INA4230_FLAGS_ENERGY_OVERFLOW_CH3	BIT(10)
+#define INA4230_FLAGS_ENERGY_OVERFLOW_CH2	BIT(9)
+#define INA4230_FLAGS_ENERGY_OVERFLOW_CH1	BIT(8)
+#define INA4230_FLAGS_CVRF			BIT(7)
+#define INA4230_FLAGS_MATH_OVERFLOW		BIT(6)
+
+#define INA4230_RSHUNT_DEFAULT			10000
+#define INA4230_CONFIG_DEFAULT \
+		(FIELD_PREP(INA4230_CONFIG1_ACTIVE_CHANNEL_MASK, 0xF) | \
+		FIELD_PREP(INA4230_CONFIG1_AVG_MASK, 0x1) | \
+		FIELD_PREP(INA4230_CONFIG1_VBUSCT_MASK, 0x4) | \
+		FIELD_PREP(INA4230_CONFIG1_VSHCT_MASK, 0x4) | \
+		FIELD_PREP(INA4230_CONFIG1_MODE_MASK, 0x7))
+#define INA4230_CONFIG_CHx_EN(x) \
+		FIELD_PREP(INA4230_CONFIG1_ACTIVE_CHANNEL_MASK, BIT((x)))
+
+enum ina4230_fields {
+	/* Alert configuration settings: channel masks */
+	F_ALERT1_CH, F_ALERT2_CH, F_ALERT3_CH, F_ALERT4_CH,
+	/* Alert configuration settings: alert masks */
+	F_ALERT1_TYPE, F_ALERT2_TYPE, F_ALERT3_TYPE, F_ALERT4_TYPE,
+	/* Configuration registers */
+	F_CH_EN, F_AVG, F_VBUSCT, F_VSHCT, F_MODE,
+	F_RST, F_ACC_RST, F_CNV_ALERT, F_ENOF, F_ALERT_LATCH, F_ALERT_POL, F_RANGE,
+	/* Status flags */
+	F_LIMIT1_ALERT, F_LIMIT2_ALERT, F_LIMIT3_ALERT, F_LIMIT4_ALERT,
+	F_ENERGY_OVERFLOW_CH1, F_ENERGY_OVERFLOW_CH2, F_ENERGY_OVERFLOW_CH3, F_ENERGY_OVERFLOW_CH4,
+	F_CVRF, F_MATH_OVERFLOW,
+	/* sentinel */
+	F_MAX_FIELDS
+};
+
+static const struct reg_field ina4230_reg_fields[] = {
+	[F_ALERT1_CH] = REG_FIELD(INA4230_ALERT_CONFIG1, 3, 4),
+	[F_ALERT2_CH] = REG_FIELD(INA4230_ALERT_CONFIG2, 3, 4),
+	[F_ALERT3_CH] = REG_FIELD(INA4230_ALERT_CONFIG3, 3, 4),
+	[F_ALERT4_CH] = REG_FIELD(INA4230_ALERT_CONFIG4, 3, 4),
+
+	[F_ALERT1_TYPE] = REG_FIELD(INA4230_ALERT_CONFIG1, 0, 2),
+	[F_ALERT2_TYPE] = REG_FIELD(INA4230_ALERT_CONFIG2, 0, 2),
+	[F_ALERT3_TYPE] = REG_FIELD(INA4230_ALERT_CONFIG3, 0, 2),
+	[F_ALERT4_TYPE] = REG_FIELD(INA4230_ALERT_CONFIG4, 0, 2),
+
+	[F_CH_EN] = REG_FIELD(INA4230_CONFIG1, 12, 15),
+	[F_AVG] = REG_FIELD(INA4230_CONFIG1, 9, 11),
+	[F_VBUSCT] = REG_FIELD(INA4230_CONFIG1, 6, 8),
+	[F_VSHCT] = REG_FIELD(INA4230_CONFIG1, 3, 5),
+	[F_MODE] = REG_FIELD(INA4230_CONFIG1, 0, 2),
+	[F_RST] = REG_FIELD(INA4230_CONFIG2, 15, 15),
+	[F_ACC_RST] = REG_FIELD(INA4230_CONFIG2, 8, 11),
+	[F_CNV_ALERT] = REG_FIELD(INA4230_CONFIG2, 7, 7),
+	[F_ENOF] = REG_FIELD(INA4230_CONFIG2, 6, 6),
+	[F_ALERT_LATCH] = REG_FIELD(INA4230_CONFIG2, 5, 5),
+	[F_ALERT_POL] = REG_FIELD(INA4230_CONFIG2, 4, 4),
+	[F_RANGE] = REG_FIELD(INA4230_CONFIG2, 0, 3),
+
+	[F_LIMIT1_ALERT] = REG_FIELD(INA4230_FLAGS, 12, 12),
+	[F_LIMIT2_ALERT] = REG_FIELD(INA4230_FLAGS, 13, 13),
+	[F_LIMIT3_ALERT] = REG_FIELD(INA4230_FLAGS, 14, 14),
+	[F_LIMIT4_ALERT] = REG_FIELD(INA4230_FLAGS, 15, 15),
+	[F_ENERGY_OVERFLOW_CH1] = REG_FIELD(INA4230_FLAGS, 8, 8),
+	[F_ENERGY_OVERFLOW_CH2] = REG_FIELD(INA4230_FLAGS, 9, 9),
+	[F_ENERGY_OVERFLOW_CH3] = REG_FIELD(INA4230_FLAGS, 10, 10),
+	[F_ENERGY_OVERFLOW_CH4] = REG_FIELD(INA4230_FLAGS, 11, 11),
+	[F_CVRF] = REG_FIELD(INA4230_FLAGS, 7, 7),
+	[F_MATH_OVERFLOW] = REG_FIELD(INA4230_FLAGS, 6, 6),
+};
+
+enum ina4230_channels {
+	INA4230_CHANNEL1,
+	INA4230_CHANNEL2,
+	INA4230_CHANNEL3,
+	INA4230_CHANNEL4,
+	INA4230_NUM_CHANNELS
+};
+
+/**
+ * struct ina4230_input - channel input source specific information
+ * @label: label of channel input source
+ * @shunt_resistor: shunt resistor value of channel input source
+ * @shunt_gain: gain of shunt voltage for current calculation
+ * @max_expected_current: maximum expected current in micro-Ampere for ADC
+ *			  calibration
+ * @current_lsb_uA: current LSB in micro-Amperes
+ * @disconnected: connection status of channel input source
+ */
+struct ina4230_input {
+	const char *label;
+	int shunt_resistor;
+	int shunt_gain;
+	int max_expected_current;
+	int current_lsb_uA;
+	bool disconnected;
+};
+
+/**
+ * struct ina4230_data - device specific information
+ * @pm_dev: Device pointer for pm runtime
+ * @regmap: Register map of the device
+ * @fields: Register fields of the device
+ * @inputs: Array of channel input source specific structures
+ * @reg_config1: cached value of CONFIG1 register
+ * @reg_config2: cached value of CONFIG2 register
+ * @alert_active_high: flag indicating alert polarity is active high
+ */
+struct ina4230_data {
+	struct device *pm_dev;
+	struct regmap *regmap;
+	struct regmap_field *fields[F_MAX_FIELDS];
+	struct ina4230_input inputs[INA4230_NUM_CHANNELS];
+	unsigned int reg_config1;
+	unsigned int reg_config2;
+	bool alert_active_high;
+};
+
+static inline bool ina4230_is_enabled(struct ina4230_data *ina, int channel)
+{
+	return pm_runtime_active(ina->pm_dev) &&
+		!ina->inputs[channel].disconnected &&
+		ina->reg_config1 & INA4230_CONFIG_CHx_EN(channel);
+}
+
+/* Lookup table for Bus and Shunt conversion times in usec */
+static const u16 ina4230_conv_time[] = {
+	140, 204, 332, 588, 1100, 2116, 4156, 8244,
+};
+
+/* Lookup table for number of samples used in averaging mode */
+static const int ina4230_avg_samples[] = {
+	1, 4, 16, 64, 128, 256, 512, 1024,
+};
+
+/* Converting update_interval in msec to conversion time in usec */
+static inline u32 ina4230_interval_ms_to_conv_time(u16 config, int interval)
+{
+	u32 channels = hweight16(config & INA4230_CONFIG1_ACTIVE_CHANNEL_MASK);
+	u32 samples_idx = FIELD_GET(INA4230_CONFIG1_AVG_MASK, config);
+	u32 samples = ina4230_avg_samples[samples_idx];
+
+	if (!channels)
+		return U32_MAX;
+
+	/* Bisect the result to Bus and Shunt conversion times */
+	return DIV_ROUND_CLOSEST(interval * 1000 / 2, channels * samples);
+}
+
+/* Converting CONFIG register value to update_interval in usec */
+static inline u32 ina4230_reg_to_interval_us(u16 config)
+{
+	u32 channels = hweight16(config & INA4230_CONFIG1_ACTIVE_CHANNEL_MASK);
+	u32 vbus_ct_idx = FIELD_GET(INA4230_CONFIG1_VBUSCT_MASK, config);
+	u32 vsh_ct_idx = FIELD_GET(INA4230_CONFIG1_VSHCT_MASK, config);
+	u32 vbus_ct = ina4230_conv_time[vbus_ct_idx];
+	u32 vsh_ct = ina4230_conv_time[vsh_ct_idx];
+
+	/* Calculate total conversion time */
+	return channels * (vbus_ct + vsh_ct);
+}
+
+static const u8 ina4230_calibration_reg[] = {
+	INA4230_CALIBRATION_CH1,
+	INA4230_CALIBRATION_CH2,
+	INA4230_CALIBRATION_CH3,
+	INA4230_CALIBRATION_CH4,
+};
+
+static int ina4230_set_calibration(struct ina4230_data *ina, int channel)
+{
+	struct ina4230_input *input = &ina->inputs[channel];
+	u8 reg = ina4230_calibration_reg[channel];
+	int shunt_range_uV, ret;
+	u32 calibration;
+	u64 n, d;
+
+	shunt_range_uV = mult_frac(input->max_expected_current,
+				   input->shunt_resistor,
+				   1000000);
+	input->shunt_gain = shunt_range_uV > 20480 ? 1 : 4;
+	ina->reg_config2 &= ~INA4230_CONFIG2_RANGE_CH(channel);
+	if (input->shunt_gain == 4)
+		ina->reg_config2 |= INA4230_CONFIG2_RANGE_CH(channel);
+
+	ret = regmap_write(ina->regmap, INA4230_CONFIG2, ina->reg_config2);
+	if (ret)
+		return ret;
+
+	input->current_lsb_uA = DIV_ROUND_UP(input->max_expected_current, 32768);
+	n = 5120000000ULL;
+	d = (u64)input->current_lsb_uA * input->shunt_resistor * input->shunt_gain;
+	/* Ensure rounding to the closest integer */
+	n += d / 2;
+	n = div64_u64(n, d);
+	if (n > INA4230_CALIBRATION_MASK) {
+		dev_err(ina->pm_dev,
+			"Shunt %duOhm too low for expected current %duA, cannot calibrate channel %d\n",
+			input->shunt_resistor, input->max_expected_current, channel + 1);
+		return -ERANGE;
+	}
+
+	calibration = n & INA4230_CALIBRATION_MASK;
+
+	return regmap_write(ina->regmap, reg, calibration);
+}
+
+static const u8 ina4230_in_reg[] = {
+	INA4230_BUS_VOLTAGE_CH1,
+	INA4230_BUS_VOLTAGE_CH2,
+	INA4230_BUS_VOLTAGE_CH3,
+	INA4230_BUS_VOLTAGE_CH4,
+	INA4230_SHUNT_VOLTAGE_CH1,
+	INA4230_SHUNT_VOLTAGE_CH2,
+	INA4230_SHUNT_VOLTAGE_CH3,
+	INA4230_SHUNT_VOLTAGE_CH4,
+};
+
+static const u8 ina4230_curr_reg[][INA4230_NUM_CHANNELS] = {
+	[hwmon_curr_input] = { INA4230_CURRENT_CH1, INA4230_CURRENT_CH2,
+			       INA4230_CURRENT_CH3, INA4230_CURRENT_CH4 },
+};
+
+static const u8 ina4230_power_reg[] = {
+	INA4230_POWER_CH1, INA4230_POWER_CH2, INA4230_POWER_CH3, INA4230_POWER_CH4
+};
+
+static const u8 ina4230_energy_reg[] = {
+	INA4230_ENERGY_CH1, INA4230_ENERGY_CH2,
+	INA4230_ENERGY_CH3, INA4230_ENERGY_CH4
+};
+
+static int ina4230_read_chip(struct device *dev, u32 attr, long *val)
+{
+	struct ina4230_data *ina = dev_get_drvdata(dev);
+	int regval;
+
+	switch (attr) {
+	case hwmon_chip_samples:
+		regval = FIELD_GET(INA4230_CONFIG1_AVG_MASK, ina->reg_config1);
+		*val = ina4230_avg_samples[regval];
+		return 0;
+	case hwmon_chip_update_interval:
+		/* Return in msec */
+		*val = ina4230_reg_to_interval_us(ina->reg_config1);
+		*val = DIV_ROUND_CLOSEST(*val, 1000);
+		return 0;
+	default:
+		return -EOPNOTSUPP;
+	}
+}
+
+static int ina4230_read_in(struct device *dev, u32 attr, int channel, long *val)
+{
+	const bool is_shunt = channel > INA4230_CHANNEL4;
+	struct ina4230_data *ina = dev_get_drvdata(dev);
+	u8 reg = ina4230_in_reg[channel];
+	int regval, ret;
+
+	/*
+	 * Translate shunt channel index to sensor channel index
+	 */
+	channel %= INA4230_NUM_CHANNELS;
+
+	switch (attr) {
+	case hwmon_in_input:
+		if (!ina4230_is_enabled(ina, channel))
+			return -ENODATA;
+
+		ret = regmap_read(ina->regmap, reg, &regval);
+		if (ret)
+			return ret;
+
+		/*
+		 * Scale of shunt voltage (uV): LSB is 2.5uV or 625nV
+		 *				depending on gain setting
+		 * Scale of bus voltage (mV): LSB is 1.6mV
+		 */
+		if (is_shunt)
+			*val = mult_frac((long)(int16_t)regval,
+					 2500 / ina->inputs[channel].shunt_gain,
+					 1000000);
+		else
+			*val = mult_frac((long)(int16_t)regval,
+					 1600,
+					 1000);
+		return 0;
+	case hwmon_in_enable:
+		*val = ina4230_is_enabled(ina, channel);
+		return 0;
+	default:
+		return -EOPNOTSUPP;
+	}
+}
+
+static int ina4230_read_power(struct device *dev, u32 attr, int channel, long *val)
+{
+	struct ina4230_data *ina = dev_get_drvdata(dev);
+	u8 reg = ina4230_power_reg[channel];
+	int regval, ret;
+
+	switch (attr) {
+	case hwmon_power_input:
+		if (!ina4230_is_enabled(ina, channel))
+			return -ENODATA;
+
+		ret = regmap_read(ina->regmap, reg, &regval);
+		if (ret)
+			return ret;
+
+		*val = (int16_t)regval *
+			(long)ina->inputs[channel].current_lsb_uA * 32;
+		return 0;
+	default:
+		return -EOPNOTSUPP;
+	}
+}
+
+static int ina4230_read_energy(struct device *dev, u32 attr, int channel, long *val)
+{
+	struct ina4230_data *ina = dev_get_drvdata(dev);
+	u8 reg = ina4230_energy_reg[channel];
+	int ret;
+	__be32 regval;
+
+	switch (attr) {
+	case hwmon_energy_input:
+		if (!ina4230_is_enabled(ina, channel))
+			return -ENODATA;
+
+		ret = regmap_noinc_read(ina->regmap, reg, &regval, sizeof(regval));
+		if (ret)
+			return ret;
+
+		*val = be32_to_cpu(regval) *
+			(long)ina->inputs[channel].current_lsb_uA * 32;
+		return 0;
+	default:
+		return -EOPNOTSUPP;
+	}
+}
+
+static int ina4230_read_curr(struct device *dev, u32 attr,
+			     int channel, long *val)
+{
+	struct ina4230_data *ina = dev_get_drvdata(dev);
+	u8 reg = ina4230_curr_reg[attr][channel];
+	int regval, ret;
+
+	switch (attr) {
+	case hwmon_curr_input:
+		if (!ina4230_is_enabled(ina, channel))
+			return -ENODATA;
+
+		ret = regmap_read(ina->regmap, reg, &regval);
+		if (ret)
+			return ret;
+
+		*val = (int16_t)regval *
+			(long)ina->inputs[channel].current_lsb_uA / 1000;
+		return 0;
+	default:
+		return -EOPNOTSUPP;
+	}
+}
+
+static int ina4230_write_chip(struct device *dev, u32 attr, long val)
+{
+	struct ina4230_data *ina = dev_get_drvdata(dev);
+	int idx;
+	u32 tmp;
+
+	switch (attr) {
+	case hwmon_chip_samples:
+		idx = find_closest(val, ina4230_avg_samples,
+				   ARRAY_SIZE(ina4230_avg_samples));
+
+		FIELD_MODIFY(INA4230_CONFIG1_AVG_MASK, &ina->reg_config1, idx);
+		return regmap_write(ina->regmap, INA4230_CONFIG1, ina->reg_config1);
+	case hwmon_chip_update_interval:
+		tmp = ina4230_interval_ms_to_conv_time(ina->reg_config1, val);
+		idx = find_closest(tmp, ina4230_conv_time,
+				   ARRAY_SIZE(ina4230_conv_time));
+
+		FIELD_MODIFY(INA4230_CONFIG1_VBUSCT_MASK, &ina->reg_config1, idx);
+		FIELD_MODIFY(INA4230_CONFIG1_VSHCT_MASK, &ina->reg_config1, idx);
+		return regmap_write(ina->regmap, INA4230_CONFIG1, ina->reg_config1);
+	default:
+		return -EOPNOTSUPP;
+	}
+}
+
+static int ina4230_write_enable(struct device *dev, int channel, bool enable)
+{
+	struct ina4230_data *ina = dev_get_drvdata(dev);
+	u16 config, mask = INA4230_CONFIG_CHx_EN(channel);
+	u16 config_old = ina->reg_config1 & mask;
+	u32 tmp;
+	int ret;
+
+	config = enable ? mask : 0;
+
+	/* Bypass if enable status is not being changed */
+	if (config_old == config)
+		return 0;
+
+	/* For enabling routine, increase refcount and resume() at first */
+	if (enable) {
+		ret = pm_runtime_resume_and_get(ina->pm_dev);
+		if (ret < 0) {
+			dev_err(dev, "Failed to get PM runtime\n");
+			return ret;
+		}
+	}
+
+	/* Enable or disable the channel */
+	tmp = (ina->reg_config1 & ~mask) | (config & mask);
+	ret = regmap_write(ina->regmap, INA4230_CONFIG1, tmp);
+	if (ret)
+		goto fail;
+
+	/* Cache the latest config register value */
+	ina->reg_config1 = tmp;
+
+	/* For disabling routine, decrease refcount or suspend() at last */
+	if (!enable)
+		pm_runtime_put_sync(ina->pm_dev);
+
+	return 0;
+
+fail:
+	if (enable) {
+		dev_err(dev, "Failed to enable channel %d: error %d\n",
+			channel, ret);
+		pm_runtime_put_sync(ina->pm_dev);
+	}
+
+	return ret;
+}
+
+static int ina4230_read(struct device *dev, enum hwmon_sensor_types type,
+			u32 attr, int channel, long *val)
+{
+	int ret;
+
+	switch (type) {
+	case hwmon_chip:
+		ret = ina4230_read_chip(dev, attr, val);
+		break;
+	case hwmon_in:
+		/* 0-align channel ID */
+		ret = ina4230_read_in(dev, attr, channel - 1, val);
+		break;
+	case hwmon_curr:
+		ret = ina4230_read_curr(dev, attr, channel, val);
+		break;
+	case hwmon_power:
+		ret = ina4230_read_power(dev, attr, channel, val);
+		break;
+	case hwmon_energy:
+		ret = ina4230_read_energy(dev, attr, channel, val);
+		break;
+	default:
+		ret = -EOPNOTSUPP;
+		break;
+	}
+	return ret;
+}
+
+static int ina4230_write(struct device *dev, enum hwmon_sensor_types type,
+			 u32 attr, int channel, long val)
+{
+	int ret;
+
+	switch (type) {
+	case hwmon_chip:
+		ret = ina4230_write_chip(dev, attr, val);
+		break;
+	case hwmon_in:
+		/* 0-align channel ID */
+		ret = ina4230_write_enable(dev, channel - 1, val);
+		break;
+	default:
+		ret = -EOPNOTSUPP;
+		break;
+	}
+	return ret;
+}
+
+static int ina4230_read_string(struct device *dev, enum hwmon_sensor_types type,
+			       u32 attr, int channel, const char **str)
+{
+	struct ina4230_data *ina = dev_get_drvdata(dev);
+	int index = channel - 1;
+
+	*str = ina->inputs[index].label;
+
+	return 0;
+}
+
+static umode_t ina4230_is_visible(const void *drvdata,
+				  enum hwmon_sensor_types type,
+				  u32 attr, int channel)
+{
+	const struct ina4230_data *ina = drvdata;
+	const struct ina4230_input *input = NULL;
+
+	switch (type) {
+	case hwmon_chip:
+		switch (attr) {
+		case hwmon_chip_samples:
+		case hwmon_chip_update_interval:
+			return 0644;
+		default:
+			return 0;
+		}
+	case hwmon_in:
+		/* Ignore in0_ */
+		if (channel == 0)
+			return 0;
+
+		switch (attr) {
+		case hwmon_in_label:
+			if (channel - 1 <= INA4230_CHANNEL4)
+				input = &ina->inputs[channel - 1];
+			/* Hide label node if label is not provided */
+			return (input && input->label) ? 0444 : 0;
+		case hwmon_in_input:
+			return 0444;
+		case hwmon_in_enable:
+			return 0644;
+		default:
+			return 0;
+		}
+	case hwmon_curr:
+		switch (attr) {
+		case hwmon_curr_input:
+			return 0444;
+		default:
+			return 0;
+		}
+	case hwmon_power:
+		switch (attr) {
+		case hwmon_power_input:
+			return 0444;
+		default:
+			return 0;
+		}
+	case hwmon_energy:
+		switch (attr) {
+		case hwmon_energy_input:
+			return 0444;
+		default:
+			return 0;
+		}
+	default:
+		return 0;
+	}
+}
+
+static const struct hwmon_channel_info * const ina4230_info[] = {
+	HWMON_CHANNEL_INFO(chip,
+			   HWMON_C_SAMPLES,
+			   HWMON_C_UPDATE_INTERVAL),
+	HWMON_CHANNEL_INFO(in,
+			   /* 0: dummy, skipped in is_visible */
+			   HWMON_I_INPUT,
+			   /* 1-4: input voltage Channels */
+			   HWMON_I_INPUT | HWMON_I_ENABLE | HWMON_I_LABEL,
+			   HWMON_I_INPUT | HWMON_I_ENABLE | HWMON_I_LABEL,
+			   HWMON_I_INPUT | HWMON_I_ENABLE | HWMON_I_LABEL,
+			   HWMON_I_INPUT | HWMON_I_ENABLE | HWMON_I_LABEL,
+			   /* 5-8: shunt voltage Channels */
+			   HWMON_I_INPUT,
+			   HWMON_I_INPUT,
+			   HWMON_I_INPUT,
+			   HWMON_I_INPUT),
+	HWMON_CHANNEL_INFO(curr,
+			   /* 1-4: current channels*/
+			   HWMON_C_INPUT,
+			   HWMON_C_INPUT,
+			   HWMON_C_INPUT,
+			   HWMON_C_INPUT),
+	HWMON_CHANNEL_INFO(power,
+			   /* 1-4: power channels*/
+			   HWMON_P_INPUT,
+			   HWMON_P_INPUT,
+			   HWMON_P_INPUT,
+			   HWMON_P_INPUT),
+	HWMON_CHANNEL_INFO(energy,
+			   /* 1-4: energy channels*/
+			   HWMON_E_INPUT,
+			   HWMON_E_INPUT,
+			   HWMON_E_INPUT,
+			   HWMON_E_INPUT),
+	NULL
+};
+
+static const struct hwmon_ops ina4230_hwmon_ops = {
+	.is_visible = ina4230_is_visible,
+	.read_string = ina4230_read_string,
+	.read = ina4230_read,
+	.write = ina4230_write,
+};
+
+static const struct hwmon_chip_info ina4230_chip_info = {
+	.ops = &ina4230_hwmon_ops,
+	.info = ina4230_info,
+};
+
+static const struct regmap_range ina4230_vol_ranges[] = {
+	regmap_reg_range(INA4230_SHUNT_VOLTAGE_CH1, INA4230_ENERGY_CH1),
+	regmap_reg_range(INA4230_SHUNT_VOLTAGE_CH2, INA4230_ENERGY_CH2),
+	regmap_reg_range(INA4230_SHUNT_VOLTAGE_CH3, INA4230_ENERGY_CH3),
+	regmap_reg_range(INA4230_SHUNT_VOLTAGE_CH4, INA4230_ENERGY_CH4),
+	regmap_reg_range(INA4230_CONFIG2, INA4230_CONFIG2),
+	regmap_reg_range(INA4230_FLAGS, INA4230_FLAGS),
+};
+
+static const struct regmap_access_table ina4230_volatile_table = {
+	.yes_ranges = ina4230_vol_ranges,
+	.n_yes_ranges = ARRAY_SIZE(ina4230_vol_ranges),
+};
+
+static const struct regmap_config ina4230_regmap_config = {
+	.reg_bits = 8,
+	.val_bits = 16,
+
+	.cache_type = REGCACHE_MAPLE,
+	.volatile_table = &ina4230_volatile_table,
+};
+
+static int ina4230_probe_child_from_dt(struct device *dev,
+				       struct device_node *child,
+				       struct ina4230_data *ina)
+{
+	struct ina4230_input *input;
+	u32 val;
+	int ret;
+
+	ret = of_property_read_u32(child, "reg", &val);
+	if (ret)
+		return dev_err_probe(dev, ret,
+			"missing reg property of %pOFn\n", child);
+	else if (val > INA4230_CHANNEL4)
+		return dev_err_probe(dev, -EINVAL,
+			"invalid reg %d of %pOFn\n", val, child);
+
+	input = &ina->inputs[val];
+
+	/* Log the disconnected channel input */
+	if (!of_device_is_available(child)) {
+		input->disconnected = true;
+		return 0;
+	}
+
+	/* Save the connected input label if available */
+	of_property_read_string(child, "label", &input->label);
+
+	/* Overwrite default shunt resistor value optionally */
+	if (!of_property_read_u32(child, "shunt-resistor-micro-ohms", &val)) {
+		if (val < 1 || val > INT_MAX)
+			return dev_err_probe(dev, -EINVAL,
+				"invalid shunt resistor value %u of %pOFn\n",
+				val, child);
+
+		input->shunt_resistor = val;
+	}
+
+	/* Save the expected maxcurrent */
+	if (!of_property_read_u32(child, "ti,maximum-expected-current-microamp", &val)) {
+		if (val < 32768 || val > INT_MAX)
+			return dev_err_probe(dev, -EINVAL,
+				"invalid max current value %u of %pOFn\n",
+				val, child);
+
+		input->max_expected_current = val;
+	}
+
+	return 0;
+}
+
+static int ina4230_probe_from_dt(struct device *dev, struct ina4230_data *ina)
+{
+	const struct device_node *np = dev->of_node;
+	int ret;
+
+	/* Compatible with non-DT platforms */
+	if (!np)
+		return 0;
+
+	ina->alert_active_high = of_property_read_bool(np, "ti,alert-polarity-active-high");
+
+	for_each_child_of_node_scoped(np, child) {
+		ret = ina4230_probe_child_from_dt(dev, child, ina);
+		if (ret)
+			return ret;
+	}
+
+	ret = devm_regulator_get_enable_optional(dev, "vs");
+	if (ret && ret != -ENODEV)
+		return dev_err_probe(dev, ret, "Failed to get regulator\n");
+
+	return 0;
+}
+
+static int ina4230_probe(struct i2c_client *client)
+{
+	struct device *dev = &client->dev;
+	struct ina4230_data *ina;
+	struct device *hwmon_dev;
+	int i, ret;
+
+	ina = devm_kzalloc(dev, sizeof(*ina), GFP_KERNEL);
+	if (!ina)
+		return -ENOMEM;
+
+	ina->regmap = devm_regmap_init_i2c(client, &ina4230_regmap_config);
+	if (IS_ERR(ina->regmap))
+		return PTR_ERR(ina->regmap);
+
+	ret = devm_regmap_field_bulk_alloc(dev, ina->regmap, ina->fields,
+					   ina4230_reg_fields,
+					   ARRAY_SIZE(ina4230_reg_fields));
+	if (ret)
+		return ret;
+
+	for (i = 0; i < INA4230_NUM_CHANNELS; i++) {
+		ina->inputs[i].shunt_resistor = INA4230_RSHUNT_DEFAULT;
+		/* Default for 1mA LSB current measurements */
+		ina->inputs[i].max_expected_current = 32768000;
+	}
+
+	ret = ina4230_probe_from_dt(dev, ina);
+	if (ret)
+		return dev_err_probe(dev, ret,
+			"Unable to probe from device tree\n");
+
+	/* The driver will be reset, so use reset value */
+	ina->reg_config1 = INA4230_CONFIG_DEFAULT;
+	ina->reg_config2 = 0;
+
+	if (ina->alert_active_high)
+		FIELD_MODIFY(INA4230_CONFIG2_ALERT_POL, &ina->reg_config2, 1);
+
+	/* Disable channels if their inputs are disconnected */
+	for (i = 0; i < INA4230_NUM_CHANNELS; i++) {
+		if (ina->inputs[i].disconnected)
+			ina->reg_config1 &= ~INA4230_CONFIG_CHx_EN(i);
+	}
+
+	ina->pm_dev = dev;
+	dev_set_drvdata(dev, ina);
+
+	/* Enable PM runtime -- status is suspended by default */
+	pm_runtime_enable(ina->pm_dev);
+
+	/* Initialize (resume) the device */
+	for (i = 0; i < INA4230_NUM_CHANNELS; i++) {
+		if (ina->inputs[i].disconnected)
+			continue;
+
+		/* Match the refcount with number of enabled channels */
+		ret = pm_runtime_get_sync(ina->pm_dev);
+		if (ret < 0)
+			goto fail;
+	}
+
+	/* Set calibration values after device resume/reset */
+	for (i = 0; i < INA4230_NUM_CHANNELS; i++) {
+		if (!ina->inputs[i].disconnected) {
+			ret = ina4230_set_calibration(ina, i);
+			if (ret)
+				goto fail;
+		}
+	}
+
+	hwmon_dev = devm_hwmon_device_register_with_info(dev, client->name, ina,
+							 &ina4230_chip_info,
+							 NULL);
+	if (IS_ERR(hwmon_dev)) {
+		ret = dev_err_probe(dev, PTR_ERR(hwmon_dev),
+			"Unable to register hwmon device\n");
+		goto fail;
+	}
+
+	return 0;
+
+fail:
+	pm_runtime_disable(ina->pm_dev);
+	pm_runtime_set_suspended(ina->pm_dev);
+	/* pm_runtime_put_noidle() for connected channels to balance get_sync */
+	for (i = 0; i < INA4230_NUM_CHANNELS; i++) {
+		if (!ina->inputs[i].disconnected &&
+		    ina->reg_config1 & INA4230_CONFIG_CHx_EN(i))
+			pm_runtime_put_noidle(ina->pm_dev);
+	}
+
+	return ret;
+}
+
+static void ina4230_remove(struct i2c_client *client)
+{
+	struct ina4230_data *ina = dev_get_drvdata(&client->dev);
+	int i;
+
+	pm_runtime_disable(ina->pm_dev);
+	pm_runtime_set_suspended(ina->pm_dev);
+
+	/* pm_runtime_put_noidle() for connected channels to balance get_sync */
+	for (i = 0; i < INA4230_NUM_CHANNELS; i++) {
+		if (!ina->inputs[i].disconnected &&
+		    ina->reg_config1 & INA4230_CONFIG_CHx_EN(i))
+			pm_runtime_put_noidle(ina->pm_dev);
+	}
+}
+
+static int ina4230_suspend(struct device *dev)
+{
+	struct ina4230_data *ina = dev_get_drvdata(dev);
+	int ret;
+
+	/* Save config register value and enable cache-only */
+	ret = regmap_read(ina->regmap, INA4230_CONFIG1, &ina->reg_config1);
+	if (ret)
+		return ret;
+
+	regcache_cache_only(ina->regmap, true);
+	regcache_mark_dirty(ina->regmap);
+
+	return 0;
+}
+
+static int ina4230_resume(struct device *dev)
+{
+	struct ina4230_data *ina = dev_get_drvdata(dev);
+	int ret;
+
+	regcache_cache_only(ina->regmap, false);
+
+	/* Software reset the chip */
+	ret = regmap_field_write(ina->fields[F_RST], true);
+	if (ret) {
+		dev_err(dev, "Unable to reset device\n");
+		return ret;
+	}
+
+	/* Restore cached register values to hardware */
+	ret = regcache_sync(ina->regmap);
+	if (ret)
+		return ret;
+
+	return 0;
+}
+
+static DEFINE_RUNTIME_DEV_PM_OPS(ina4230_pm, ina4230_suspend, ina4230_resume,
+				 NULL);
+
+static const struct of_device_id ina4230_of_match_table[] = {
+	{ .compatible = "ti,ina4230", },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, ina4230_of_match_table);
+
+static const struct i2c_device_id ina4230_ids[] = {
+	{ "ina4230" },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(i2c, ina4230_ids);
+
+static struct i2c_driver ina4230_i2c_driver = {
+	.probe = ina4230_probe,
+	.remove = ina4230_remove,
+	.driver = {
+		.name = INA4230_DRIVER_NAME,
+		.of_match_table = ina4230_of_match_table,
+		.pm = pm_ptr(&ina4230_pm),
+	},
+	.id_table = ina4230_ids,
+};
+module_i2c_driver(ina4230_i2c_driver);
+
+MODULE_AUTHOR("Alexey Charkov <alchark@flipper.net>");
+MODULE_DESCRIPTION("Texas Instruments INA4230 HWMon Driver");
+MODULE_LICENSE("GPL");

-- 
2.52.0

Re: [PATCH v5 0/2] Add support for Texas Instruments INA4230 power monitor

[Guenter Roeck]

On 3/30/26 08:14, Alexey Charkov wrote:
> TI INA4230 is a 4-channel power monitor with I2C interface, similar in
> operation to INA3221 (3-channel) and INA219 (single-channel) but with
> a different register layout, different alerting mechanism and slightly
> different support for directly reading calculated current/power/energy
> values (pre-multiplied by the device itself and needing only to be scaled
> by the driver depending on its selected LSB unit values).
> 
> In this initial implementation, the driver supports reading voltage,
> current, power and energy values, but does not yet support alerts, which
> can be added separately if needed. Also the overflows during hardware
> calculations are not yet handled, nor is the support for the device's
> internal 32-bit energy counter reset.
> 
> An example device tree using this binding and driver is available at [1]
> (not currently upstreamed, as the device in question is in engineering
> phase and not yet publicly available)
> 
> [1] https://github.com/flipperdevices/flipper-linux-kernel/blob/flipper-devel/arch/arm64/boot/dts/rockchip/rk3576-flipper-one-rev-f0b0c1.dts
> 
> Signed-off-by: Alexey Charkov <alchark@flipper.net>
> ---
> Changes in v5:
> - Reworded per-channel subnodes description in the binding for clarity (Sashiko)
> - NB: Sashiko's suggestion to allow interrupts in the binding sounds premature,
>    as the alerts mechanism is not implemented yet and there are no known users
>    to test it. If anyone has hardware with the alert pins wired to an interrupt
>    line - please shout and we can test/extend it together

The bindings are supposed to be complete, even if not implemented, so I am not sure
if the DT maintainers will agree here. We'll see.

Thanks,
Guenter

Re: [PATCH v5 2/2] hwmon: Add support for TI INA4230 power monitor

[Guenter Roeck]

On 3/30/26 08:14, Alexey Charkov wrote:
> Add a driver for the TI INA4230, a 4-channel power monitor with I2C
> interface.
> 
> The driver supports voltage, current, power and energy measurements, but
> skips the alert functionality in this initial implementation.
> 
> Signed-off-by: Alexey Charkov <alchark@flipper.net>

Sashiko report is at

https://sashiko.dev/#/patchset/20260330-ina4230-v5-0-eeb322d95b3a%40flipper.net

Valid concerns, as far as I can see, are:

- There are various overflow issues. Please address, either by making sure that
   the operations can not overflow, or that all parameters such as the shunt
   resistor value or the interval are bound such that an overflow can not occur.
   This includes implicit conversions. For example, the interval passed to
   ina4230_interval_ms_to_conv_time() is int, but the parameter is actually long.
   There is not even a signed check, meaning the resulting interval can be pretty
   much anything.

- power is reported by the chip as unsigned value. Yet, it is converted via type
   cast to int16_t.

- Please add a comment to the energy reading to confirm that regmap_noinc_read()
   performs as expected.

- The definition of ina4230_curr_reg[] is wasteful. There is only an entry for
   hwmon_curr_input. Why specify an unnecessary two-dimensional array ?

- The dummy channel 0 for voltage is not acceptable. Make it 0-based as expected
   by the ABI. Yes, I know, but that is how the ABI was defined.


I can not comment on Saskiko's pm related feedback. PM is and has always been
a mystery to me, so I just assume that it is WAI and that there are no problems.
I do assume that you have tested the code thoroughly across suspend/resume cycles
to make sure that it works as intended.

Thanks,
Guenter

Re: [PATCH v5 0/2] Add support for Texas Instruments INA4230 power monitor

[Rob Herring]

On Mon, Mar 30, 2026 at 09:07:32AM -0700, Guenter Roeck wrote:
> On 3/30/26 08:14, Alexey Charkov wrote:
> > TI INA4230 is a 4-channel power monitor with I2C interface, similar in
> > operation to INA3221 (3-channel) and INA219 (single-channel) but with
> > a different register layout, different alerting mechanism and slightly
> > different support for directly reading calculated current/power/energy
> > values (pre-multiplied by the device itself and needing only to be scaled
> > by the driver depending on its selected LSB unit values).
> > 
> > In this initial implementation, the driver supports reading voltage,
> > current, power and energy values, but does not yet support alerts, which
> > can be added separately if needed. Also the overflows during hardware
> > calculations are not yet handled, nor is the support for the device's
> > internal 32-bit energy counter reset.
> > 
> > An example device tree using this binding and driver is available at [1]
> > (not currently upstreamed, as the device in question is in engineering
> > phase and not yet publicly available)
> > 
> > [1] https://github.com/flipperdevices/flipper-linux-kernel/blob/flipper-devel/arch/arm64/boot/dts/rockchip/rk3576-flipper-one-rev-f0b0c1.dts
> > 
> > Signed-off-by: Alexey Charkov <alchark@flipper.net>
> > ---
> > Changes in v5:
> > - Reworded per-channel subnodes description in the binding for clarity (Sashiko)
> > - NB: Sashiko's suggestion to allow interrupts in the binding sounds premature,
> >    as the alerts mechanism is not implemented yet and there are no known users
> >    to test it. If anyone has hardware with the alert pins wired to an interrupt
> >    line - please shout and we can test/extend it together
> 
> The bindings are supposed to be complete, even if not implemented, so I am not sure
> if the DT maintainers will agree here. We'll see.

Given ti,alert-polarity-active-high is added seems like the interrupt 
should be too. And the interrupt can specify the polarity, so is that 
property really needed? There's alway the possibility that you have some 
inverter on the board too and the interrupt polarity is not enough, but 
solve that problem when it actually exists.

Rob

Re: [PATCH v5 0/2] Add support for Texas Instruments INA4230 power monitor

[Guenter Roeck]

On 3/31/26 08:52, Rob Herring wrote:
> On Mon, Mar 30, 2026 at 09:07:32AM -0700, Guenter Roeck wrote:
>> On 3/30/26 08:14, Alexey Charkov wrote:
>>> TI INA4230 is a 4-channel power monitor with I2C interface, similar in
>>> operation to INA3221 (3-channel) and INA219 (single-channel) but with
>>> a different register layout, different alerting mechanism and slightly
>>> different support for directly reading calculated current/power/energy
>>> values (pre-multiplied by the device itself and needing only to be scaled
>>> by the driver depending on its selected LSB unit values).
>>>
>>> In this initial implementation, the driver supports reading voltage,
>>> current, power and energy values, but does not yet support alerts, which
>>> can be added separately if needed. Also the overflows during hardware
>>> calculations are not yet handled, nor is the support for the device's
>>> internal 32-bit energy counter reset.
>>>
>>> An example device tree using this binding and driver is available at [1]
>>> (not currently upstreamed, as the device in question is in engineering
>>> phase and not yet publicly available)
>>>
>>> [1] https://github.com/flipperdevices/flipper-linux-kernel/blob/flipper-devel/arch/arm64/boot/dts/rockchip/rk3576-flipper-one-rev-f0b0c1.dts
>>>
>>> Signed-off-by: Alexey Charkov <alchark@flipper.net>
>>> ---
>>> Changes in v5:
>>> - Reworded per-channel subnodes description in the binding for clarity (Sashiko)
>>> - NB: Sashiko's suggestion to allow interrupts in the binding sounds premature,
>>>     as the alerts mechanism is not implemented yet and there are no known users
>>>     to test it. If anyone has hardware with the alert pins wired to an interrupt
>>>     line - please shout and we can test/extend it together
>>
>> The bindings are supposed to be complete, even if not implemented, so I am not sure
>> if the DT maintainers will agree here. We'll see.
> 
> Given ti,alert-polarity-active-high is added seems like the interrupt
> should be too. And the interrupt can specify the polarity, so is that
> property really needed? There's alway the possibility that you have some
> inverter on the board too and the interrupt polarity is not enough, but
> solve that problem when it actually exists.
> 

The alert pin can be attached to a board interrupt, or (more likely) it can
be attached to the I2C controller's alert pin. In the latter case there is
no interrupt property.

Guenter

Re: [PATCH v5 0/2] Add support for Texas Instruments INA4230 power monitor

[Alexey Charkov]

On Tue, Mar 31, 2026 at 8:10 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 3/31/26 08:52, Rob Herring wrote:
> > On Mon, Mar 30, 2026 at 09:07:32AM -0700, Guenter Roeck wrote:
> >> On 3/30/26 08:14, Alexey Charkov wrote:
> >>> TI INA4230 is a 4-channel power monitor with I2C interface, similar in
> >>> operation to INA3221 (3-channel) and INA219 (single-channel) but with
> >>> a different register layout, different alerting mechanism and slightly
> >>> different support for directly reading calculated current/power/energy
> >>> values (pre-multiplied by the device itself and needing only to be scaled
> >>> by the driver depending on its selected LSB unit values).
> >>>
> >>> In this initial implementation, the driver supports reading voltage,
> >>> current, power and energy values, but does not yet support alerts, which
> >>> can be added separately if needed. Also the overflows during hardware
> >>> calculations are not yet handled, nor is the support for the device's
> >>> internal 32-bit energy counter reset.
> >>>
> >>> An example device tree using this binding and driver is available at [1]
> >>> (not currently upstreamed, as the device in question is in engineering
> >>> phase and not yet publicly available)
> >>>
> >>> [1] https://github.com/flipperdevices/flipper-linux-kernel/blob/flipper-devel/arch/arm64/boot/dts/rockchip/rk3576-flipper-one-rev-f0b0c1.dts
> >>>
> >>> Signed-off-by: Alexey Charkov <alchark@flipper.net>
> >>> ---
> >>> Changes in v5:
> >>> - Reworded per-channel subnodes description in the binding for clarity (Sashiko)
> >>> - NB: Sashiko's suggestion to allow interrupts in the binding sounds premature,
> >>>     as the alerts mechanism is not implemented yet and there are no known users
> >>>     to test it. If anyone has hardware with the alert pins wired to an interrupt
> >>>     line - please shout and we can test/extend it together
> >>
> >> The bindings are supposed to be complete, even if not implemented, so I am not sure
> >> if the DT maintainers will agree here. We'll see.
> >
> > Given ti,alert-polarity-active-high is added seems like the interrupt
> > should be too. And the interrupt can specify the polarity, so is that
> > property really needed? There's alway the possibility that you have some
> > inverter on the board too and the interrupt polarity is not enough, but
> > solve that problem when it actually exists.
> >
>
> The alert pin can be attached to a board interrupt, or (more likely) it can
> be attached to the I2C controller's alert pin. In the latter case there is
> no interrupt property.

Alright, I will add the interrupt property and keep the dedicated flag
for alert polarity.

Following the logic of binding completeness, should I add a flag for
the single-shot mode too, even though I dropped that functionality
from the driver in one of the prior iterations?

Thanks a lot,
Alexey

Re: [PATCH v5 0/2] Add support for Texas Instruments INA4230 power monitor

[Rob Herring]

On Tue, Mar 31, 2026 at 11:46 AM Alexey Charkov <alchark@flipper.net> wrote:
>
> On Tue, Mar 31, 2026 at 8:10 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > On 3/31/26 08:52, Rob Herring wrote:
> > > On Mon, Mar 30, 2026 at 09:07:32AM -0700, Guenter Roeck wrote:
> > >> On 3/30/26 08:14, Alexey Charkov wrote:
> > >>> TI INA4230 is a 4-channel power monitor with I2C interface, similar in
> > >>> operation to INA3221 (3-channel) and INA219 (single-channel) but with
> > >>> a different register layout, different alerting mechanism and slightly
> > >>> different support for directly reading calculated current/power/energy
> > >>> values (pre-multiplied by the device itself and needing only to be scaled
> > >>> by the driver depending on its selected LSB unit values).
> > >>>
> > >>> In this initial implementation, the driver supports reading voltage,
> > >>> current, power and energy values, but does not yet support alerts, which
> > >>> can be added separately if needed. Also the overflows during hardware
> > >>> calculations are not yet handled, nor is the support for the device's
> > >>> internal 32-bit energy counter reset.
> > >>>
> > >>> An example device tree using this binding and driver is available at [1]
> > >>> (not currently upstreamed, as the device in question is in engineering
> > >>> phase and not yet publicly available)
> > >>>
> > >>> [1] https://github.com/flipperdevices/flipper-linux-kernel/blob/flipper-devel/arch/arm64/boot/dts/rockchip/rk3576-flipper-one-rev-f0b0c1.dts
> > >>>
> > >>> Signed-off-by: Alexey Charkov <alchark@flipper.net>
> > >>> ---
> > >>> Changes in v5:
> > >>> - Reworded per-channel subnodes description in the binding for clarity (Sashiko)
> > >>> - NB: Sashiko's suggestion to allow interrupts in the binding sounds premature,
> > >>>     as the alerts mechanism is not implemented yet and there are no known users
> > >>>     to test it. If anyone has hardware with the alert pins wired to an interrupt
> > >>>     line - please shout and we can test/extend it together
> > >>
> > >> The bindings are supposed to be complete, even if not implemented, so I am not sure
> > >> if the DT maintainers will agree here. We'll see.
> > >
> > > Given ti,alert-polarity-active-high is added seems like the interrupt
> > > should be too. And the interrupt can specify the polarity, so is that
> > > property really needed? There's alway the possibility that you have some
> > > inverter on the board too and the interrupt polarity is not enough, but
> > > solve that problem when it actually exists.
> > >
> >
> > The alert pin can be attached to a board interrupt, or (more likely) it can
> > be attached to the I2C controller's alert pin. In the latter case there is
> > no interrupt property.
>
> Alright, I will add the interrupt property and keep the dedicated flag
> for alert polarity.
>
> Following the logic of binding completeness, should I add a flag for
> the single-shot mode too, even though I dropped that functionality
> from the driver in one of the prior iterations?

I don't remember what that was exactly, but that sounds like a user
selection which would be some sysfs or other runtime control rather
than in DT. Unless the h/w design dictates what mode should be used.

Rob

Re: [PATCH v5 0/2] Add support for Texas Instruments INA4230 power monitor

[Guenter Roeck]

On 4/1/26 07:03, Rob Herring wrote:
> On Tue, Mar 31, 2026 at 11:46 AM Alexey Charkov <alchark@flipper.net> wrote:
>>
>> On Tue, Mar 31, 2026 at 8:10 PM Guenter Roeck <linux@roeck-us.net> wrote:
>>>
>>> On 3/31/26 08:52, Rob Herring wrote:
>>>> On Mon, Mar 30, 2026 at 09:07:32AM -0700, Guenter Roeck wrote:
>>>>> On 3/30/26 08:14, Alexey Charkov wrote:
>>>>>> TI INA4230 is a 4-channel power monitor with I2C interface, similar in
>>>>>> operation to INA3221 (3-channel) and INA219 (single-channel) but with
>>>>>> a different register layout, different alerting mechanism and slightly
>>>>>> different support for directly reading calculated current/power/energy
>>>>>> values (pre-multiplied by the device itself and needing only to be scaled
>>>>>> by the driver depending on its selected LSB unit values).
>>>>>>
>>>>>> In this initial implementation, the driver supports reading voltage,
>>>>>> current, power and energy values, but does not yet support alerts, which
>>>>>> can be added separately if needed. Also the overflows during hardware
>>>>>> calculations are not yet handled, nor is the support for the device's
>>>>>> internal 32-bit energy counter reset.
>>>>>>
>>>>>> An example device tree using this binding and driver is available at [1]
>>>>>> (not currently upstreamed, as the device in question is in engineering
>>>>>> phase and not yet publicly available)
>>>>>>
>>>>>> [1] https://github.com/flipperdevices/flipper-linux-kernel/blob/flipper-devel/arch/arm64/boot/dts/rockchip/rk3576-flipper-one-rev-f0b0c1.dts
>>>>>>
>>>>>> Signed-off-by: Alexey Charkov <alchark@flipper.net>
>>>>>> ---
>>>>>> Changes in v5:
>>>>>> - Reworded per-channel subnodes description in the binding for clarity (Sashiko)
>>>>>> - NB: Sashiko's suggestion to allow interrupts in the binding sounds premature,
>>>>>>      as the alerts mechanism is not implemented yet and there are no known users
>>>>>>      to test it. If anyone has hardware with the alert pins wired to an interrupt
>>>>>>      line - please shout and we can test/extend it together
>>>>>
>>>>> The bindings are supposed to be complete, even if not implemented, so I am not sure
>>>>> if the DT maintainers will agree here. We'll see.
>>>>
>>>> Given ti,alert-polarity-active-high is added seems like the interrupt
>>>> should be too. And the interrupt can specify the polarity, so is that
>>>> property really needed? There's alway the possibility that you have some
>>>> inverter on the board too and the interrupt polarity is not enough, but
>>>> solve that problem when it actually exists.
>>>>
>>>
>>> The alert pin can be attached to a board interrupt, or (more likely) it can
>>> be attached to the I2C controller's alert pin. In the latter case there is
>>> no interrupt property.
>>
>> Alright, I will add the interrupt property and keep the dedicated flag
>> for alert polarity.
>>
>> Following the logic of binding completeness, should I add a flag for
>> the single-shot mode too, even though I dropped that functionality
>> from the driver in one of the prior iterations?
> 
> I don't remember what that was exactly, but that sounds like a user
> selection which would be some sysfs or other runtime control rather
> than in DT. Unless the h/w design dictates what mode should be used.
> 

I agree. I can not imagine that to be a hardware design constraint.

Thanks,
Guenter