Re: [PATCH v2 2/4] ASoC: codecs: Add TAS675x quad-channel audio amplifier driver

Krzysztof Kozlowski
2026-04-02T07:54:38Z

On Wed, Apr 01, 2026 at 05:28:43PM -0500, Sen Wang wrote:
> +
> +static const struct dev_pm_ops tas675x_pm_ops = {
> + SYSTEM_SLEEP_PM_OPS(tas675x_system_suspend, tas675x_system_resume)
> + RUNTIME_PM_OPS(tas675x_runtime_suspend, tas675x_runtime_resume, NULL)
> +};
> +
> +static const struct of_device_id tas675x_of_match[] = {
> + { .compatible = "ti,tas6754", .data = (void *)TAS6754 },
> + { .compatible = "ti,tas67524", .data = (void *)TAS6754 },

I did not look detailed, but this ^^^

> + { }
> +};
> +MODULE_DEVICE_TABLE(of, tas675x_of_match);
> +
> +static const struct i2c_device_id tas675x_i2c_id[] = {
> + { "tas6754", TAS6754 },
> + { "tas67524", TAS6754 },

... and this ^^^ clearly states devices are compatible, unlike your
binding is stating

> + { }

Best regards,
Krzysztof