Re: [PATCH v1 17/22] dt-bindings: clock: Add StarFive JHB100 Peripheral-2 clock and reset generator

Changhuang Liang
2026-04-07T01:37:46Z

Hi, Krzysztof

Thanks for the review.

> On Thu, Apr 02, 2026 at 03:55:18AM -0700, Changhuang Liang wrote:
> > + clocks:
> > + items:
> > + - description: Peripheral-2 600MHz
> > + - description: Peripheral-2 400MHz
> > + - description: Peripheral-2 125MHz
> > + - description: Peripheral-2 GMAC2 RGMII RX
> > + - description: Peripheral-2 GMAC2 RMII Reference
> > + - description: Peripheral-2 GMAC3 SGMII TX
> > + - description: Peripheral-2 GMAC3 SGMII RX
> > + - description: Main Oscillator (25 MHz)
> > +
> > + clock-names:
> > + items:
> > + - const: per2_600
>
> Does not have any meaningful name in datasheet / clock hierarchy?

Yes, some clocks are named directly by frequency.

I will try to find if there are other meaningful naming options.

Best Regards,
Changhuang