Re: [PATCH v1 17/22] dt-bindings: clock: Add StarFive JHB100 Peripheral-2 clock and reset generator

Krzysztof Kozlowski
2026-04-04T11:34:50Z

On Thu, Apr 02, 2026 at 03:55:18AM -0700, Changhuang Liang wrote:
> + clocks:
> + items:
> + - description: Peripheral-2 600MHz
> + - description: Peripheral-2 400MHz
> + - description: Peripheral-2 125MHz
> + - description: Peripheral-2 GMAC2 RGMII RX
> + - description: Peripheral-2 GMAC2 RMII Reference
> + - description: Peripheral-2 GMAC3 SGMII TX
> + - description: Peripheral-2 GMAC3 SGMII RX
> + - description: Main Oscillator (25 MHz)
> +
> + clock-names:
> + items:
> + - const: per2_600

Does not have any meaningful name in datasheet / clock hierarchy?

> + - const: per2_400
> + - const: per2_125
> + - const: per2_gmac2_rgmii_rx
> + - const: per2_gmac2_rmii_ref
> + - const: per2_gmac3_sgmii_tx
> + - const: per2_gmac3_sgmii_rx

per2 is redundant. Name these according to clock input names.

Same for your patch for per3.

> + - const: osc
> +
> +

Just one blank line

Best regards,
Krzysztof