Re: [PATCH 0/3] Move adis16203 inclinometer driver out of staging

David Lechner
2026-04-04T16:29:32Z

On 4/1/26 11:24 AM, Sheng Kun Chang wrote:
> This series moves the ADIS16203 Programmable 360 Degrees Inclinometer
> driver out of staging and into drivers/iio/accel/.
>
> The driver already uses standard IIO channel interfaces and devm
> managed APIs. The only missing piece was devicetree binding
> documentation, which is added in patch 1.
>
> Patch 1: Add devicetree binding documentation
> Patch 2: Fix MODULE_LICENSE to match SPDX identifier
> Patch 3: Move the driver from staging to drivers/iio/accel/
>
> Sheng Kun Chang (3):
> dt-bindings: iio: accel: add binding for adi,adis16203
> staging: iio: adis16203: align MODULE_LICENSE with SPDX identifier
> iio: accel: move adis16203 out of staging
>
> .../bindings/iio/accel/adi,adis16203.yaml | 52 +++++++++++++++++++
> drivers/iio/accel/Kconfig | 12 +++++
> drivers/iio/accel/Makefile | 1 +
> drivers/{staging => }/iio/accel/adis16203.c | 2 +-
> drivers/staging/iio/Kconfig | 1 -
> drivers/staging/iio/Makefile | 1 -
> drivers/staging/iio/accel/Kconfig | 19 -------
> drivers/staging/iio/accel/Makefile | 6 ---
> 8 files changed, 66 insertions(+), 28 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adis16203.yaml
> rename drivers/{staging => }/iio/accel/adis16203.c (99%)
> delete mode 100644 drivers/staging/iio/accel/Kconfig
> delete mode 100644 drivers/staging/iio/accel/Makefile
>

Quite a few people have attempted this already [1]. It is likely not as simple
as renaming the file. Please review and give a summary of all of the previous
attempts so that all of us reviewers don't have to go read all of those messages.

[1]: https://lore.kernel.org/linux-iio/?q=adis16203

And when reading those messages, you should find that the rename patch needs
to have the full diff (I think this is the --no-renames option to git
format-patch). This way we can review the driver in it's current state one
more time to make sure we didn't miss any cleanups that are needed first.