From: Krzysztof Kozlowski <krzk@kernel.org>
To: dongxuyang@eswincomputing.com
Cc: ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, ben-linux@fluff.org,
ben.dooks@codethink.co.uk, p.zabel@pengutronix.de,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, ningyu@eswincomputing.com,
linmin@eswincomputing.com, xuxiang@eswincomputing.com,
wangguosheng@eswincomputing.com, pinkesh.vaghela@einfochips.com
Subject: Re: [PATCH v3 1/2] dt-bindings: pwm: dwc: add reset optional
Date: Fri, 3 Apr 2026 09:27:36 +0200 [thread overview]
Message-ID: <20260403-glossy-industrious-pug-4f2b2c@quoll> (raw)
In-Reply-To: <20260402091854.1666-1-dongxuyang@eswincomputing.com>
On Thu, Apr 02, 2026 at 05:18:54PM +0800, dongxuyang@eswincomputing.com wrote:
> From: Xuyang Dong <dongxuyang@eswincomputing.com>
>
> The DesignWare PWM controller provides separate reset signals for each
So one controller has signals. Plural, right? Then why do you define
only one reset signal?
> clock domain, as specified in the hardware documentation. Without
> asserting and deasserting these resets during probe, PWM outputs may
> remain in an undefined state after system reboot.
>
> To address this, the driver now supports an optional 'resets' property.
This is binding change, not driver.
> A full reset is performed only when no PWM channel is enabled, as
> determined by reading the enable bit in each channel's control register.
Do you describe hardware or driver behavior? This is not a change about
driver. Describe the hardware here - what is expected with that reset.
> This allows safe coexistence with bootloaders that have already
> configured active PWM channels.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-03 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 9:17 [PATCH v3 0/2] Update designware pwm driver dongxuyang
2026-04-02 9:18 ` [PATCH v3 1/2] dt-bindings: pwm: dwc: add reset optional dongxuyang
2026-04-03 7:27 ` Krzysztof Kozlowski [this message]
2026-04-02 9:19 ` [PATCH v3 2/2] pwm: dwc: add of/platform support dongxuyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260403-glossy-industrious-pug-4f2b2c@quoll \
--to=krzk@kernel.org \
--cc=ben-linux@fluff.org \
--cc=ben.dooks@codethink.co.uk \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongxuyang@eswincomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pinkesh.vaghela@einfochips.com \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
--cc=wangguosheng@eswincomputing.com \
--cc=xuxiang@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox