From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DED8D258ED5; Fri, 3 Apr 2026 08:49:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775206190; cv=none; b=Ez5HLDxapJhyzHMRCRNgzm6SH3x+zkfWq8yQLCvIt5uGAjkM7IwQHRtfnSNk4VGuTYMskg80OxTTKkL9IovQMsTWPwKTr6YwOl5gD+mUXJgXCrD7ufvo0AF6JPNzCQvOAbYliA63NIWZQ3y6G/gXghb/y04MG91pPb8g0lSG6nk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775206190; c=relaxed/simple; bh=9jC53zh6UygCTEqGephW3awhcb1IaIKFF0682qBsSTQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I/VwPbUNyaNiGh5QlaLTn/goX4HwPkLX2kHXe9nIyXutmh4qLR6vvvrZZdo3/uCc4BMA0cSh92x5CuLzTFeSf3+eZILPkmJl9vNCJ1JNxt/YjHxMAjQ4U44ECYqyBZWsr5aT7/bI3NtwnlxfbsqocwCBBd9HbxPu58mpWcJAiWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pK7lNUzq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pK7lNUzq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5999DC4CEF7; Fri, 3 Apr 2026 08:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775206190; bh=9jC53zh6UygCTEqGephW3awhcb1IaIKFF0682qBsSTQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pK7lNUzqto0zd4bKtvihnOeaXM2GmhmDe3RQ9NsD3S+6JOEVn3XqQzyisxF+rwn7O 3tJ5YOgIQTRuqSA3ThkLRBUY36A5/SLgPmXZyJ8nIPRedD1kO9Spg31jz0cug9gHxB 8szf9AwloyMQe+tDmDeQb/sCiqbRqcrPHdeVJSFluv1O8+omalALtJAGG1MCXb1MX7 T5H5MJszpvfELqlLR+3skkpXpwkckYhDwWSbPMTm3ZeT3fDgqG2+Un4sbk5+9NNI9Z e1u6o0RZ2urNI8DCTI8d1Zn9Npqrwt311cMZ9EQ1xuzSG0967ezeFgG2k2VETflATn uvve4i00IVO3Q== Date: Fri, 3 Apr 2026 09:49:42 +0100 From: Conor Dooley To: Changhuang Liang Cc: Emil Renner Berthing , Joel Stanley , Drew Fustini , Darshan Prajapati , "linux-riscv@lists.infradead.org" , Rob Herring , Alexandre Ghiti , Anup Patel , Hal Feng , Guodong Xu , Yixun Lan , Heinrich Schuchardt , "devicetree@vger.kernel.org" , Conor Dooley , Albert Ou , E Shattow , Leyfoon Tan , Junhui Liu , Daniel Lezcano , Michal Simek , Paul Walmsley , "linux-kernel@vger.kernel.org" , Samuel Holland , Michael Zhu , Palmer Dabbelt , Thomas Gleixner , JiSheng Teoh , Krzysztof Kozlowski Subject: Re: [PATCH v1 5/5] riscv: dts: starfive: jhb100: Add JHB100 base DT Message-ID: <20260403-pristine-slam-71d8e0093b6f@spud> References: <20260402084019.440708-1-changhuang.liang@starfivetech.com> <20260402084019.440708-6-changhuang.liang@starfivetech.com> <20260402-shakable-hefty-0164a042b748@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RDIrdRSDWwJQ2NvY" Content-Disposition: inline In-Reply-To: --RDIrdRSDWwJQ2NvY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 03, 2026 at 03:06:23AM +0000, Changhuang Liang wrote: > Hi, Conor >=20 > > On Thu, Apr 02, 2026 at 01:40:19AM -0700, Changhuang Liang wrote: > > > From: Ley Foon Tan > > > > > > Add JHB100 base dtsi and dts. Consist of 4 Dubhe-70 cores, CLINT, > > > PLIC, PMU, UART and 1GB DDR. > > > > > > Signed-off-by: Ley Foon Tan > > > Signed-off-by: Changhuang Liang > > > --- > > > MAINTAINERS | 6 + > > > arch/riscv/boot/dts/starfive/Makefile | 2 + > > > .../boot/dts/starfive/jhb100-evb1-eth.dts | 6 + > > > arch/riscv/boot/dts/starfive/jhb100-evb1.dtsi | 32 ++ > > > arch/riscv/boot/dts/starfive/jhb100.dtsi | 326 > > ++++++++++++++++++ > > > 5 files changed, 372 insertions(+) > > > create mode 100644 arch/riscv/boot/dts/starfive/jhb100-evb1-eth.dts > > > create mode 100644 arch/riscv/boot/dts/starfive/jhb100-evb1.dtsi > > > create mode 100644 arch/riscv/boot/dts/starfive/jhb100.dtsi > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS index > > > 7d10988cbc62..b1892a480c31 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -25306,6 +25306,12 @@ S: Supported > > > F: > > Documentation/devicetree/bindings/interrupt-controller/starfive,jh8100 > > -intc.yaml > > > F: drivers/irqchip/irq-starfive-jh8100-intc.c > > > > > > +STARFIVE JHB100 DEVICETREES > > > +M: Changhuang Liang > > > +L: linux-riscv@lists.infradead.org > > > +S: Maintained > >=20 > > Supported, no? > >=20 > > > +F: arch/riscv/boot/dts/starfive/jhb100* > > > + > > > STATIC BRANCH/CALL > > > M: Peter Zijlstra > > > M: Josh Poimboeuf > > > diff --git a/arch/riscv/boot/dts/starfive/Makefile > > > b/arch/riscv/boot/dts/starfive/Makefile > > > index 3dd1f05283f7..7cdb75788053 100644 > > > --- a/arch/riscv/boot/dts/starfive/Makefile > > > +++ b/arch/riscv/boot/dts/starfive/Makefile > > > @@ -18,3 +18,5 @@ dtb-$(CONFIG_ARCH_STARFIVE) +=3D > > > jh7110-starfive-visionfive-2-lite.dtb > > > dtb-$(CONFIG_ARCH_STARFIVE) +=3D > > > jh7110-starfive-visionfive-2-lite-emmc.dtb > > > dtb-$(CONFIG_ARCH_STARFIVE) +=3D jh7110-starfive-visionfive-2-v1.2a.= dtb > > > dtb-$(CONFIG_ARCH_STARFIVE) +=3D jh7110-starfive-visionfive-2-v1.3b.= dtb > > > + > > > +dtb-$(CONFIG_ARCH_STARFIVE) +=3D jhb100-evb1-eth.dtb > > > diff --git a/arch/riscv/boot/dts/starfive/jhb100-evb1-eth.dts > > > b/arch/riscv/boot/dts/starfive/jhb100-evb1-eth.dts > > > new file mode 100644 > > > index 000000000000..62cd046e1224 > > > --- /dev/null > > > +++ b/arch/riscv/boot/dts/starfive/jhb100-evb1-eth.dts > > > @@ -0,0 +1,6 @@ > > > +// SPDX-License-Identifier: GPL-2.0 OR MIT > > > +/* > > > + * Copyright (c) 2024-2026 StarFive Technology Co., Ltd. > > > + */ > > > + > > > +#include "jhb100-evb1.dtsi" > >=20 > > What is the point of this file? Is this the base-board? > > Shouldn't it have a specific compatible? > >=20 > > Can the SoM be used without a base board? I've got no info about this b= oard > > appearing on google, do you even have pictures of it or any documentati= on? > > I see this > > https://www.starfivetech.com/en/index.php?s=3Dhardware&c=3Dshow&id=3D22 > > and > > https://www.starfivetech.com/en/index.php?s=3Dhardware&c=3Dshow&id=3D23 > > but the former doesn't look like it needs a base-board and the latter i= s called > > "evb3", so is not what's here? >=20 > The former is the base board of the EVB1. Currently, we are only carrying= out=20 > upstream work based on the EVB1. The EVB1 base board has reserved slots= =20 Except when I look at the first link, the picture doesn't show something that is a SoM + base-board, it's just a regular board. If that's the case, the breakdown of files doesn't make sense, with jhb100-evb1.dtsi sounding like it should be a dts. Usually we talk about base-boards in relation to a SoM, like what the mars-cm needs to function. > that can accommodate expansion boards to verify more advanced features.= =20 > At present, the jhb100-evb1.dtsi file corresponds to the configuration of= the=20 > EVB1 base board. In the future, we will add dtsi files for the expansion = boards.=20 > The jhb100-evb1-eth.dts file will then be used to combine these dtsi file= s to=20 > generate the final version of the device tree source. Sounds like here the evb1 is a complete board and jhb100-evb1-eth.dts represents some kind of expansion card added to that board?=20 I think this not correct, since the base-board needs to be usable in isolation. Take a look at what rockchip do for rk3588-rock-5b-pcie-ep in arch/arm64/boot/dts/rockchip/Makefile/, where these expansion type things are dealt with using overlays. --RDIrdRSDWwJQ2NvY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCac9/JgAKCRB4tDGHoIJi 0ktcAP9BpkEyrR1n1Wov0YpiTqgbSKS7e8erqIhAJyOOje5XHQD/djuBtwwMJ45C xt1SwYjgxAkvlzj3RWeF0wCI9Z22bgc= =kSV4 -----END PGP SIGNATURE----- --RDIrdRSDWwJQ2NvY--