Re: [PATCH 1/2] dt-bindings: iio: dac: add support for Microchip MCP48FEB02 to MCP47FEB02

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3020 bytes --]

On Fri, Apr 03, 2026 at 01:50:13PM +0300, Ariana Lazar wrote:
> This is the device tree schema for iio driver for Microchip
> MCP48FxBy1/2/4/8 series of buffered voltage output Digital-to-Analog
> Converters with nonvolatile or volatile memory on top of MCP47FEB02.
> The families support up to 8 output channels and have 8-bit, 10-bit or
> 12-bit resolution.
> 
> The I2C (MCP47F(E/V)BXX) and SPI (MCP48F(E/V)BXX) DAC families were merged
> into the same dt-binding file.
> 
> Fixes: 4ba12d304175 ("dt-bindings: iio: dac: adding support for Microchip MCP47FEB02")
> Signed-off-by: Ariana Lazar <ariana.lazar@microchip.com>
> Link: https://lore.kernel.org/all/20260216-shiny-itunes-00a31d1f4db7@spud/

The fixes tag here is not appropriate, you didn't do anything wrong
originally*, this just adds new devices.

*other than the channel number thing, but that should be handled in
isolation I think, if my read on the rationale for your change is
correct.

> ---
>  .../bindings/iio/dac/microchip,mcp47feb02.yaml     | 291 +++++++++++++++------
>  MAINTAINERS                                        |   1 -
>  2 files changed, 217 insertions(+), 75 deletions(-)

>    reg:
>      maxItems: 1
>  
> +  spi-max-frequency:
> +    maximum: 10000000
> +
>    "#address-cells":
>      const: 1
>  
> @@ -111,7 +172,7 @@ properties:
>          - for single-channel device: Vout0;
>          - for dual-channel device: Vout0, Vout1;
>          - for quad-channel device: Vout0, Vout2;
> -        - for octal-channel device: Vout0, Vout2, Vout6, Vout8;
> +        - for octal-channel device: Vout0, Vout2, Vout4, Vout6;
>  
>    vref1-supply:
>      description: |
> @@ -141,7 +202,7 @@ properties:
>      description:
>        Enable buffering of the external Vref/Vref0 pin in cases where the
>        external reference voltage does not have sufficient current capability in
> -      order not to drop it’s voltage when connected to the internal resistor
> +      order not to drop its voltage when connected to the internal resistor
>        ladder circuit.
>  
>    microchip,vref1-buffered:
> @@ -149,7 +210,7 @@ properties:
>      description:
>        Enable buffering of the external Vref1 pin in cases where the external
>        reference voltage does not have sufficient current capability in order not
> -      to drop it’s voltage when connected to the internal resistor ladder
> +      to drop its voltage when connected to the internal resistor ladder
>        circuit.
>  
>  patternProperties:
> @@ -161,8 +222,7 @@ patternProperties:
>      properties:
>        reg:
>          description: The channel number.
> -        minItems: 1
> -        maxItems: 8
> +        maxItems: 1

Why is this changing? Was it originally a mistake and what you wanted
was a max of 8 but only one entry?

>  
>        label:
>          description: Unique name to identify which channel this is.
> @@ -178,6 +238,13 @@ required:
>    - vdd-supply

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]