From: Yixun Lan <dlan@kernel.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: alex@ghiti.fr, aou@eecs.berkeley.edu, conor+dt@kernel.org,
devicetree@vger.kernel.org, krzk+dt@kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
palmer@dabbelt.com, pjw@kernel.org, robh@kernel.org,
spacemit@lists.linux.dev
Subject: Re: [PATCH v2 3/3] riscv: dts: spacemit: enable USB3 on OrangePi RV2
Date: Fri, 3 Apr 2026 08:16:44 +0800 [thread overview]
Message-ID: <20260403001644-GKC1016296@kernel.org> (raw)
In-Reply-To: <20260402130608.133154-1-amadeus@jmu.edu.cn>
Hi Chukun,
On 21:06 Thu 02 Apr , Chukun Pan wrote:
> Hi,
>
> > Can you work with Han for adding USB support[1]? this will simply
> > distribute our effort, and make the review process even harder
>
> Sorry, I didn't consider this.
> Could you drop this patch ([PATCH v2 3/3]...)?
> The first two patches should not cause conflicts.
>
> > > + vbus-supply = <&vcc5v0_usb30>;
> > IMO, the vbus doesn't directly tie to dwc3 host, but to HUB's port
> > so I think this is still wrong, although it may work on the board..
>
> We can switch to the onboard_usb_dev driver after it's merged.
Sure, I think that's a more elegant solution
> Keeping vbus always-on may cause unnecessary waste.
> I won't insist if you think this is wrong.
Currently either way isn't ideal.. but binding vbus to the host is kind
of acceptable to me, if no ojection, I can take this, then we can adjust
later once the USB HUB vbus support[1] landing in tree
https://lore.kernel.org/all/20260223-v6-16-topic-usb-onboard-dev-v5-0-28d3018a8026@pengutronix.de/ [1]
btw, Could you take a look at Han's patch? if you have final say?
https://lore.kernel.org/spacemit/20260403000539-GKB1016296@kernel.org/ [2]
I'd like to push this series to v7.1, it's almost running out of time..
>
> Thanks,
> Chukun
--
Yixun Lan (dlan)
prev parent reply other threads:[~2026-04-03 0:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 10:00 [PATCH v2 0/3] riscv: dts: spacemit: enable USB3 on OrangePi Chukun Pan
2026-04-02 10:00 ` [PATCH v2 1/3] riscv: dts: spacemit: add fixed regulators for OrangePi Chukun Pan
2026-04-02 10:00 ` [PATCH v2 2/3] riscv: dts: spacemit: enable USB3 on OrangePi R2S Chukun Pan
2026-04-02 14:24 ` Michael Opdenacker
2026-04-03 7:00 ` Chukun Pan
2026-04-02 10:00 ` [PATCH v2 3/3] riscv: dts: spacemit: enable USB3 on OrangePi RV2 Chukun Pan
2026-04-02 12:20 ` Yixun Lan
2026-04-02 13:06 ` Chukun Pan
2026-04-03 0:16 ` Yixun Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260403001644-GKC1016296@kernel.org \
--to=dlan@kernel.org \
--cc=alex@ghiti.fr \
--cc=amadeus@jmu.edu.cn \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox