public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: bod@kernel.org, vladimir.zapolskiy@linaro.org,
	kieran.bingham@ideasonboard.com, robh@kernel.org,
	krzk+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	johannes.goede@oss.qualcomm.com, mchehab@kernel.org
Subject: Re: [RFC PATCH 0/3] media: qcom: camss: CAMSS Offline Processing Engine support
Date: Sun, 5 Apr 2026 22:57:44 +0300	[thread overview]
Message-ID: <20260405195744.GA1213462@killaraus.ideasonboard.com> (raw)
In-Reply-To: <20260323125824.211615-1-loic.poulain@oss.qualcomm.com>

Hi Loic,

I'm really happy to see this on the list :-)

On Mon, Mar 23, 2026 at 01:58:21PM +0100, Loic Poulain wrote:
> This RFC series introduces initial support for the Qualcomm CAMSS
> Offline Processing Engine (OPE), as found on Agatti-based platforms.
> Boards such as Arduino UNO-Q use this SoC family and will benefit
> from hardware-assisted image processing enabled by this work.
> 
> This represents the first step toward enabling image processing beyond
> raw capture on Qualcomm platforms by using hardware blocks for
> operations such as debayering, 3A, and scaling.

I assume you mean colour gains instead of 3A, based on what I can see in
the driver. I'm looking forward to hardware support for the rest of the
3A :-)

> The OPE sits outside the live capture pipeline. It operates on frames
> fetched from system memory and writes processed results back to memory.
> Because of this design, the OPE is not tied to any specific capture
> interface: frames may come from CAMSS RDI or PIX paths, or from any
> other producer capable of providing memory-backed buffers.
> 
> The hardware can sustain up to 580 megapixels per second, which is
> sufficient to process a 10MPix stream at 60 fps or to handle four
> parallel 2MPix (HD) streams at 60 fps.

Isn't 10 MPix/frame * 60 fps = 600 MPix/s, higher than 580 MPix/s ?

> The initial driver implementation relies on the V4L2 m2m framework
> to keep the design simple while already enabling practical offline
> processing workflows. This model also provides time-sharing across
> multiple contexts through its built-in scheduling.

I understand this decision, but that will need to change. In order to
enable support for more ISP processing blocks, we will need to introduce
parameter buffers. The rkisp1 and mali-c55 drivers are two examples of
how it can be done. If you need any help, please don't hesitate to reach
out.

> This first version is intentionally minimalistic. It provides a working
> configuration using a fixed set of static processing parameters, mainly
> to achieve correct and good-quality debayering.
> 
> Support for more advanced use-cases (dynamic parameters, statistics
> outputs, additional data endpoints) will require evolving the driver
> model beyond a pure m2m design. This may involve either moving away
> from m2m, as other ISP drivers do, or extending it to support auxiliary
> endpoints for parameters and statistics.

Ah, I should have read this before writing the above :-) Let's align the
userspace API of driver with the other ISP drivers.

> This series includes:
>   - dt-binding schema for CAMSS OPE
>   - initial CAMSS OPE driver
>   - QCM2290 device tree node describing the hardware block.
> 
> Feedback on the architecture and expected uAPI direction is especially
> welcome.
> 
> Loic Poulain (3):
>   dt-bindings: media: qcom: Add CAMSS Offline Processing Engine (OPE)
>   media: qcom: camss: Add CAMSS Offline Processing Engine driver
>   arm64: dts: qcom: qcm2290: Add CAMSS OPE node
> 
>  .../bindings/media/qcom,camss-ope.yaml        |   87 +
>  arch/arm64/boot/dts/qcom/agatti.dtsi          |   72 +
>  drivers/media/platform/qcom/camss/Makefile    |    4 +
>  drivers/media/platform/qcom/camss/camss-ope.c | 2058 +++++++++++++++++
>  4 files changed, 2221 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/qcom,camss-ope.yaml
>  create mode 100644 drivers/media/platform/qcom/camss/camss-ope.c

-- 
Regards,

Laurent Pinchart

      parent reply	other threads:[~2026-04-05 19:57 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <xy6TKmdveRx4cMshSHEUGZ7s3lbsurWcsc2vq05A7_N4bCialR7EelZitouugtZDkpFCAghjqY4NDdSQEIPprw==@protonmail.internalid>
2026-03-23 12:58 ` [RFC PATCH 0/3] media: qcom: camss: CAMSS Offline Processing Engine support Loic Poulain
2026-03-23 12:58   ` [RFC PATCH 1/3] dt-bindings: media: qcom: Add CAMSS Offline Processing Engine (OPE) Loic Poulain
2026-03-23 13:03     ` Krzysztof Kozlowski
2026-03-23 16:03       ` Loic Poulain
2026-03-23 16:10         ` Krzysztof Kozlowski
2026-03-23 13:03     ` Bryan O'Donoghue
2026-03-23 12:58   ` [RFC PATCH 2/3] media: qcom: camss: Add CAMSS Offline Processing Engine driver Loic Poulain
2026-03-23 13:43     ` Bryan O'Donoghue
2026-03-23 15:31       ` Loic Poulain
2026-03-24 11:00         ` Bryan O'Donoghue
2026-03-24 15:57           ` Loic Poulain
2026-03-24 21:27           ` Dmitry Baryshkov
2026-03-26 12:06             ` johannes.goede
2026-03-30 11:37               ` Dmitry Baryshkov
2026-03-30 13:46                 ` johannes.goede
2026-03-30 14:11                   ` Bryan O'Donoghue
2026-03-30 14:27                     ` johannes.goede
2026-03-30 14:32                       ` Bryan O'Donoghue
2026-03-30 18:59                         ` Dmitry Baryshkov
2026-03-30 19:07                         ` Loic Poulain
2026-04-05 20:23                           ` Laurent Pinchart
2026-03-30 18:55                     ` Dmitry Baryshkov
2026-03-30 22:51                       ` Bryan O'Donoghue
2026-03-31  8:11                         ` Konrad Dybcio
2026-04-05 20:14                       ` Laurent Pinchart
2026-03-25  9:30           ` Konrad Dybcio
2026-04-05 20:11           ` Laurent Pinchart
2026-04-05 20:15             ` Bryan O'Donoghue
2026-04-05 20:24               ` Laurent Pinchart
2026-04-05 20:28                 ` Bryan O'Donoghue
2026-03-23 12:58   ` [RFC PATCH 3/3] arm64: dts: qcom: qcm2290: Add CAMSS OPE node Loic Poulain
2026-03-23 13:03     ` Bryan O'Donoghue
2026-03-23 13:24     ` Konrad Dybcio
2026-03-23 13:33       ` Bryan O'Donoghue
2026-03-23 16:15         ` Krzysztof Kozlowski
2026-03-24 10:30           ` Bryan O'Donoghue
2026-03-23 16:31       ` Loic Poulain
2026-03-24 10:43         ` Konrad Dybcio
2026-03-24 12:54   ` [RFC PATCH 0/3] media: qcom: camss: CAMSS Offline Processing Engine support Bryan O'Donoghue
2026-03-24 16:16     ` Loic Poulain
2026-04-05 19:48       ` Laurent Pinchart
2026-04-05 19:55         ` Bryan O'Donoghue
2026-04-05 20:47           ` Laurent Pinchart
2026-04-05 21:29             ` Bryan O'Donoghue
2026-04-05 23:02             ` Bryan O'Donoghue
2026-04-06 13:22         ` Loic Poulain
2026-04-05 19:57   ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260405195744.GA1213462@killaraus.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=andersson@kernel.org \
    --cc=bod@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johannes.goede@oss.qualcomm.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox