From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F68122A80D; Tue, 7 Apr 2026 08:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775548822; cv=none; b=LD4CmR4w4W5NYTDZ539outMuiwXOuwgi+3CRvDEw8xd9lY54+afTdOVltu+kgWpszu9qVAkjzDENcZKjP+Nq4kmXKf3yxvL8/HLC42hfgTiQgIahBipr00WiDQHs4HvFJrHPd/qNGTFkWt0BYyBNNZu69ocPTtKAgqXX8mBi/MU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775548822; c=relaxed/simple; bh=rHrJHZY3qKMTUorqxjetQ3vNRjHoOGWipORPYTlnWcw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ufofmX/JZBjrHE0qwKfubQTIbCYHF/RCX8b4LFamZpoDrOCjut8U34lEWzPo/VSCUiaUsRl5/XawCBIjEPFhdZoQ9iiGv0iP9ygvjvuRHvYKll/Z1sKdShUv9iQph0RYZ83+1XS+GrSmlgmmQkm34/vTLynqNKq0BzSzW8igluc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Dtz+EQ+A; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Dtz+EQ+A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31486C116C6; Tue, 7 Apr 2026 08:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775548821; bh=rHrJHZY3qKMTUorqxjetQ3vNRjHoOGWipORPYTlnWcw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dtz+EQ+A8xG8udTTdM1HoVFU8+4hJXxPzbMZIP+SUCij4EeRR5307rc9i8cFmudGK QaMMWdbz0ya9goGUhPoHncL9DTx6f7B3dxKgxyPX5k11sYorU7PzaAiOFnGVi/OXsJ /TV7esJHLFqWcsj+iJIGB4q/NQ+qqQHiUybCJI28W1/o6rR8+qMGEeRSa6/51fBse0 w+IxG+KNgONRpniAzCX8MjOL2xT9wG2Vteorm3WY/2mDJvIBGmRm7SipmkDyvHMgZF j0QGGxIpHx45bAnbxBrOZ8oCXFanzTVbSEPNPraWjPoN+wMjZjztjIK81sZscEEkNP ozzv8ti9CK2Lg== Date: Tue, 7 Apr 2026 10:00:19 +0200 From: Krzysztof Kozlowski To: Marek Vasut Cc: devicetree@vger.kernel.org, Andrzej Hajda , Conor Dooley , David Airlie , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Rob Herring , Robert Foss , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: display: bridge: lt9211: Require data-lanes on DSI input ports Message-ID: <20260407-invaluable-pretty-leopard-1e8dfc@quoll> References: <20260404034123.340818-1-marex@nabladev.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260404034123.340818-1-marex@nabladev.com> On Sat, Apr 04, 2026 at 05:40:18AM +0200, Marek Vasut wrote: > The Lontium LT9211 is capable of 1..4 DSI lanes per input DSI port, > describe the lane count for each input port in the schema. > > Signed-off-by: Marek Vasut > --- > Cc: Andrzej Hajda > Cc: Conor Dooley > Cc: David Airlie > Cc: Jernej Skrabec > Cc: Jonas Karlman > Cc: Krzysztof Kozlowski > Cc: Laurent Pinchart > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Neil Armstrong > Cc: Rob Herring > Cc: Robert Foss > Cc: Simona Vetter > Cc: Thomas Zimmermann > Cc: devicetree@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > --- > NOTE: For example Linux kernel driver does already use that information > and fails to probe if it is missing. There are currently no intree The first sentence must be part of the commit msg. That is important reason why you are doing this... but I don't see how you achieve any of this. Look: > users for this binding, so no new warnings will be generated once > this is applied, but a new user is about to be added. What warnings? How? > --- > .../display/bridge/lontium,lt9211.yaml | 37 ++++++++++++++++++- > 1 file changed, 35 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt9211.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt9211.yaml > index 9a6e9b25d14a9..5264fb2b68b78 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lontium,lt9211.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9211.yaml > @@ -36,18 +36,50 @@ properties: > > properties: > port@0: > - $ref: /schemas/graph.yaml#/properties/port > + $ref: /schemas/graph.yaml#/$defs/port-base OK, that's correct. > + unevaluatedProperties: false > description: > Primary MIPI DSI port-1 for MIPI input or > LVDS port-1 for LVDS input or DPI input. > > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false That's correct. > + > + properties: > + data-lanes: > + description: array of physical DSI data lane indexes. > + minItems: 1 > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 That's almost redundant in this context - it was already there - and the point is that it solves noting in the problem you had. Binding still does not validate the ABI and does not match it, still. Since commit foo bar, driver needs data-lanes, so what you need to do is allow them and to require them. You can also specify their constraints if device can be configured multiple ways, up to 4 lanes. Best regards, Krzysztof