From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: caohang@eswincomputing.com, gregkh@linuxfoundation.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
Thinh.Nguyen@synopsys.com, p.zabel@pengutronix.de,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, ningyu@eswincomputing.com,
linmin@eswincomputing.com, pinkesh.vaghela@einfochips.com
Subject: Re: [PATCH v1] dt-bindings: usb: Fix EIC7700 USB reset's issue
Date: Wed, 8 Apr 2026 18:24:34 +0100 [thread overview]
Message-ID: <20260408-designed-broadband-332044a2d1fb@spud> (raw)
In-Reply-To: <20260408-ginger-grouse-of-virtuosity-b3ee92@quoll>
[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]
On Wed, Apr 08, 2026 at 09:48:43AM +0200, Krzysztof Kozlowski wrote:
> On Tue, Apr 07, 2026 at 02:17:02PM +0800, caohang@eswincomputing.com wrote:
> > From: Hang Cao <caohang@eswincomputing.com>
> >
> > The EIC7700 USB controller requires a USB PHY RESET operation.PHY RESET
>
> Missing space after full stop.
>
> > operation was missed in the verification version, as it was performed in
> > ESWIN's U-Boot.
> >
> > If a non-ESWIN provided loader is used, this issue will occur, resulting
> > in USB not work.This patch does not introduce any backward incompatibility
> > since the dts is not upstream yet.
>
> So U-Boot will be affected, no?
Is it even really affected? I don't think there's any bootloader for this
other than what ESWIN is shipping downstream, outside of people's development
trees. And any software that expected two resets will work just as badly as
it always did when a third one is added.
> And even if DTS is not upstreamed, what about all out of tree DTS?
> This is an already released ABI, so at least explain that driver does
> not care about resets here and grabs them all.
>
> >
> > Fixes: c640a4239db5 ("dt-bindings: usb: Add ESWIN EIC7700 USB controller")
>
>
> Best regards,
> Krzysztof
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-04-08 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 6:17 [PATCH v1] dt-bindings: usb: Fix EIC7700 USB reset's issue caohang
2026-04-08 7:48 ` Krzysztof Kozlowski
2026-04-08 17:24 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260408-designed-broadband-332044a2d1fb@spud \
--to=conor@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=caohang@eswincomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pinkesh.vaghela@einfochips.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox