Re: [PATCH 0/4] ASoC: Add support for GPIOs driven amplifiers

Mark Brown
2026-04-06T14:08:20Z

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

On Sun, Apr 05, 2026 at 07:00:20PM +0200, Christophe Leroy (CS GROUP) wrote:
> Le 30/03/2026 à 18:41, Herve Codina a écrit :

> > I could merge everything in one .c file but only a few part of source code
> > will be common to simple-amplifier and audio-gpio-amp. IMHO the resulting
> > merged code will look like two different drivers merged in one .c file.

> Following explanation from Herve I have the feeling that combining the two
> drivers into a single one will bring more complexity for little benefit.

> Do you still think it is worth having a combined driver allthough they
> address quite different setups ?

Yes, it's just a difference in the binding not in the runtime stuff.
The two will inevitably grow together over time, keeping them separate
is just creating a long term bikeshedding problem wondering which to use
for a given situation.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]