public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: sram: Allow multiple-word prefixes to sram subnode
@ 2026-04-08 13:28 Konrad Dybcio
  2026-04-09  8:45 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Konrad Dybcio @ 2026-04-08 13:28 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: devicetree, linux-kernel, Luca Weiss, Konrad Dybcio

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Currently, foo-sram is allowed, but foo-bar-sram is not.

Allow it so that more complex names aren't unnecessarily simplified.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/sram/sram.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sram/sram.yaml b/Documentation/devicetree/bindings/sram/sram.yaml
index c451140962c8..b65c2ff846f1 100644
--- a/Documentation/devicetree/bindings/sram/sram.yaml
+++ b/Documentation/devicetree/bindings/sram/sram.yaml
@@ -65,7 +65,7 @@ properties:
     type: boolean
 
 patternProperties:
-  "^([a-z0-9]*-)?sram(-section)?@[a-f0-9]+$":
+  "^([a-z0-9]*-|)+sram(-section)?@[a-f0-9]+$":
     type: object
     description:
       Each child of the sram node specifies a region of reserved memory.

---
base-commit: f3e6330d7fe42b204af05a2dbc68b379e0ad179e
change-id: 20260408-topic-sram_dtbindings_misc-5e8834f63d51

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: sram: Allow multiple-word prefixes to sram subnode
  2026-04-08 13:28 [PATCH] dt-bindings: sram: Allow multiple-word prefixes to sram subnode Konrad Dybcio
@ 2026-04-09  8:45 ` Krzysztof Kozlowski
  2026-04-09  9:58   ` Konrad Dybcio
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-04-09  8:45 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-kernel, Luca Weiss, Konrad Dybcio

On Wed, Apr 08, 2026 at 03:28:13PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Currently, foo-sram is allowed, but foo-bar-sram is not.
> 
> Allow it so that more complex names aren't unnecessarily simplified.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/sram/sram.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/sram/sram.yaml b/Documentation/devicetree/bindings/sram/sram.yaml
> index c451140962c8..b65c2ff846f1 100644
> --- a/Documentation/devicetree/bindings/sram/sram.yaml
> +++ b/Documentation/devicetree/bindings/sram/sram.yaml
> @@ -65,7 +65,7 @@ properties:
>      type: boolean
>  
>  patternProperties:
> -  "^([a-z0-9]*-)?sram(-section)?@[a-f0-9]+$":
> +  "^([a-z0-9]*-|)+sram(-section)?@[a-f0-9]+$":

'|)' is an odd syntax, not really intuitive. Why this cannot be:
([a-z0-9]+-)*
?
(replacing also * -> + inside)

>      type: object
>      description:
>        Each child of the sram node specifies a region of reserved memory.
> 
> ---
> base-commit: f3e6330d7fe42b204af05a2dbc68b379e0ad179e
> change-id: 20260408-topic-sram_dtbindings_misc-5e8834f63d51
> 
> Best regards,
> -- 
> Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: sram: Allow multiple-word prefixes to sram subnode
  2026-04-09  8:45 ` Krzysztof Kozlowski
@ 2026-04-09  9:58   ` Konrad Dybcio
  0 siblings, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-04-09  9:58 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Konrad Dybcio
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-kernel, Luca Weiss

On 4/9/26 10:45 AM, Krzysztof Kozlowski wrote:
> On Wed, Apr 08, 2026 at 03:28:13PM +0200, Konrad Dybcio wrote:
>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> Currently, foo-sram is allowed, but foo-bar-sram is not.
>>
>> Allow it so that more complex names aren't unnecessarily simplified.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> ---
>>  Documentation/devicetree/bindings/sram/sram.yaml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/sram/sram.yaml b/Documentation/devicetree/bindings/sram/sram.yaml
>> index c451140962c8..b65c2ff846f1 100644
>> --- a/Documentation/devicetree/bindings/sram/sram.yaml
>> +++ b/Documentation/devicetree/bindings/sram/sram.yaml
>> @@ -65,7 +65,7 @@ properties:
>>      type: boolean
>>  
>>  patternProperties:
>> -  "^([a-z0-9]*-)?sram(-section)?@[a-f0-9]+$":
>> +  "^([a-z0-9]*-|)+sram(-section)?@[a-f0-9]+$":
> 
> '|)' is an odd syntax, not really intuitive. Why this cannot be:
> ([a-z0-9]+-)*

Might as well

> ?
> (replacing also * -> + inside)

Yeah good idea

Although, as a fun tangent, I just checked and DTC accepts node
names starting with a hyphen.. We should probably change that..

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-09  9:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-08 13:28 [PATCH] dt-bindings: sram: Allow multiple-word prefixes to sram subnode Konrad Dybcio
2026-04-09  8:45 ` Krzysztof Kozlowski
2026-04-09  9:58   ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox