From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F672396588; Thu, 9 Apr 2026 08:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775722404; cv=none; b=hkvejJJ+lxKb4FKIWxlbp3jSvct1xu7C8wm0NqEnQFS1AKTUrPqCTTVClfjUuHGUAsaD8t5oDk8QONGt9hvWba28Wpap7OOF1LKIINQISB7u2Tn625TEN0T2VjzPI9Xch3cdbnLGGOOG8Kb2QFDS9mj1xXPhl+kbXP1pqiGfn8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775722404; c=relaxed/simple; bh=CgU7whiQMd3BptzzMKu/4KAdATHpRf7rC84jNQ/3l0M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tUhPBXndegNgAg2qSvgtOBAP/qII1IWJXd1UCdINp+lpQbdzhBiHYDhd9IJYrlCbU0IA3VWkPSq6h+2DmF69RiW0mrv+h0ePWElAc9P839iTTmq1kh+NGEoZnB4tzDSaY4KBlidbdvF0z32ajbo6vRz8ZjgO+z+r83Xviue6EeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NQnXBfz4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NQnXBfz4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89625C4CEF7; Thu, 9 Apr 2026 08:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775722404; bh=CgU7whiQMd3BptzzMKu/4KAdATHpRf7rC84jNQ/3l0M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NQnXBfz4tEMNrwlgBQmt+XZHESHzNgKRETe5j7yv52Nyy4kCGlgHfEov2kff4zfov idfL+6y6wMUbGv0u28HKfAFrWFMF8PmKMIUXKOEHzYGbs8klp8+yYAdAGst8fzWBSL LwNW586jTkmrq+D8J+RbP5hnhbKH9f/yI11/ut/FPcKutJIdqYh5qv5SqIWct5uEMG v51hqf6T3pnvbo+i0BQxMh2XID1fP4S1MdxN462FRoGo+WWfmqVosjLJuP0/sKrsN7 +8qe1uraHN/Xps2wmYKagbFIyEwkWHFHOhbxBK6gmGcxzzd/xQ0qebfJF7vJMESUQn CFHjXAo92atzQ== Date: Thu, 9 Apr 2026 10:13:21 +0200 From: Krzysztof Kozlowski To: Gregor Herburger Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Eric Anholt , Stefan Wahren , Srinivas Kandagatla , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: nvmem: Add a binding for the RPi Firmware OTP register Message-ID: <20260409-intrepid-discerning-peacock-bbf19a@quoll> References: <20260408-rpi-otp-driver-v1-0-e02d1dbe6008@linutronix.de> <20260408-rpi-otp-driver-v1-1-e02d1dbe6008@linutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260408-rpi-otp-driver-v1-1-e02d1dbe6008@linutronix.de> On Wed, Apr 08, 2026 at 10:00:15AM +0200, Gregor Herburger wrote: > The firmware running on the Raspberry Pi VideoCore can be used to access > OTP registers. There are two OTP regions (private and customer). Add a > binding for these. A nit, subject: drop second/last, redundant "a binding for the". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > > Signed-off-by: Gregor Herburger > --- > .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > index 983ea80eaec9..975c8927d75b 100644 > --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > @@ -137,6 +137,20 @@ required: > - compatible > - mboxes > > +patternProperties: > + "^otp-(customer|private)$": Not a pattern but just "otp". > + type: object > + additionalProperties: false > + > + properties: > + compatible: > + enum: > + - raspberrypi,firmware-otp-customer > + - raspberrypi,firmware-otp-private I don't understand why having OTP regions is not deducible from top-level compatible. I also do not get why do you need per OTP compatible. There are no resources here, so standard review would be "no" and you need strong justification in terms of DT. Best regards, Krzysztof