From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E64A32F549C; Thu, 9 Apr 2026 15:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775749310; cv=none; b=n8t+zN7GHIqz1yC/wPutAVBQUoMnjEzjC+PMsBD0BWn051cFLbfPGcWxJnDAQ7zjwLmicg2yqmTsPb8+G26kk7LR4+dN5fhIR2cAn8ITI7r0+tNIha39cWMAAG13gCplxYxYhyPUFrwgxsbxgx6j59osomre1uD0lGrOGQawQOc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775749310; c=relaxed/simple; bh=osskFND0gD7NhmG8a1qgihTn2NK1itGDCwQVH1cu8EI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TuuW08isTEvAu8upkkZxpqy0zuFPxLQrEYRk2JNZ2WBTPDAApt+AbYMTQmhaZdt2JRrWqN8fvEpUNfVtyKoxxfjG6Bd5UoS6M9XMkFdguCB4v39dSRBydpMqU08AAcBhHl0Dqk0UBz355sZWmpyzcIhFbM7fCIdQK2fRxzeMBDk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fPF2pvnr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fPF2pvnr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CEF9C4CEF7; Thu, 9 Apr 2026 15:41:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775749309; bh=osskFND0gD7NhmG8a1qgihTn2NK1itGDCwQVH1cu8EI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fPF2pvnr2fSjiJLAMO6Bh4704uS8IM2kd4jIdmqJh9Kp3mr8aIgS9maEMa8S/y78v LH7IIjy3xqgecHDnFGGUBj5+8PdSyfnTJvpQnVPN0Yqab+yKL4ViF/ouT35Mnv2jDS 5G5shg0YpHicJ2REZOgP7eWyN65ODI2QFSzA9/UqGx0UP6XL3S3Aix4UM/JbUR0Ya9 V/xFtEYPlTi/gjz9++HViNAHO7mkBxGDfCqr1Wezl8ooJcvEZpPlCP0TCT0UkJQ9S+ 8wxkIcx0c/Ddt48BXco7b+FNdDtY5H7/7/FDtPBANKFLGu97Y7cUjN34VCWpdXQ9QT AWYXRwY8V2TBw== Date: Thu, 9 Apr 2026 16:41:45 +0100 From: Conor Dooley To: Yixun Lan Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Duje =?utf-8?Q?Mihanovi=C4=87?= , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev Subject: Re: [PATCH 1/2] dt-bindings: pwm: marvell,pxa-pwm: Add SpacemiT K3 PWM support Message-ID: <20260409-laboring-announcer-4a0f9ca152a1@spud> References: <20260409-03-k3-pwm-drv-v1-0-1307a06fba38@kernel.org> <20260409-03-k3-pwm-drv-v1-1-1307a06fba38@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5LSQ/VAQK69bVtgG" Content-Disposition: inline In-Reply-To: <20260409-03-k3-pwm-drv-v1-1-1307a06fba38@kernel.org> --5LSQ/VAQK69bVtgG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 09, 2026 at 12:45:11AM +0000, Yixun Lan wrote: > The PWM controller in SpacemiT K3 SoC reuse the same IP as previous K1 > generation, while the difference is that one additional bus clock is > added. >=20 > Signed-off-by: Yixun Lan > --- > .../devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 53 ++++++++++++++++= ++++-- > 1 file changed, 50 insertions(+), 3 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml b= /Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > index 8df327e52810..3427c8ef3945 100644 > --- a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml > @@ -15,7 +15,9 @@ allOf: > properties: > compatible: > contains: > - const: spacemit,k1-pwm > + enum: > + - spacemit,k1-pwm > + - spacemit,k3-pwm > then: > properties: > "#pwm-cells": > @@ -26,6 +28,38 @@ allOf: > const: 1 > description: | > Used for specifying the period length in nanoseconds. > + - if: > + properties: > + compatible: > + contains: > + enum: > + - spacemit,k3-pwm > + then: > + properties: > + clock-names: > + items: > + - const: func > + - const: bus This condition here doesn't appear to do anything? It just repeats what's already done unconditonally below? > + - if: > + properties: > + compatible: > + contains: > + enum: > + - spacemit,k3-pwm > + then: > + required: > + - clock-names > + properties: > + clocks: > + minItems: 2 > + clock-names: > + minItems: 2 > + else: > + properties: > + clocks: > + maxItems: 1 > + clock-names: > + maxItems: 1 > =20 > properties: > compatible: > @@ -36,7 +70,9 @@ properties: > - marvell,pxa168-pwm > - marvell,pxa910-pwm > - items: > - - const: spacemit,k1-pwm > + - enum: > + - spacemit,k1-pwm > + - spacemit,k3-pwm > - const: marvell,pxa910-pwm > =20 > reg: > @@ -47,7 +83,18 @@ properties: > description: Number of cells in a pwm specifier. > =20 > clocks: > - maxItems: 1 > + minItems: 1 > + items: > + - description: The function clock > + - description: An optional bus clock > + > + clock-names: > + minItems: 1 > + maxItems: 2 > + oneOf: > + - items: > + - const: func > + - const: bus > =20 > resets: > maxItems: 1 >=20 > --=20 > 2.53.0 >=20 --5LSQ/VAQK69bVtgG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCadfIuQAKCRB4tDGHoIJi 0vTwAQD8Zicv16Y94gH/9FvNtIYLGGbQLZjiTxnKjtWIjHV5kAEAkqvgTcnemFRq wbBFrWGiCKv5Hfvy64V1KtjG8qjk+AE= =qWVE -----END PGP SIGNATURE----- --5LSQ/VAQK69bVtgG--