public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Sandom <jsandom@axon.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] arm64: dts: qcom: qcs8550: add QCS8550 RB5Gen2 board support
Date: Thu, 9 Apr 2026 11:04:55 +0100	[thread overview]
Message-ID: <20260409100455.foytyzse3k5ty55l@linaro> (raw)
In-Reply-To: <25g2sasffiq4axsamv2m5nywieucj3vbwfhvn66jtzjxoodfxx@vkswsycqju6g>

On Tue, Apr 07, 2026 at 09:44:34PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Apr 07, 2026 at 12:39:25PM +0100, Joe Sandom wrote:
> 
> [...]
> 
> > > > +&pcie0 {
> > > > +	wake-gpios = <&tlmm 96 GPIO_ACTIVE_HIGH>;
> > > > +	perst-gpios = <&tlmm 94 GPIO_ACTIVE_LOW>;
> > > > +
> > > > +	pinctrl-0 = <&pcie0_default_state>;
> > > > +	pinctrl-names = "default";
> > > > +
> > > > +	iommu-map = <0x0 &apps_smmu 0x1400 0x1>,
> > > > +		    <0x100 &apps_smmu 0x1401 0x1>,
> > > > +		    <0x208 &apps_smmu 0x1402 0x1>,
> > > > +		    <0x210 &apps_smmu 0x1403 0x1>,
> > > > +		    <0x218 &apps_smmu 0x1404 0x1>,
> > > > +		    <0x300 &apps_smmu 0x1407 0x1>,
> > > > +		    <0x400 &apps_smmu 0x1408 0x1>,
> > > > +		    <0x500 &apps_smmu 0x140c 0x1>,
> > > > +		    <0x501 &apps_smmu 0x140e 0x1>;
> > > > +
> > > > +	/delete-property/ msi-map;
> > > 
> > > Why?
> > I tried extending the msi-map to cover the RIDs from the QPS615
> > PCIe switch (matching the iommu-map entries), but this caused
> > ITS MAPD command timeouts.
> 
> I'm not aware of any specific issue with ITS on this chipset. At what time did
> you see the timeout? During probe?
So when I set msi-map to match the iommu-map entries, I got this;
[    0.000000] ITS [mem 0x17140000-0x1717ffff]
[   11.085152] ath12k_wifi7_pci 0001:04:00.0: BAR 0 assigned
[   11.115762] ath12k_wifi7_pci 0001:04:00.0: Wi-Fi 7 Hardware name: wcn7850 hw2.0
[   11.153632] ath12k_wifi7_pci 0001:04:00.0: MSI vectors: 16
[   11.252398] mhi mhi0: Requested to power ON
.........
[  101.596274] mhi mhi0: Wait for device to enter SBL or Mission mode
[  101.603098] ath12k_wifi7_pci 0001:04:00.0: failed to set mhi state: POWER_ON(2)
[  101.610632] ath12k_wifi7_pci 0001:04:00.0: failed to start mhi: -110
[  101.617171] ath12k_wifi7_pci 0001:04:00.0: failed to power up :-110
[  101.794431] ath12k_wifi7_pci 0001:04:00.0: probe failed with error -110
[  103.158872] ITS queue timeout (12640 12609)
[  103.163183] ITS cmd its_build_mapd_cmd failed

With msi-map removed, I got this;
[   11.469642] ath12k_wifi7_pci 0001:04:00.0: BAR 0 assigned
[   11.490059] ath12k_wifi7_pci 0001:04:00.0: Wi-Fi 7 Hardware name: wcn7850 hw2.0
[   11.497787] ath12k_wifi7_pci 0001:04:00.0: MSI vectors: 16
[   11.559958] mhi mhi0: Requested to power ON
[   11.567375] mhi mhi0: Power on setup success
[   11.693069] mhi mhi0: Wait for device to enter SBL or Mission mode
[   12.185946] ath12k_wifi7_pci 0001:04:00.0: chip_id 0x2 ... soc_id 0x40170200
[   12.482168] ath12k_wifi7_pci 0001:04:00.0 wlP1p4s0: renamed from wlan0
> 
> > From what I could gather, deleting
> > msi-map forces the PCIe controller to fall back to the internal
> > iMSI-RX module, where this worked properly.
> > 
> 
> That's true.
> 
> > For reference, I checked the RB3gen2 since it also uses a QPS615
> > and there doesn't seem to be any msi-map defined (in kodiak.dtsi).
> > 
> 
> But Kodiak has no MSI support (no LPIs). That's why the ITS node is disabled and
> iommu-map is used.
Good to know, thanks Mani.
> 
> > Any recommendations to resolve this properly?
> 
> I will also check internally in the meantime.
Thanks Mani
> 
> - Mani
> 
> -- 
> மணிவண்ணன் சதாசிவம்

  reply	other threads:[~2026-04-09 10:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-04  9:50 [PATCH 0/5] arm64: dts: qcom: add QCS8550 RB5Gen2 support Joe Sandom via B4 Relay
2026-04-04  9:50 ` [PATCH 1/5] arm64: dts: qcom: sm8550: add PCIe MHI register regions and port labels Joe Sandom via B4 Relay
2026-04-04 21:07   ` Dmitry Baryshkov
2026-04-07  8:53     ` Joe Sandom
2026-04-07 11:05   ` Konrad Dybcio
2026-04-07 11:43     ` Joe Sandom
2026-04-04  9:50 ` [PATCH 2/5] arm64: dts: qcom: sm8550-hdk: update PCIe port label reference Joe Sandom via B4 Relay
2026-04-04 21:07   ` Dmitry Baryshkov
2026-04-07  8:55     ` Joe Sandom
2026-04-05  8:11   ` Krzysztof Kozlowski
2026-04-04  9:50 ` [PATCH 3/5] arm64: dts: qcom: sm8550-qrd: " Joe Sandom via B4 Relay
2026-04-04  9:50 ` [PATCH 4/5] dt-bindings: arm: qcom: document QCS8550 RB5Gen2 board Joe Sandom via B4 Relay
2026-04-05  8:11   ` Krzysztof Kozlowski
2026-04-04  9:50 ` [PATCH 5/5] arm64: dts: qcom: qcs8550: add QCS8550 RB5Gen2 board support Joe Sandom via B4 Relay
2026-04-04 21:20   ` Dmitry Baryshkov
2026-04-07 11:39     ` Joe Sandom
2026-04-07 15:01       ` Dmitry Baryshkov
2026-04-07 15:43         ` Joe Sandom
2026-04-07 16:14       ` Manivannan Sadhasivam
2026-04-09 10:04         ` Joe Sandom [this message]
2026-04-09 11:26           ` Manivannan Sadhasivam
2026-04-09 11:46             ` Joe Sandom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260409100455.foytyzse3k5ty55l@linaro \
    --to=jsandom@axon.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox