Re: [PATCH 5/5] arm64: dts: qcom: qcs8550: add QCS8550 RB5Gen2 board support

Joe Sandom
2026-04-07T15:43:37Z

On Tue, Apr 07, 2026 at 06:01:34PM +0300, Dmitry Baryshkov wrote:
> On Tue, Apr 07, 2026 at 12:39:25PM +0100, Joe Sandom wrote:
> > On Sun, Apr 05, 2026 at 12:20:23AM +0300, Dmitry Baryshkov wrote:
> > > On Sat, Apr 04, 2026 at 10:50:58AM +0100, Joe Sandom via B4 Relay wrote:
> > > > +
> > > > + wcn7850-pmu {
> > > > + compatible = "qcom,wcn7850-pmu";
> > > > +
> > > > + pinctrl-names = "default";
> > > > + pinctrl-0 = <&wlan_en>, <&bt_default>, <&pmk8550_sleep_clk>;
> > >
> > > swctrl?
> > Bundled into bt_default since it's tied to BT
>
> It's not. It's either WiFi or BT.
Ack. Will fix in v2.
>
> > >
> > > > +
> > > > + wlan-enable-gpios = <&tlmm 80 GPIO_ACTIVE_HIGH>;
> > > > + bt-enable-gpios = <&tlmm 81 GPIO_ACTIVE_HIGH>;
> > >
>
> [...]
>
> > > > + iommu-map = <0x0 &apps_smmu 0x1400 0x1>,
> > > > + <0x100 &apps_smmu 0x1401 0x1>,
> > > > + <0x208 &apps_smmu 0x1402 0x1>,
> > > > + <0x210 &apps_smmu 0x1403 0x1>,
> > > > + <0x218 &apps_smmu 0x1404 0x1>,
> > > > + <0x300 &apps_smmu 0x1407 0x1>,
> > > > + <0x400 &apps_smmu 0x1408 0x1>,
> > > > + <0x500 &apps_smmu 0x140c 0x1>,
> > > > + <0x501 &apps_smmu 0x140e 0x1>;
> > > > +
> > > > + /delete-property/ msi-map;
> > >
> > > Why?
> > I tried extending the msi-map to cover the RIDs from the QPS615
> > PCIe switch (matching the iommu-map entries), but this caused
> > ITS MAPD command timeouts. From what I could gather, deleting
> > msi-map forces the PCIe controller to fall back to the internal
> > iMSI-RX module, where this worked properly.
> >
> > For reference, I checked the RB3gen2 since it also uses a QPS615
> > and there doesn't seem to be any msi-map defined (in kodiak.dtsi).
> >
> > Any recommendations to resolve this properly?
>
> Maybe Mani knows. Please mention this in the commit message at least.
>
Will do.
> > >
> > > > +
> > > > + status = "okay";
> > > > +};
> > > > +
>
> --
> With best wishes
> Dmitry
Thanks for the review Dmitry