From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56987225417 for ; Fri, 10 Apr 2026 18:42:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775846538; cv=none; b=B5viO/bsQUPSc78hZ1ZAT400U13cl6sDAE/GC1imepn7UQCxWfyvqOLracLSV47lGy2e3vlC2KG4weYG5IDIzug/7+cwE+jc69xTsnioWpRZV3DL7E45uwirfjwS6T/4Z+3tgmsEwzeiy/6pHjCbtkTcYAcVbMlOjU2jwRbURL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775846538; c=relaxed/simple; bh=ouPi1ZiJUsBaKoIcH7MusrtXJiLks6Kjjc7E4RkpFZ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZkGhUZDGiqEyT6oBSf9yAyB0nFRnK8tTRBELWvJbWnZbswdIpCUgLPEPjQBdw90LNe5xz+Xea80kAD+c8R33ZWLZWgnMZE+gEAzsX8S5dvNhcIu4pjIhCzaZfiWyvxPC5NBX0RsG1uSm8NJ7zarqM0T8zRBcVtq1UijRrYX3Q/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XN7p528s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aubSvuqJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XN7p528s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aubSvuqJ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63AIWvXc438864 for ; Fri, 10 Apr 2026 18:42:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=ScFJTMIhanl 9g/GPsZpHAkrXeh01kbLAZ6veu6zF/Yc=; b=XN7p528sDlb3ikhx+B330AAhx3N Hj0GLwYRYkf8kRZhaA39Rd+zGG1ykQxxzYd7JUJUVUqlib/npjcylr6xHoePE40x xxNGTFDuf/jsg3ar+ngHNe5vUHYstnvDBgKDW2H9Te/Np2emZlY1Xj4xwH8ByKK4 bgBVIOfybpIfFSUscthOka1UnggB/NuhLHuQhzQU2o/xitW3tfphIgnGoLKzYeK9 Cxfjl80KjbuS5b4rJaQYLQPgKcJM0iXPpjcHztZoIkHJ1wakaK+UWCiSRn3SV0qS wlzLLBZL7UBMEsudQ2ATRfj1P5gAI0nkqory3DVYg/C2VnXZWHCwsaMOS9A== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4deyy9sebf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Apr 2026 18:42:16 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82f07cc6590so993485b3a.3 for ; Fri, 10 Apr 2026 11:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775846536; x=1776451336; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ScFJTMIhanl9g/GPsZpHAkrXeh01kbLAZ6veu6zF/Yc=; b=aubSvuqJQSfyQvo51dohHWoY4w8QsrOm/+K+yCGWVv3wAZpDSlcks85jnjlrK1e2Vv rgtlX0vwK6/zqACJpjYYGIN+3kFhdZg4fAasKNzSZWSpujjuTcYggBO8rFArhsTmCZy/ qMJUb+UqFGBjtQg2mTu7My2ogpq/xxYz6bVGxKa3tQhS4IqK0ywHoFcHI674Avrx1B3I McxdDi3GSwbQYFSfTKs1O8JYdiMBkDn1lB5/SJDGn0WLS0iQ5h3eGIQ+huJ/Nn8QCVwq FGb6wp0a3uMFh2xj2bUk/fXO+geXX7xkLIIgCJoUyfJFa3HZiyZ4sqprsjiuKPFKGCFP Hzww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775846536; x=1776451336; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ScFJTMIhanl9g/GPsZpHAkrXeh01kbLAZ6veu6zF/Yc=; b=oPamjk3ZnY25ulTtwIxSTP9Ngu0gFkOOCu2s9b+XnZr2W+by8i+EeKVfgoum2RMep9 cDyurnPbhMQnCx97EElIG/A5YRazL2lAeBFja7wPAyU/UANjgXMPWvc42SlOjEkbOpOE GHcpXqATHM+6fqt/vC3BzotXlanBHDQ8MpgrnIv6b8POa97gC2J5t2G9EbZaVVNmfewl EtVeP/UGmJI010DAMy03Ckg3ryH33P9u57KpwmF0oF9B9nD7Yo+rxTVk/tKUT6CWudLF FKB0aYIhxgGa6nNzUH7239LnB02y/xFpwqrse5Zu4Ez1GeD4QSHb3VwEFzA8eTtuwlMG Lm3Q== X-Forwarded-Encrypted: i=1; AJvYcCXAEkRgbtqNGiD/pecMAS+Zi4TjB0p5hyiGxIWyTAsFbwT7SWgS3MamJadSAtlulFjJ87828CuEumoj@vger.kernel.org X-Gm-Message-State: AOJu0Yyqbsp0aEk0DwdE1pwbRwrE+8kQRaycyY7odX/P/6Q2pmO3sSSk NcDv1QYe+820p3sQe5muAZoi0/2iqPLexaoo7YfJV7c2N5E4Z0XTUmgTys08ILrXbvM+oxrEY2h 16uGfhOIpYeulKEUH8waBdA+Ti6InFeH5sqZp5WkxDlE6ebE/a3cnBXXd0wXfYk/B X-Gm-Gg: AeBDietrbPyXkXnLHPbKZFaW6R9x5OQM9rR2s311vRgsIBvnt8ZX5FQeRrVPCjNjElz efslkVpM6tKthe4N24Dbo9gjnqM3zjf6c5CSR8bMBLm6XAD0Z1gj9lQ11QkYkPd4ezHrZl3sECq ITgZnuVeRQam5j1rw/xXyozJYsEaAySjNbF2ilTPRmTbuhEk5pFxT8QcbI+rs2yMbgg3CpyrHPT TgY1Z6yOwR4ndGv6WznX3b/OUTDLbhnt2+Y17RtrQ1ioeohHiXmMOHdJ+8O0yOFYu04/RTsXdY+ TTDR25yjUj9OqclTD2D2nW9dYrBKw9a+oNtG1ufzp4K7BBDc+kwXJuMZ7dBgTgpW9+QcCBBDE9Y 65K0l/jzO0pibOSrzftkvk4/c9S0bWihJZq06wiBZXVxkO5NP X-Received: by 2002:a05:6a00:39a8:b0:82c:ed02:a242 with SMTP id d2e1a72fcca58-82f0c404ec2mr4565628b3a.52.1775846535641; Fri, 10 Apr 2026 11:42:15 -0700 (PDT) X-Received: by 2002:a05:6a00:39a8:b0:82c:ed02:a242 with SMTP id d2e1a72fcca58-82f0c404ec2mr4565574b3a.52.1775846534859; Fri, 10 Apr 2026 11:42:14 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c32e744sm4036922b3a.13.2026.04.10.11.42.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 11:42:14 -0700 (PDT) From: Mukesh Ojha To: Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mukesh Ojha Subject: [PATCH 03/35] irqchip/qcom-pdc: Tighten ioremap clamp to single DRV region size Date: Sat, 11 Apr 2026 00:10:40 +0530 Message-ID: <20260410184124.1068210-4-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260410184124.1068210-1-mukesh.ojha@oss.qualcomm.com> References: <20260410184124.1068210-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEwMDE3NCBTYWx0ZWRfX+u+Bn/r0isKo RaRJW4McTOO7XQHvpyiwFdm8/w0tDVihn81opNtu58JDJ5ed/FDDraaPSwPsbDiBMFx93evkeg9 p82olK7V4xD96fBMUBtKgfO1U0A/sCIyaq6s0ZXKMIs+n8HtkUANzWQOaA33YkNI3S2gLBjavDA aaDU1GdVxw6H9gfskyz55ixd1D6kSk/H0h6Id+kP7rMY/Jk3k2uHeBgB3ErwwcDfibGzIKSxdZi USRr1uswz6xK6lCkGrvHpimQiRVgkZD7v7DzcV4S+w94LP3l/usuYXE0/j2rTPiBa4h/ghIJ928 W7mAmuLYpD6CWzptLpUwQcrjIFVe2PUZHYb0WJHV0zhJBhCUvfyjrab36U8xSeUrX5fVS1Eez+b s9iydVaPONsBwABs45QjTyJd/VJGZxC51514wv3ybj6lAGHZdQ4qh7ShD+FZCdjkFRbMd2S0DCn oiGSKr8V0x2nqfBSeaA== X-Proofpoint-GUID: 806rwIsZVQuoto1xlwnGEMfqdtb-osHg X-Authority-Analysis: v=2.4 cv=d6fFDxjE c=1 sm=1 tr=0 ts=69d94488 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=tOrHYADZn3q5Ogi6NzYA:9 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: 806rwIsZVQuoto1xlwnGEMfqdtb-osHg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-10_05,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 impostorscore=0 adultscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604100174 The QCOM_PDC_SIZE constant (0x30000) was introduced to work around old sm8150 DTs that described a too-small PDC register region, causing the driver to silently expand the ioremap to cover three DRV regions. Now that the preceding DT fixes have corrected all platforms to describe only the APSS DRV region (0x10000), the oversized clamp is no longer needed. Replace QCOM_PDC_SIZE with PDC_DRV_SIZE (0x10000) in the clamp so the minimum mapped size matches a single DRV region. The clamp and warning are intentionally kept to preserve backward compatibility with any old DTs that may still describe a smaller region. While at it, rename PDC_DRV_OFFSET to PDC_DRV_SIZE since the constant represents the size of a DRV region and is used as both the ioremap minimum size and the offset to the previous DRV region. Signed-off-by: Mukesh Ojha --- drivers/irqchip/qcom-pdc.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c index a72e32896e64..21e2b4b884ee 100644 --- a/drivers/irqchip/qcom-pdc.c +++ b/drivers/irqchip/qcom-pdc.c @@ -21,7 +21,7 @@ #include #define PDC_MAX_GPIO_IRQS 256 -#define PDC_DRV_OFFSET 0x10000 +#define PDC_DRV_SIZE 0x10000 /* Valid only on HW version < 3.2 */ #define IRQ_ENABLE_BANK 0x10 @@ -358,7 +358,6 @@ static int pdc_setup_pin_mapping(struct device_node *np) return 0; } -#define QCOM_PDC_SIZE 0x30000 static int qcom_pdc_probe(struct platform_device *pdev, struct device_node *parent) { @@ -372,7 +371,7 @@ static int qcom_pdc_probe(struct platform_device *pdev, struct device_node *pare if (of_address_to_resource(node, 0, &res)) return -EINVAL; - res_size = max_t(resource_size_t, resource_size(&res), QCOM_PDC_SIZE); + res_size = max_t(resource_size_t, resource_size(&res), PDC_DRV_SIZE); if (res_size > resource_size(&res)) pr_warn("%pOF: invalid reg size, please fix DT\n", node); @@ -385,7 +384,7 @@ static int qcom_pdc_probe(struct platform_device *pdev, struct device_node *pare * region with the expected offset to preserve support for old DTs. */ if (of_device_is_compatible(node, "qcom,x1e80100-pdc")) { - pdc_prev_base = ioremap(res.start - PDC_DRV_OFFSET, IRQ_ENABLE_BANK_MAX); + pdc_prev_base = ioremap(res.start - PDC_DRV_SIZE, IRQ_ENABLE_BANK_MAX); if (!pdc_prev_base) { pr_err("%pOF: unable to map previous PDC DRV region\n", node); return -ENXIO; -- 2.53.0