From: Krzysztof Kozlowski <krzk@kernel.org>
To: dennis@ausil.us
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
FUKAUMI Naoki <naoki@radxa.com>, Hsun Lai <i@chainsx.cn>,
Jonas Karlman <jonas@kwiboo.se>,
Chaoyi Chen <chaoyi.chen@rock-chips.com>,
John Clark <inindev@gmail.com>,
Michael Opdenacker <michael.opdenacker@rootcommit.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Andrew Lunn <andrew@lunn.ch>, Chukun Pan <amadeus@jmu.edu.cn>,
Alexey Charkov <alchark@gmail.com>,
Peter Robinson <pbrobinson@gmail.com>,
Michael Riesch <michael.riesch@collabora.com>,
Mykola Kvach <xakep.amatop@gmail.com>,
Jimmy Hon <honyuenkwun@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/3] arm64: dts: rockchip: Add Orange Pi 5 Pro board support
Date: Sat, 11 Apr 2026 15:58:28 +0200 [thread overview]
Message-ID: <20260411-practical-persimmon-foxhound-f5869d@quoll> (raw)
In-Reply-To: <20260411024743.195385-4-dennis@ausil.us>
On Fri, Apr 10, 2026 at 09:47:43PM -0500, dennis@ausil.us wrote:
> From: Dennis Gilmore <dennis@ausil.us>
>
> Add device tree for the Xunlong Orange Pi 5 Pro (RK3588S).
>
> - eMMC module, you can optionally solder a SPI NOR in place and turn
> off the eMMC
> - PCIe-attached NIC (pcie2x1l1)
> - PCIe NVMe slot (pcie2x1l2)
> - AP6256 WiFi (BCM43456) via SDIO with mmc-pwrseq
> - BCM4345C5 Bluetooth
> - es8388 audio
> - USB 2.0 and USB 3.0
> - Two HDMI ports, the second is connected to the SoC's DP controller
> driven by a transparent LT8711UXD bridge that has firmware onboard and
> needs no node defined.
>
> Vendors description and links to schematics available:
> http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-5-Pro.html
>
> Signed-off-by: Dennis Gilmore <dennis@ausil.us>
> ---
> .../display/rockchip/rockchip,dw-dp.yaml | 7 +
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Didn't you already got this comment?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-11 13:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 2:47 [PATCH v6 0/3] Add support for Orange Pi 5 Pro dennis
2026-04-11 2:47 ` [PATCH v6 1/3] dt-bindings: arm: rockchip: Add " dennis
2026-04-11 2:47 ` [PATCH v6 2/3] arm64: dts: rockchip: refactor items from Orange Pi 5/b to prep for Pro dennis
2026-04-11 11:58 ` Jimmy Hon
2026-04-11 2:47 ` [PATCH v6 3/3] arm64: dts: rockchip: Add Orange Pi 5 Pro board support dennis
2026-04-11 13:58 ` Krzysztof Kozlowski [this message]
2026-04-11 18:00 ` Alexey Charkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260411-practical-persimmon-foxhound-f5869d@quoll \
--to=krzk@kernel.org \
--cc=alchark@gmail.com \
--cc=amadeus@jmu.edu.cn \
--cc=andrew@lunn.ch \
--cc=chaoyi.chen@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=dennis@ausil.us \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=honyuenkwun@gmail.com \
--cc=i@chainsx.cn \
--cc=inindev@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.opdenacker@rootcommit.com \
--cc=michael.riesch@collabora.com \
--cc=naoki@radxa.com \
--cc=pbrobinson@gmail.com \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
--cc=xakep.amatop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox