From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1FAA313E10; Sun, 12 Apr 2026 09:58:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775987925; cv=none; b=lINAdrLXOM2XNHF4kYea3Bo9426f1po3ysxzJfsHz93mPwlMVoBUcISXxC2g+AvZXDi3Web+qTv4E8fsMJcmUhSD4nmy3HWroofrcmqqVe8cG058vC5arNB5FnzbWQtik/+B1X1KXzukOdooPSz0YynDb0QmGpjAwVOHq8oIE7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775987925; c=relaxed/simple; bh=zIplO9XJuBXyoCejItnRIwDvvhcyaRbki3fs/p1THpU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qICJEmA6GX39Q0Er2TtT/0GD7a7ubCdJsJAfucb7nHHyTLe++ANdBhlcyJ1EVYr1jWBT2s7dzyViw866D4pyT5gWOcds+wGEPWo43SpmIFD3jU+7MSujGtWcL/heSg97v11wupxstBdQgnDxtTNJDcnuRutjnXtRQdM2qzrLnII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ApjeXvFz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ApjeXvFz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 256E7C19424; Sun, 12 Apr 2026 09:58:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775987924; bh=zIplO9XJuBXyoCejItnRIwDvvhcyaRbki3fs/p1THpU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ApjeXvFzueV95XP2YOnVk5tJ0hV4tBLnKhSecuiG6Gr4VAnKHjqAds8qb8X+3u4z3 d+GsxDjxfrEgPac1NbkCR7/jkZEplLioV9Mo8C5k0D8W2LO3AtjRxn7pgLLlai7YiD fdiQF2o2RiIAAT0s9qmOEZJg2yY0NVFO2krzfU1oE+mTo/DG24LMs99IHCa7okyUXu v+iuiDzsNyyzrEkCR6sQySiSHfkoCr+gpXHP7pr8o1G6CAli+SG0hJn09J6mxoDgVe Sn5L8R2ckRzp17fFBBXzuftPMtehuOJChwRh0keHyGY86ivNjGiKOZJ8OcsPkoJ0X7 zBRj8og8Qz+7g== Date: Sun, 12 Apr 2026 11:58:42 +0200 From: Krzysztof Kozlowski To: Ronald Claveau Cc: Guillaume La Roque , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/8] dt-bindings: thermal: amlogic: Add support for T7 Message-ID: <20260412-abiding-silver-turkey-1623cc@quoll> References: <20260410-add-thermal-t7-vim4-v1-0-19f2b8da74d7@aliel.fr> <20260410-add-thermal-t7-vim4-v1-1-19f2b8da74d7@aliel.fr> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260410-add-thermal-t7-vim4-v1-1-19f2b8da74d7@aliel.fr> On Fri, Apr 10, 2026 at 06:48:02PM +0200, Ronald Claveau wrote: > Add the amlogic,t7-thermal compatible for the Amlogic T7 thermal sensor. > > Unlike existing variants which use a phandle to the ao-secure syscon, > the T7 relies on a secure monitor interface described by a phandle and > a sensor index argument. > > Introduce the amlogic,secure-monitor property as a phandle-array and > make amlogic,ao-secure or amlogic,secure-monitor conditionally required > depending on the compatible. > > Signed-off-by: Ronald Claveau > --- > .../bindings/thermal/amlogic,thermal.yaml | 40 +++++++++++++++++++++- > 1 file changed, 39 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml > index 70b273271754b..85ee73c6e1161 100644 > --- a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml > @@ -22,6 +22,7 @@ properties: > - amlogic,g12a-ddr-thermal > - const: amlogic,g12a-thermal > - const: amlogic,a1-cpu-thermal > + - const: amlogic,t7-thermal So these two entries are enum. > > reg: > maxItems: 1 > @@ -42,12 +43,40 @@ properties: > '#thermal-sensor-cells': > const: 0 > > + amlogic,secure-monitor: > + description: phandle to the secure monitor > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + - items: > + - description: phandle to the secure monitor > + - description: sensor index For what exactly this sensor index is needed? commit msg explained me nothing, instead repeated what you did. That's pointless, explain why you did it. > + > required: > - compatible > - reg > - interrupts > - clocks > - - amlogic,ao-secure > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - amlogic,g12a-cpu-thermal > + - amlogic,g12a-ddr-thermal Drop both, you need only fallback. > + - amlogic,a1-cpu-thermal And list is sorted alphabetically. > + then: > + required: > + - amlogic,ao-secure Best regards, Krzysztof