From: Krzysztof Kozlowski <krzk@kernel.org>
To: Harpreet Saini <sainiharpreet29@yahoo.com>
Cc: jic23@kernel.org, "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Bjorn Andersson" <bjorn.andersson@oss.qualcomm.com>,
"Marek Vasut" <marex@nabladev.com>,
"Kael D'Alcamo" <dev@kael-k.io>,
"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: light: Add PixArt PAJ7620 gesture sensor
Date: Mon, 13 Apr 2026 10:20:32 +0200 [thread overview]
Message-ID: <20260413-antique-bright-gerbil-87674c@quoll> (raw)
In-Reply-To: <20260413000308.7618-1-sainiharpreet29@yahoo.com>
On Sun, Apr 12, 2026 at 08:02:55PM -0400, Harpreet Saini wrote:
> Signed-off-by: Harpreet Saini <sainiharpreet29@yahoo.com>
> ---
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
> This is part 1 of a 2-patch series proposing a driver for the PixArt
> PAJ7620 gesture sensor. This patch adds the Device Tree bindings and
> registers the "pixart" vendor prefix. The driver patch will follow in
> a succeeding branch.
No, we do not want bindings without users. The driver patch must follow
here. We also do not work with branches, but patches on mailing list.
Please read submitting patches documents - both, so also the one in DT
binding dir.
I finished the review here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-13 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260413000308.7618-1-sainiharpreet29.ref@yahoo.com>
2026-04-13 0:02 ` [PATCH] dt-bindings: iio: light: Add PixArt PAJ7620 gesture sensor Harpreet Saini
2026-04-13 8:20 ` Krzysztof Kozlowski [this message]
2026-04-13 14:25 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260413-antique-bright-gerbil-87674c@quoll \
--to=krzk@kernel.org \
--cc=andy@kernel.org \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=dev@kael-k.io \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@nabladev.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=sainiharpreet29@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox