Re: [PATCH 1/2] dt-bindings: socfpga: Add the Agilex7 series SoC's

Krzysztof Kozlowski
2026-04-14T07:16:49Z

On Mon, Apr 13, 2026 at 09:45:52AM -0500, Dinh Nguyen wrote:
> The Agilex7 is a series of devices from Altera that are derived from
> the Agilex family.

SoCs?

>
> The Agilex7F device supports PCIE 4.0 and DDR4. The Agilex7I device supports

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

> PCIE 5.0 and DDR4, while the Agilex7M device supports DDR4, DDR5, LPDDR5
> and PCIE 5.0.
>
> All other peripherals from these devices are the same as the Agilex
> device.
>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> ---
> Documentation/devicetree/bindings/arm/altera.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
> index 206686f3eebc..5ee09f8d4698 100644
> --- a/Documentation/devicetree/bindings/arm/altera.yaml
> +++ b/Documentation/devicetree/bindings/arm/altera.yaml
> @@ -115,6 +115,16 @@ properties:
> - intel,socfpga-agilex5-socdk-nand
> - const: intel,socfpga-agilex5
>
> + - description: Agilex7 series F, I and M boards
> + items:
> + - enum:
> + - intel,socfpga-agilex7m-socdk

Why does "7m-socdk" go with "7i" and "7m"? If these are SoCs, then board
using soc 7m cannot use 7i or 7f fallback.

Or board is not using 7m SoC, but then the name is misleading.

> + - enum:
> + - intel,socfpga-agilex7f
> + - intel,socfpga-agilex7i
> + - intel,socfpga-agilex7m
> + - const: intel,socfpga-agilex

Best regards,
Krzysztof