From: Conor Dooley <conor@kernel.org>
To: Ariana.Lazar@microchip.com
Cc: dlechner@baylibre.com, nuno.sa@analog.com,
Conor.Dooley@microchip.com, Jonathan.Cameron@huawei.com,
robh@kernel.org, jic23@kernel.org, andy@kernel.org,
krzk+dt@kernel.org, linux-iio@vger.kernel.org,
conor+dt@kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: dac: add support for Microchip MCP48FEB02 to MCP47FEB02
Date: Tue, 14 Apr 2026 16:34:40 +0100 [thread overview]
Message-ID: <20260414-undated-chug-0526be77c0a7@spud> (raw)
In-Reply-To: <dd516b8155d9e782855f5e06e2260d57b596184b.camel@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
On Tue, Apr 14, 2026 at 01:39:32PM +0000, Ariana.Lazar@microchip.com wrote:
> Hi Conor,
>
> > >
> > > patternProperties:
> > > @@ -161,8 +222,7 @@ patternProperties:
> > > properties:
> > > reg:
> > > description: The channel number.
> > > - minItems: 1
> > > - maxItems: 8
> > > + maxItems: 1
> >
> > Why is this changing? Was it originally a mistake and what you wanted
> > was a max of 8 but only one entry?
> >
> > >
>
>
> Thank you for the review.
>
> It was a mistake I missed in the devicetree
> binding for the mcp47feb02 driver. The property contains a single
> integer representing the channel number (0-7), as you said.
>
> Should I send a fix for the mcp47feb02 binding first or can I continue
> to rewrite/split mcp47feb02 driver into the core module with I2C
> protocol file and include this binding fix there too?
Do it separately please with a fixes tag and all that jazz.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-04-14 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 10:50 [PATCH 0/2] Add support for Microchip MCP48F(E/V)B(0/1/2)(1/2/4/8) on MCP47F(E/V)B(0/1/2)(1/2/4/8) Ariana Lazar
2026-04-03 10:50 ` [PATCH 1/2] dt-bindings: iio: dac: add support for Microchip MCP48FEB02 to MCP47FEB02 Ariana Lazar
2026-04-03 11:32 ` Conor Dooley
2026-04-14 13:39 ` Ariana.Lazar
2026-04-14 15:34 ` Conor Dooley [this message]
2026-04-03 12:25 ` Rob Herring (Arm)
2026-04-04 13:43 ` David Lechner
2026-04-03 10:50 ` [PATCH 2/2] iio: dac: mcp47feb02: add MCP48FEB02 SPI driver to MCP47FEB02 I2C driver Ariana Lazar
2026-04-04 13:49 ` David Lechner
2026-04-08 20:22 ` Andy Shevchenko
2026-04-14 15:28 ` Ariana.Lazar
2026-04-14 15:48 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260414-undated-chug-0526be77c0a7@spud \
--to=conor@kernel.org \
--cc=Ariana.Lazar@microchip.com \
--cc=Conor.Dooley@microchip.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox