From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79AD01E511; Tue, 14 Apr 2026 18:29:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776191364; cv=none; b=PbymFub+aXJCjadmUJTsFfKWpH51HoYaXFs/UCILnQb51TPLCqzSga0e3j8knCM7/fw7d0nikvAh2s2zkbdg3SRFU4ZpmZK79qCr3r9jbw2tJYDvk5T/VbmYyQOpwpivlm8heynHbhlaQaPNrnsuvPqaGm8AivqYbNJCP4Ziqnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776191364; c=relaxed/simple; bh=bZhOSn23zxWxgujY4eCddNVUXmuhP+1hxbBgE3l3NJE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Z9+V6hPGZ8LWdjAsItFXYVwKzLA8MVfUGny5Iv5sJZRXGt4rbFYyyy8pcSzEABbX8ox+6nwP0bxsTmwYqEVpjLH4SMjbLm2loj5AFWoOGTo8MSl+F/1B1zYn4QXwvpHhgDMd0Cy2FKY7c43KgAW5dwrHQB9Hug34U4nzhbIwer0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RzdLSAF7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RzdLSAF7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00AD6C19425; Tue, 14 Apr 2026 18:29:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776191364; bh=bZhOSn23zxWxgujY4eCddNVUXmuhP+1hxbBgE3l3NJE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RzdLSAF7SCjY1x3Ksr02OMk2D9F+QBPgy0OglB9AUj5Ow9wfpjacx2uJoEjD0jetk 6e6Zn6hj3HALkv8OGTy0B857v4C38fgEQ3o5DPp4uLakPld8UokMiVHd7l0y2kiV0B /q3McSRY1rV8Rifen3pPi+QfzO9EMX0dB6TQ25Pl/Bx3FQ3cADcNksK/RpBFCYIfnX lpaMN1UPQ6KY/9NlIuHkMNWHbA53SsBXl8pYXY+7mIcw232IUeatRRhb/507jqLFnr h51yCifXOVLvAewTmqdfHhRkvMpD/wMxZhkv6LvlcXz+ecd8kIqXULyyY1Jd/juw0e jI7D82POV3pYw== Date: Tue, 14 Apr 2026 19:29:14 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Chris Morgan , linux-iio@vger.kernel.org, andy@kernel.org, nuno.sa@analog.com, dlechner@baylibre.com, jean-baptiste.maneyrol@tdk.com, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, heiko@sntech.de, conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, Chris Morgan Subject: Re: [PATCH V3 2/9] iio: imu: inv_icm42607: Add Core for inv_icm42607 Driver Message-ID: <20260414192914.3661409b@jic23-huawei> In-Reply-To: References: <20260330195853.392877-1-macroalpha82@gmail.com> <20260330195853.392877-3-macroalpha82@gmail.com> <20260413200547.75bfd672@jic23-huawei> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 14 Apr 2026 10:14:48 +0300 Andy Shevchenko wrote: > On Mon, Apr 13, 2026 at 08:06:54PM +0100, Jonathan Cameron wrote: > > On Mon, 30 Mar 2026 14:58:46 -0500 > > Chris Morgan wrote: > > ... > > > > + if (!conf->temp_en) > > > + val |= INV_ICM42607_PWR_MGMT0_ACCEL_LP_CLK_SEL; > > > > Could make this > > val |= FIELD_PREP(INV_ICM42607_PWR_MGMT0_ACCEL_LP_CLK_SEL, > > !conf->temp_en); > > Not particularly important though if you prefer the if. > > Isn't this becomes FIELD_MODIFY()? > Yes, in this particular case as the bit has never been set before this line, they end up the same. If the compiler fails to notice it doesn't need to zero the bit if conf->temp_en is true might make it more efficient to do it the way I had it but given this isn't a fast path, FIELD_MODIFY() is fine. Jonathan