From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42C1F31328E; Wed, 15 Apr 2026 07:17:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776237431; cv=none; b=DFhVJpMRjtllWcTfykdF1toE0z9qJ4xVfNshd+2C/nK0xL9EYoXjoN68Pb4iYkq2NSIrLkgUFuXjzOAJLwkp77KzHz8F302JnxL14TL2FvTtS6wRvsPnBucPrjVYSmT4avKmyYBaaacvzBxLQWfLI0ZGAw2OvOkEaMPnnAfyUeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776237431; c=relaxed/simple; bh=bykFpr8kKL0KUiE5ut+6uzeRN863t6CApjvZn+J1jhQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hYYRrOcRBVRqSGWbryi8apYff4ZK14mK9b8rf+p6jL7l211tfTVaINiBuqcRnh+CZMubIreRZN5Hu4cgOX7xTqSDAxticVucJMeXCoXl8qEhrnGLo53hM7l3reApEa/VSLf85wYz56FVbyzv0jUsBKJeKFzDzNaKnf5mmSVLsJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I4J6Veg5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I4J6Veg5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5772FC19424; Wed, 15 Apr 2026 07:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776237430; bh=bykFpr8kKL0KUiE5ut+6uzeRN863t6CApjvZn+J1jhQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I4J6Veg5TT877gFljTbmDugKyzpSmgLY0RI1SWRbRpuBrqGoLpe9/Uohbo1XNMfbn Qdkiaye7Qn2CpOLyaZOSv0swCrgfySbYdfOovGaq1yLioet3xR26Z99Nj4DQA8Dewy 2B7wPRPc7gKmgqGNNCK+avKo5iR8eKtJfHEVrAhPpNkqsHy6Ye1wyBm1a50I9Shotp AdLn1jgH7Q4GzE17Wjpwtx4q7bBi8oWZeOS/IbiQ3I7I9WnvgXKBpbFN8x9TOnE0DB F7RKcA23D4a5pueAggJFBxjZNLfI27yynum/E/IPG12nxf3lTFIHnawe7VZFI3n05r Kq0IOuO/ec+BA== Date: Wed, 15 Apr 2026 09:17:08 +0200 From: Krzysztof Kozlowski To: Kaustabh Chakraborty Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , =?utf-8?B?QW5kcsOp?= Draszik , Alexandre Belloni , Jonathan Corbet , Shuah Khan , Nam Tran , =?utf-8?B?xYF1a2FzeiBMZWJpZWR6acWEc2tp?= , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v4 05/13] dt-bindings: mfd: s2mps11: add documentation for S2MU005 PMIC Message-ID: <20260415-notorious-dainty-starfish-58a13c@quoll> References: <20260414-s2mu005-pmic-v4-0-7fe7480577e6@disroot.org> <20260414-s2mu005-pmic-v4-5-7fe7480577e6@disroot.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260414-s2mu005-pmic-v4-5-7fe7480577e6@disroot.org> On Tue, Apr 14, 2026 at 12:02:57PM +0530, Kaustabh Chakraborty wrote: > Samsung's S2MU005 PMIC includes subdevices for a charger, an MUIC (Micro > USB Interface Controller), and flash and RGB LED controllers. > > Since regulators are not supported by this device, unmark this property > as required and instead set this in a per-device basis for ones which > need it. > > Add the compatible and documentation for the S2MU005 PMIC. Also, add an > example for nodes for supported sub-devices, i.e. charger, extcon, > flash, and rgb. > Limited review because this does not pass build checks. > Signed-off-by: Kaustabh Chakraborty > --- > .../devicetree/bindings/mfd/samsung,s2mps11.yaml | 121 ++++++++++++++++++++- > 1 file changed, 120 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml b/Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml > index ac5d0c149796b..d3d305b9aa765 100644 > --- a/Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml > +++ b/Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml > @@ -26,12 +26,28 @@ properties: > - samsung,s2mps15-pmic > - samsung,s2mpu02-pmic > - samsung,s2mpu05-pmic > + - samsung,s2mu005-pmic > > clocks: > $ref: /schemas/clock/samsung,s2mps11.yaml > description: > Child node describing clock provider. > > + charger: > + $ref: /schemas/power/supply/samsung,s2mu005-charger.yaml > + description: > + Child node describing battery charger device. > + > + extcon: You got comment to drop extcon naming. If this stays, it's muic for example. > + $ref: /schemas/extcon/samsung,s2mu005-muic.yaml > + description: > + Child node describing extcon device. > + > + flash: > + $ref: /schemas/leds/samsung,s2mu005-flash.yaml > + description: > + Child node describing flash LEDs. > + Please make it a separate binding file. > interrupts: > maxItems: 1 > > @@ -43,6 +59,11 @@ properties: > description: > List of child nodes that specify the regulators. > > + rgb: led > + $ref: /schemas/leds/samsung,s2mu005-rgb.yaml > + description: > + Child node describing RGB LEDs. > + > samsung,s2mps11-acokb-ground: > description: | > Indicates that ACOKB pin of S2MPS11 PMIC is connected to the ground so > @@ -63,7 +84,6 @@ properties: > required: > - compatible > - reg > - - regulators > > additionalProperties: false > > @@ -78,6 +98,8 @@ allOf: > regulators: > $ref: /schemas/regulator/samsung,s2mps11.yaml > samsung,s2mps11-wrstbi-ground: false > + required: > + - regulators > > - if: > properties: > @@ -89,6 +111,8 @@ allOf: > regulators: > $ref: /schemas/regulator/samsung,s2mps13.yaml > samsung,s2mps11-acokb-ground: false > + required: > + - regulators > > - if: > properties: > @@ -101,6 +125,8 @@ allOf: > $ref: /schemas/regulator/samsung,s2mps14.yaml > samsung,s2mps11-acokb-ground: false > samsung,s2mps11-wrstbi-ground: false > + required: > + - regulators > > - if: > properties: > @@ -113,6 +139,8 @@ allOf: > $ref: /schemas/regulator/samsung,s2mps15.yaml > samsung,s2mps11-acokb-ground: false > samsung,s2mps11-wrstbi-ground: false > + required: > + - regulators > > - if: > properties: > @@ -125,6 +153,8 @@ allOf: > $ref: /schemas/regulator/samsung,s2mpu02.yaml > samsung,s2mps11-acokb-ground: false > samsung,s2mps11-wrstbi-ground: false > + required: > + - regulators > > - if: > properties: > @@ -137,6 +167,18 @@ allOf: > $ref: /schemas/regulator/samsung,s2mpu05.yaml > samsung,s2mps11-acokb-ground: false > samsung,s2mps11-wrstbi-ground: false > + required: > + - regulators > + > + - if: > + properties: > + compatible: > + contains: > + const: samsung,s2mu005-pmic > + then: > + properties: > + samsung,s2mps11-acokb-ground: false > + samsung,s2mps11-wrstbi-ground: false > > examples: > - | > @@ -278,3 +320,80 @@ examples: > }; > }; > }; > + > + - | > + #include > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@3d { > + compatible = "samsung,s2mu005-pmic"; > + reg = <0x3d>; > + interrupt-parent = <&gpa2>; > + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; > + > + charger { > + compatible = "samsung,s2mu005-charger"; > + monitored-battery = <&battery>; > + > + port { > + charger_to_muic: endpoint { > + remote-endpoint = <&muic_to_charger>; graph between own nodes is pointless. Best regards, Krzysztof