From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 028713CB2F2 for ; Thu, 16 Apr 2026 13:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776347051; cv=none; b=H16j0pU4qxeB/D+Zi9Vfg4HPibRfhblCYx+SG32RGeZelWGrf6wbOuaRUNLsBoXjQOk10qvrLmGBbv30v1Z2doQHczTI/whHaq1dOlw9BLLbuLx/0wiUUoJbJlguVgMfOtkHcDogvAvGUwDoat5Uf8RmnqhOnej6qSymh1mRYRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776347051; c=relaxed/simple; bh=Vb2BjE43Rj7+B5nWp9dgRNQNG7l6Oph7RvS6ZEaJ7QQ=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=lqueJBVdoOU4c1jqQsgOWuYPDLou+QudOx0vNEzZmuc80qvyis2y6NmHeA99MZk/9lvr+rrhU8z715kxnaerXlo6sqQQxF83ni41cC5VyHeQXF6Xt7LgOgNeBkN+CpnZMq9XnK5rRguDDZg8WD2DLfwvxhESEFBwwxUP0DiJYL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PJH9CrUL; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PJH9CrUL" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-7b6ae2ea4a1so30526837b3.2 for ; Thu, 16 Apr 2026 06:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776347043; x=1776951843; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=U1Cj4R8nBBYaIsGoCFVXiPj3J3o46qtr7Y2+nHFPGus=; b=PJH9CrULMHMRp2wDjf2bfsZIb7I3ZL+ZhTVErbdCWEkNI3hWAdiKIj9lFDyik/z8uT ioDtXzEfn6s9jUYWiRg5N+15+DUHfKNrCvIjqCR3sIJL37QfK80JFoN97EBMtr5+mmJF 6EaNZX3k14Zzx5NtJKhBHdND2Lkb0f5rcTCKLXrNmnYHz8D5Dt731HjYaqa+fNAXhQVp cyimAp57JnSZZprh3LrpITbBTDqijma2O0yAnG27VqPQRwVt2+PHrvkEg+H0x/ckTpVk JXGxsiEnLmRVVG6KqvIn14jIx/+cPucPIguij5c7N1rSugFwVP0hKAd1HmfSTjlpOKlg P90Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776347043; x=1776951843; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U1Cj4R8nBBYaIsGoCFVXiPj3J3o46qtr7Y2+nHFPGus=; b=fyvmxbe1uoh2ZmnB9PAt2I1wwzVE1A+TmiH07PMf4F/M3+49eItrtxu5Xn5CRslC0v 9UgcIOx6GgUbeQkHUqpw9YLmnrdbmyFLDHET4U2uHrOWTwjkPTH4cYWyOFZT0N/ZDmCe 7GfbRoOcWGBUiOaSoYcA5mOVSfe21dWil4ec8G4hGiG4j0mD6smP1JzzUxVVSM9GtXUP xOVQVUu2PSYj1u32PENVRr9uZBIxwEE+nvCFiYiy9TN4YXZh30sYyA08F6sM2I0hhskx pfdU/rDhseLMd7+oeG+30gripUfOuA7AbNyWygDyDEjbTnGcIhDn4Im4L9AsivawmpbG Mk2A== X-Forwarded-Encrypted: i=1; AFNElJ/haRPsBJoPPBzOkr0IXC+zsL+5NLUGHG1bKGR/b0doIsgnp3yVjbzdBNxkjSaePe7QLFQiZ8qWDinK@vger.kernel.org X-Gm-Message-State: AOJu0YwtF5aQ+2uA8zEPuqU3b6yL2Ne4ceIgUkVqOgkO6SY7fTyFbzjU +4MOkgtNgemSQBtjejHwrBYe4N8Jz+TkZ4onx9EQY/9UOjgF6fWctmJ3 X-Gm-Gg: AeBDiesCXeaVk2g8HETOgUxXYSqXEa0QaM+8oTgZJInGt+fG6ewZiWivDgcFKL3r7Gk g7rGPz5yiTgVSbKn7Vca6RoF3O8/+wjPZTjqpjnCjupn9etuK97ilu8PSSbxx+JbC/kZ3fFrhiW 1cN/e/8pGsTnfqJIG8H4950lh43X8opNE7pOfqO1aaElC5ApJVb5IOccotMu8iAhUE3XbaekdqD o0HpfJPXFL7QqJhYZTmqKNFqaBl32QFfoBjLDPD/RMk2jojbd/1bibvJgHxHSX7ZKx+QVf+F7C4 RqkZJ9KKOdrbji0CP5iqlb36By4pubWHRWD/NZgIycfQc2s2IbYz3JAL1yK3nAwVEUcgKuHPv2l CeMN72vwqUSArZ+X0QdxkETgdlZSeIhc567f6i98xKuFHxDEUYjpfWa/0KjYU/uuNwzKnSX0BLe s6HKpaQ3ZlFRDteS9cKvErfhUdfQ== X-Received: by 2002:a05:690c:4990:b0:7b8:c19c:ee89 with SMTP id 00721157ae682-7b8c19cf5f3mr23684577b3.42.1776347042637; Thu, 16 Apr 2026 06:44:02 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7b76931854esm23363737b3.37.2026.04.16.06.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 06:44:01 -0700 (PDT) From: Erikas Bitovtas Subject: [PATCH RFC 00/10] media: qcom: venus: add MSM8939 support Date: Thu, 16 Apr 2026 16:43:47 +0300 Message-Id: <20260416-msm8939-venus-rfc-v1-0-a09fcf2c23df@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDE0Mz3dziXAtLY0vdstS80mLdorRk3WQDI9Nkk2Rzk7TEVCWgvoKi1LT MCrCZ0UpBbs5KsRDB4tKkrNTkEpBpSrW1APOsIyp6AAAA X-Change-ID: 20260416-msm8939-venus-rfc-c025c4c74fae To: Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?utf-8?q?Andr=C3=A9_Apitzsch?= , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.15.2 This patch series adds support for Venus on MSM8939. It is mostly similar to MSM8916 Venus, except it needs two additional cores to be powered on before it can start decoding. This patch series is marked as an RFC. Before submitting a non-RFC series, I would like to have some details clarified regarding how Venus works in order to improve and eventually upstream support for MSM8939. 1. In downstream, particularly in LA.BR.1.2.9.1_rb1.5, the buses for vcodec0 cores have only decoding bits enabled, as depicted by qcom,bus-configs property of qcom,msm-bus-clients children in qcom,vidc node. Do I understand correctly that these cores are only needed for decoding, and not for encoding? 2. Currently in device tree there is a video-decoder subnode for Venus node, however, for SDM845-v2 (and newer) chipsets, Venus does not use subnodes. Does this mean it should be dropped for MSM8939 as well? 3. MSM8939 supports HEVC decoding, however, as the patchset is written now, it does not work. It can be enabled, however, it will result in breakage of Venus for faulty MSM8916 firmwares, because the code disabling HEVC for HFI v1 needs to be removed, and as per commit c50cc6dc6c48 ("media: venus: hfi_parser: Ignore HEVC encoding for V1"), this would break support for some MSM8916 devices. What could be the best way to work around this? 4. To attach vcodec0 power domain list to dev_{dec,enc}, I had to move vdec_get and venc_get later in the probe. Should this be avoided, and is there a better way to attach vcodec power domains? There may be some other issues with this patchset - this is WIP code, so feedback is very appreciated. Thank you! Signed-off-by: Erikas Bitovtas --- André Apitzsch (4): media: dt-bindings: venus: Add qcom,msm8939 schema media: venus: core: Add msm8939 resource struct arm64: dts: qcom: msm8939: Add venus node arm64: dts: qcom: msm8939-longcheer-l9100: Enable venus node Erikas Bitovtas (6): media: venus: add pmdomains to the struct based on the purpose of cores arm64: dts: qcom: msm8939-asus-z00t: add Venus clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled media: venus: move getting vdec and venc for later media: qcom: venus: Move HFI v3 venc and vdec methods to HFI v1 media: venus: add power domain enable logic for Venus cores .../bindings/media/qcom,msm8939-venus.yaml | 104 ++++++++++++ arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts | 8 + .../boot/dts/qcom/msm8939-longcheer-l9100.dts | 8 + arch/arm64/boot/dts/qcom/msm8939.dtsi | 24 +++ drivers/clk/qcom/gcc-msm8939.c | 4 + drivers/media/platform/qcom/venus/core.c | 39 +++++ drivers/media/platform/qcom/venus/core.h | 8 + drivers/media/platform/qcom/venus/pm_helpers.c | 187 ++++++++++++++++++--- drivers/media/platform/qcom/venus/vdec.c | 12 +- drivers/media/platform/qcom/venus/venc.c | 12 +- 10 files changed, 374 insertions(+), 32 deletions(-) --- base-commit: 936c21068d7ade00325e40d82bfd2f3f29d9f659 change-id: 20260416-msm8939-venus-rfc-c025c4c74fae Best regards, -- Erikas Bitovtas