From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E707221D3E2; Thu, 16 Apr 2026 08:23:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776327807; cv=none; b=bv4S7zbaH5ypoiZUQzzGBy9rvGJ3UebUq4qi+j1EYnc7P1RiKDz0mdHFmSvzbAqkciNAmHraj8x47aURmwHieJOoDg2CI7T7G07ZijJi0xgsuNPq0FhlEZss62aPArQfEuLEUJK/AZVWpaAaShLsy6TfbBINCGR1RWxyZbQRYQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776327807; c=relaxed/simple; bh=7iqdeBf056Y8f773kiB5jg4IskAEOD5AHTuM5uEHn9w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LdhVPk+4nwDaxl2czFIgLL97r/4zUjXI1ADApEOy8/4LuXpnRdWTCxIe6LbzRurP/LlP25Hh+MoDza/znZ68JR7RhCxId/n89vVWpTQspbY1aLBnxzutU7Z9x8MwrF8iZ5BPZwikmcLl3m6Lr9Qo0ExNnNYlUCvAFcfUUfvZg78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VfWJyWSN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VfWJyWSN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C5CAC2BCAF; Thu, 16 Apr 2026 08:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776327806; bh=7iqdeBf056Y8f773kiB5jg4IskAEOD5AHTuM5uEHn9w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VfWJyWSNLcRI3mHfjJQ//U3Em9KSyrdWYhU9QmMbY93UEIe7NQtMni3n85pAdojFt Soq7/+JoRXmAAK/c2mUOIjouhPNidagBWaPcym9cn69N0Q61LLoOdn4NIgs4lZgqdy xkoZZZqOjFGIKFB8W5DXO/svEiuTwOPSU2kYMUnSdjHz3RCdcncuqN2Relso/0QZzH 94Y1oCK73QW3YlVFO+Dn4083Igd0QGR80mGvNz69wUa+fG+h4NZaL+3oWqMJV0wyV/ yNV85tEgdeDHmdxuIkmolxk3yRrj8CHa9JJ0TMlk5sVFM39VW8Vjj5G9xrVwTm0Qov XD42AdN5JOGQw== Date: Thu, 16 Apr 2026 10:23:24 +0200 From: Krzysztof Kozlowski To: Kaustabh Chakraborty Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , =?utf-8?B?QW5kcsOp?= Draszik , Alexandre Belloni , Jonathan Corbet , Shuah Khan , Nam Tran , =?utf-8?B?xYF1a2FzeiBMZWJpZWR6acWEc2tp?= , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v4 02/13] dt-bindings: leds: document Samsung S2M series PMIC RGB LED device Message-ID: <20260416-upbeat-archetypal-mantis-1ede48@quoll> References: <20260414-s2mu005-pmic-v4-0-7fe7480577e6@disroot.org> <20260414-s2mu005-pmic-v4-2-7fe7480577e6@disroot.org> <20260415-sensible-kiwi-of-argument-44d6ed@quoll> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Wed, Apr 15, 2026 at 11:00:16PM +0530, Kaustabh Chakraborty wrote: > On 2026-04-15 09:03 +02:00, Krzysztof Kozlowski wrote: > > On Tue, Apr 14, 2026 at 12:02:54PM +0530, Kaustabh Chakraborty wrote: > >> +description: | > >> + The Samsung S2M series PMIC RGB LED is a three-channel LED device with > >> + 8-bit brightness control for each channel, typically used as status > >> + indicators in mobile phones. > >> + > >> + This is a part of device tree bindings for S2M and S5M family of Power > >> + Management IC (PMIC). > >> + > >> + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for > >> + additional information and example. > >> + > >> +allOf: > >> + - $ref: common.yaml# > > > > Rob's comment is still valid: > > 1. How do you address one of three LEDs in non-RGB case? > > 2. Where is multi-color? > > Yes, multi-color should have been added here. > > > > > And based on this alone without other properties, I say this should be > > part of top-level schema. Separate node is fine, but no need for > > separate binding. > > BTW, for loading the sub-device driver via platform (as it won't be a > separate binding) the driver *must* be built-in. Although not related to > bindings, this seems counter-intuitive. I see the same problem with the I don't understand that comment. If it has nothing to do with the binding, what is the problem? Best regards, Krzysztof