Re: [PATCH v4 02/13] dt-bindings: leds: document Samsung S2M series PMIC RGB LED device

Krzysztof Kozlowski
2026-04-16T08:23:26Z

On Wed, Apr 15, 2026 at 11:00:16PM +0530, Kaustabh Chakraborty wrote:
> On 2026-04-15 09:03 +02:00, Krzysztof Kozlowski wrote:
> > On Tue, Apr 14, 2026 at 12:02:54PM +0530, Kaustabh Chakraborty wrote:
> >> +description: |
> >> + The Samsung S2M series PMIC RGB LED is a three-channel LED device with
> >> + 8-bit brightness control for each channel, typically used as status
> >> + indicators in mobile phones.
> >> +
> >> + This is a part of device tree bindings for S2M and S5M family of Power
> >> + Management IC (PMIC).
> >> +
> >> + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for
> >> + additional information and example.
> >> +
> >> +allOf:
> >> + - $ref: common.yaml#
> >
> > Rob's comment is still valid:
> > 1. How do you address one of three LEDs in non-RGB case?
> > 2. Where is multi-color?
>
> Yes, multi-color should have been added here.
>
> >
> > And based on this alone without other properties, I say this should be
> > part of top-level schema. Separate node is fine, but no need for
> > separate binding.
>
> BTW, for loading the sub-device driver via platform (as it won't be a
> separate binding) the driver *must* be built-in. Although not related to
> bindings, this seems counter-intuitive. I see the same problem with the

I don't understand that comment. If it has nothing to do with the
binding, what is the problem?

Best regards,
Krzysztof