From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DE23DF59 for ; Sat, 18 Apr 2026 14:47:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776523677; cv=none; b=smdmAInYIdGlXbmQlTBOoNnfjA6lGU9/nvY+33EYYBA0cWTauDO+ZJhU7cSbDR1e/I/QbdIwJgEK0bc1jibRzUgN5mQbAeVpUrv6MR23Wgjg5XUJtomabzsKm+1fm1+gCb8FS58aD3hrWcfaI1K7TOgJgf/fJD5R+eYdJ6XXulk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776523677; c=relaxed/simple; bh=l6nManMeR7Jg1MhkwUdhEH7FHLLqb5lCwS/P/91//S4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o0K4a1YH2EhV1hK+CR0JaDuWFomFDX4FycbcwLckOnHqxpmvH6XuYUAEw1AGp+Vrbv301noX7hgF4AsPhNaXaSW3Wq4IgRxJALe+Qe97oWVNgRxS9Imb1PL7RG34XEYIPBkFlRC8wqJ4gJPHlrqfcRagNJaetHoT206T8d03rq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HwX/3Dpa; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HwX/3Dpa" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-38e7b8e3f38so12890491fa.3 for ; Sat, 18 Apr 2026 07:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776523674; x=1777128474; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BjNK/Cg8+mI3iZeqCtPR1pHEgjWGhrHjIwJvfOxtDFI=; b=HwX/3DpampM+CMwhED1aecYg/VaICmqO9bw106y9Vw42qmuqKkHg/aZ3eTfmRy6UxS EdYjzv44WxovYglJ+muO6qBfy/bv1qEPgU2urnuM3pwWO7hjhjIMaoKHy1COtqH7SBoH EAToDzRq4edXme7kdhxYP30rwASQ+eo8T3qMbctuMTk4OI4VKn//6Uysey0//aEMZx7b lRBgKcAuRMm+e2GJIh/gL2Xh5K3YzpbI6bLaGlmSAW5Y6mjlcu03StySMyce9pG/DNVe YN5WysbE8B1Gw+IjU7UrXY3pWs5dcGY7xxCjC0EA+BtV+2DxIwhb2Gtbaib3Po2olVec dCYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776523674; x=1777128474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BjNK/Cg8+mI3iZeqCtPR1pHEgjWGhrHjIwJvfOxtDFI=; b=J6o8W/C7G4qwO1ia8DrK0o6FiJRpWRF+uatEvJGALMwQ8wFIx827OzxBAE7nHpHA2H 5pb3K3W2P70rMaxvwYDVNO2yavR+AP75nh8MvkZad14bKmHjM7cknVq2SiOTrO0bOoVM B+aIqyV9efzBpc7jNQoiuO4FobBl8R5AY31UJGoqr/2OwL14meXdxFkld00eV9BLJw2t RRLqzHe8buDQGipbfejbNqI7dAWCBIcpI6iywdMATEY+Uv4h1KcdE6ejr+wq7UC00AKh dPfbWlvsTmxYxC7092+I1hAYQyXRDIc9riQB+255Um7EktE71GSTec5rUvsOUOsa1Zd7 GYxw== X-Forwarded-Encrypted: i=1; AFNElJ/P9vBrKpekRyclv39UeoOGhe+/6yW8E2k359U/o87n8/nGRHnth1VPJDydxJc0CZwNf7bSFp7UkCoY@vger.kernel.org X-Gm-Message-State: AOJu0YzxR304XF/0CUlY7i6K3DoFWjzV+qgt/65utBYqNLkjbpo//BES hdPATr66tDHBSs94g2PxtytErH1ezpY64R36ZQJdfBAQSFdvIqLnfN2z X-Gm-Gg: AeBDieuy4naFj8nTjs2VXrMIBiDCMJaSF+ukhTvzy7AL9ZU8RxOtw3fpRtOZTjzsVu1 l2I2xtGFF2gKQTs1jRvOgRD+ZfWwbLtwKRgdFqIlKeOFIC1TnuSKzfcVEw1EWPZR1E/xU19NydH O4RmZDdxMpS2aFi1zHsPXDHoVbEhwgIbblwFuaORRPMOJLKSYftebXxUiyRJQNMS/WjLAp30EqL xltii/FJIfErEFgCnm9z85k8mOa7oaH6hEnSZN9pVphbJYSSJZQytBmQILjyFMTjv+U/2kqV523 RP49PDdqIplsipzys4emQrRTeBCMsg57vazW2utc0uVviet7SHNz7NcFmRLIGd2let1xoGqRncT gqBzxEr+3mz68OseQsZb+g460E/xdvH7XnIk2YVo7m0Y4bRvfjyBu+zikzVTLOgHX5g9P9k71RN mnoJc4Osbpvvr6eDlOIVhYIG8= X-Received: by 2002:a05:6512:1242:b0:5a4:640:9f07 with SMTP id 2adb3069b0e04-5a4172e7b8bmr2429015e87.31.1776523674389; Sat, 18 Apr 2026 07:47:54 -0700 (PDT) Received: from xeon ([188.163.112.56]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38ecb4f51easm10901001fa.6.2026.04.18.07.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2026 07:47:53 -0700 (PDT) From: Svyatoslav Ryhel To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Arnd Bergmann , Greg Kroah-Hartman , Svyatoslav Ryhel , Randy Dunlap Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 5/5] misc: apds990x: Drop IRQF_TRIGGER_LOW trigger Date: Sat, 18 Apr 2026 17:47:16 +0300 Message-ID: <20260418144716.132936-6-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260418144716.132936-1-clamor95@gmail.com> References: <20260418144716.132936-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Predefined IRQF_TRIGGER_LOW causes a conflict when setting triggers in the device tree node. Remove IRQF_TRIGGER_LOW from the interrupt; it can be specified in the device tree if needed. Signed-off-by: Svyatoslav Ryhel --- drivers/misc/apds990x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/apds990x.c b/drivers/misc/apds990x.c index 557c8476ea80..51037cdc2c47 100644 --- a/drivers/misc/apds990x.c +++ b/drivers/misc/apds990x.c @@ -1183,8 +1183,8 @@ static int apds990x_probe(struct i2c_client *client) } err = devm_request_threaded_irq(dev, client->irq, NULL, apds990x_irq, - IRQF_TRIGGER_FALLING | IRQF_TRIGGER_LOW | - IRQF_ONESHOT, "apds990x", chip); + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + "apds990x", chip); if (err) { dev_err(dev, "could not get IRQ %d\n", client->irq); goto error_pm; -- 2.51.0