Re: [PATCH v2 3/3] misc: Remove old APDS990x driver

Arnd Bergmann
2026-04-20T08:33:44Z

On Mon, Apr 20, 2026, at 10:21, Andy Shevchenko wrote:
> On Sun, Apr 19, 2026 at 05:22:16PM +0100, Jonathan Cameron wrote:
>> On Sun, 19 Apr 2026 16:41:24 +0300 Svyatoslav Ryhel <clamor95@gmail.com> wrote:
>> > нд, 19 квіт. 2026 р. о 16:33 Jonathan Cameron <jic23@kernel.org> пише:

>>
>> Their userspace will be broken by dropping it. The lack of upstream users
>> makes this less critical but it can be argued it's still a possible regression.
>
> Usual recommendation is to google, and check Debian code search engine.
> I randomly chose a couple of sysfs nodes and only kernel code refers to them.
> So, at least there is a good sign that it likely not in use. But one has
> to perform more checks (all attributes, more sources of information) and
> summarise that in the commit message.

I think in this case it's sufficient to point out that there is no
devicetree support in the driver, and no pre-DT board file ever
declared a platform_device with apds990x_platform_data in mainline
kernels. The ambient light sensor drivers in drivers/misc/ were
all added in before the change from boardfile to DT, and from custom
ABI to drivers/iio.

Arnd