Re: [PATCH v2 3/3] misc: Remove old APDS990x driver

Andy Shevchenko
2026-04-20T08:21:09Z

On Sun, Apr 19, 2026 at 05:22:16PM +0100, Jonathan Cameron wrote:
> On Sun, 19 Apr 2026 16:41:24 +0300
> Svyatoslav Ryhel <clamor95@gmail.com> wrote:
> > нд, 19 квіт. 2026 р. о 16:33 Jonathan Cameron <jic23@kernel.org> пише:
> > > On Sun, 19 Apr 2026 11:31:24 +0300
> > > Svyatoslav Ryhel <clamor95@gmail.com> wrote:

...

> > > There is the obvious point of ABI compatibility raised as well, but given
> > > we don't seem to be getting much push back on that maybe that's not a significant
> > > concern.
> >
> > I did not found any ABI in the Documentation/ABI regarding this sensor
> > using grep,

The code is what is in use, it has an ABI. The question if it's in use or not.

> > maybe you are more familiar?

> Doesn't matter if it's documented explicitly (many older drivers are not).
> The question is whether anyone has supported parts and userspace code that
> makes use of the sysfs files this driver provides.
>
> Their userspace will be broken by dropping it. The lack of upstream users
> makes this less critical but it can be argued it's still a possible regression.

Usual recommendation is to google, and check Debian code search engine.
I randomly chose a couple of sysfs nodes and only kernel code refers to them.
So, at least there is a good sign that it likely not in use. But one has
to perform more checks (all attributes, more sources of information) and
summarise that in the commit message.

--
With Best Regards,
Andy Shevchenko