Re: [PATCH v3 1/2] dt-bindings: bridge: This patch adds new content to the lontium,lt9611.yaml binding file

Krzysztof Kozlowski
2026-04-20T14:18:10Z

On 20/04/2026 16:15, Krzysztof Kozlowski wrote:
> On Mon, Apr 20, 2026 at 01:33:46PM +0200, Krzysztof Kozlowski wrote:
>>> -audio
>>> 1.sample rates of 32~192 KHz and sample sizes
>>> of 16~24 bits
>>> 2.SPDIF interface supports PCM, Dolbydigital, DTS digital audio
>>> at up to 192KHz frame rate
>>>
>>> -Miscellaneous
>>> 1.CSC:RGB<->YUV444<->YUV422
>>
>> Commit msg is not a datasheet introduction chapter. What does this all
>> mean for compatibility? What is the benefit of listing all this?
>>
>> You did not even explain the differences between C, UX and EXD, so all
>> above is pointless. Explain the differences and why devices are not
>> compatible.
>>
>
> Also, you have checkpatch errors.
>

... and finally (apologies for making it in three emails, checkpatch
warnings come from different toolset): your subject is pretty breaking
every standard rule.

It's redundant, not informative in various ways. It misses proper
prefix, it misses even basic description WHAT. Everything can be a "new
content".

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

Drop second/last, redundant "bindings". The "dt-bindings" prefix is
already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

And obviously "file" is pointless. Can you add content NOT to a file?
Like add it to a directory?

Best regards,
Krzysztof