From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from inva021.nxp.com (inva021.nxp.com [92.121.34.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59F0A39BFFA; Mon, 20 Apr 2026 11:02:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=92.121.34.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776682926; cv=none; b=WhT8ZWeELKFT8WHJP6ZyKTae4QIEWCNp9XkaoXc2aKY9bhxP6Zpdtney9zrBDwpxNkd8AuD2921iDI+ZA8Uv46PpK1CIRFqQ2yC73spaG+uo3HmDwLKptkyWvzkqqcM/RcX9pBapTL5eMatkPtfI6fvirfvBziYdmlVt0AnVp7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776682926; c=relaxed/simple; bh=Q3xt8NB+mEM7oyDj1T+TJ4cnk32JrzI3m4KxufDlBZU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ek7bJBSxVYrk/A7XBLmQS8ibqk3xXd58OD2XZYK2mDurydaF3CgnEViJ5E1kQ2a9qWybduwmxy2zBtv1zZ6B0iFc62yNm347wKjMhEH9a85cfi1VW5IgMj+til7gxYa0Kd6s8D9YfO8g5UGrhIk1PK6Vie2xo0jBXwmBaux9Iys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; arc=none smtp.client-ip=92.121.34.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 5625820030D; Mon, 20 Apr 2026 12:52:42 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 1EB1A20030B; Mon, 20 Apr 2026 12:52:42 +0200 (CEST) Received: from lsv03900.swis.in-blr01.nxp.com (lsv03900.swis.in-blr01.nxp.com [10.12.177.15]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id C2F481800086; Mon, 20 Apr 2026 18:52:40 +0800 (+08) From: Lakshay Piplani To: linux-kernel@vger.kernel.org, linux-i3c@lists.infradead.org, alexandre.belloni@bootlin.com, krzk+dt@kernel.org, robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, broonie@kernel.org, lee@kernel.org, Frank.Li@nxp.com, lgirdwood@gmail.com Cc: vikash.bansal@nxp.com, priyanka.jain@nxp.com, aman.kumarpandey@nxp.com, Lakshay Piplani Subject: [PATCH v9 2/7] i3c: master: Add the APIs to support I3C hub Date: Mon, 20 Apr 2026 16:22:17 +0530 Message-Id: <20260420105222.1562243-3-lakshay.piplani@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260420105222.1562243-1-lakshay.piplani@nxp.com> References: <20260420105222.1562243-1-lakshay.piplani@nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP From: Aman Kumar Pandey Add simple helpers to direct attach/detach I3C devices and two CCC helpers to check CCC support and send CCC commands. These additions prepare the master core for I3C hub support. 1) i3c_master_direct_attach_i3c_dev() 2) i3c_master_direct_detach_i3c_dev() 3) i3c_master_send_ccc_cmd() 4) i3c_master_supports_ccc_cmd() Signed-off-by: Aman Kumar Pandey Signed-off-by: Lakshay Piplani --- Changes in v9: - No change Changes in v8: - No change Changes in v7: - Update commit message to clarify purpose (prepare for I3C hub support) Changes in v6: - Split the patch into two parts: 1) expose the existing API 2) add new APIs. --- --- drivers/i3c/master.c | 103 +++++++++++++++++++++++++++++++++++++ include/linux/i3c/master.h | 8 +++ 2 files changed, 111 insertions(+) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index d11fe6937ba8..2b88021d8a23 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -1652,6 +1652,59 @@ static int i3c_master_attach_i3c_dev(struct i3c_master_controller *master, return 0; } +/** + * i3c_master_direct_attach_i3c_dev() - attach an I3C device to a master + * @master: I3C master controller to attach the device to + * @dev: I3C device descriptor representing the device + * + * This function attaches an I3C device to its master controller once the + * device has a valid address on the bus. Devices without + * an assigned address are ignored. The master device itself is never + * attached through this bus. + * + * Return: 0 on success, or a negative error code if the attach operation + * fails in the master controller driver. + */ +int i3c_master_direct_attach_i3c_dev(struct i3c_master_controller *master, + struct i3c_dev_desc *dev) +{ + int ret = 0; + + /* + * We don't attach devices to the controller until they are + * addressable on the bus. + */ + + if (!dev->info.static_addr && !dev->info.dyn_addr) + return -EINVAL; + + /* Do not attach the master device itself. */ + if (master->this != dev && master->ops->attach_i3c_dev) + ret = master->ops->attach_i3c_dev(dev); + + return ret; +} +EXPORT_SYMBOL_GPL(i3c_master_direct_attach_i3c_dev); + +/** + * i3c_master_direct_detach_i3c_dev - Detach an I3C device from its master + * @dev: I3C device descriptor to be detached + * + * This function detaches an I3C device from its master controller. + * It ensures that the master itself is not detached. If the device is not + * the master and the master controller provides a detach operation, + * the detach callback is invoked to perform the actual removal. + */ +void i3c_master_direct_detach_i3c_dev(struct i3c_dev_desc *dev) +{ + struct i3c_master_controller *master = i3c_dev_get_master(dev); + + /* Do not detach the master device itself. */ + if (master->this != dev && master->ops->detach_i3c_dev) + master->ops->detach_i3c_dev(dev); +} +EXPORT_SYMBOL_GPL(i3c_master_direct_detach_i3c_dev); + /** * i3c_master_reattach_i3c_dev() - reattach an I3C device with a new address * @dev: I3C device descriptor to reattach @@ -1816,6 +1869,56 @@ i3c_master_register_new_i3c_devs(struct i3c_master_controller *master) } } +/** + * i3c_master_supports_ccc_cmd() - check CCC command support + * @master: I3C master controller + * @cmd: CCC command to verify + * + * This function verifies whether the given I3C master controller supports + * the specified Common Command Code (CCC). + * + * Return: 0 if the CCC command is supported and executed successfully, + * -EINVAL if arguments are invalid, + * -EOPNOTSUPP if the master does not support CCC commands, + * or another negative error code from the master's operation. + */ +int i3c_master_supports_ccc_cmd(struct i3c_master_controller *master, + const struct i3c_ccc_cmd *cmd) +{ + if (!cmd || !master) + return -EINVAL; + + if (!master->ops->supports_ccc_cmd) + return -EOPNOTSUPP; + + return master->ops->supports_ccc_cmd(master, cmd); +} +EXPORT_SYMBOL_GPL(i3c_master_supports_ccc_cmd); + +/** + * i3c_master_send_ccc_cmd() - send a CCC command + * @master: I3C master controller issuing the command + * @cmd: CCC command to be sent + * + * This function sends a Common Command Code (CCC) command to devices on the + * I3C bus. It acquires the bus maintenance lock, executes the command, and + * then releases the lock to ensure safe access to the bus. + * + * Return: 0 on success, or a negative error code on failure. + */ +int i3c_master_send_ccc_cmd(struct i3c_master_controller *master, + struct i3c_ccc_cmd *cmd) +{ + int ret; + + i3c_bus_maintenance_lock(&master->bus); + ret = i3c_master_send_ccc_cmd_locked(master, cmd); + i3c_bus_maintenance_unlock(&master->bus); + + return ret; +} +EXPORT_SYMBOL_GPL(i3c_master_send_ccc_cmd); + /** * i3c_master_do_daa_ext() - Dynamic Address Assignment (extended version) * @master: controller diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h index aeccec171e64..c00f0918394c 100644 --- a/include/linux/i3c/master.h +++ b/include/linux/i3c/master.h @@ -615,6 +615,14 @@ DEFINE_FREE(i3c_master_dma_unmap_single, void *, int i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev, u8 old_dyn_addr); +int i3c_master_direct_attach_i3c_dev(struct i3c_master_controller *master, + struct i3c_dev_desc *dev); +void i3c_master_direct_detach_i3c_dev(struct i3c_dev_desc *dev); +int i3c_master_send_ccc_cmd(struct i3c_master_controller *master, + struct i3c_ccc_cmd *cmd); + +int i3c_master_supports_ccc_cmd(struct i3c_master_controller *master, + const struct i3c_ccc_cmd *cmd); int i3c_master_set_info(struct i3c_master_controller *master, const struct i3c_device_info *info); -- 2.25.1