Re: [PATCH 2/2] powerpc: Run typos -w

Krzysztof Kozlowski
2026-04-21T12:43:07Z

On 21/04/2026 14:36, Greg Kroah-Hartman wrote:
> On Tue, Apr 21, 2026 at 02:14:14PM +0200, Link Mauve wrote:
>> diff --git a/arch/powerpc/boot/dts/mpc8308_p1m.dts b/arch/powerpc/boot/dts/mpc8308_p1m.dts
>> index 41f917f97dab..48a98449ecbb 100644
>> --- a/arch/powerpc/boot/dts/mpc8308_p1m.dts
>> +++ b/arch/powerpc/boot/dts/mpc8308_p1m.dts
>> @@ -90,14 +90,14 @@ can@1,0 {
>> compatible = "nxp,sja1000";
>> reg = <0x1 0x0 0x80>;
>> interrupts = <18 0x8>;
>> - interrups-parent = <&ipic>;
>> + interrupts-parent = <&ipic>;
>> };
>>
>> cpld@2,0 {
>> compatible = "denx,mpc8308_p1m-cpld";
>> reg = <0x2 0x0 0x8>;
>> interrupts = <48 0x8>;
>> - interrups-parent = <&ipic>;
>> + interrupts-parent = <&ipic>;
>> };
>> };
>>
>
> Isn't this going to break a working system? If not, then was this dts
> file ever correct in the first place?

It looks DTS was not correct in the first place, but wrong property
probably did not matter, because parent node has it right. Still this is
beyond trivial language fix and should be a separate.

OTOH, interrupts-parent is clearly the wrong property. There is no such
thing.

Quoting commit msg:
"I have manually reviewed every single"

Clearly not true.

Best regards,
Krzysztof