Re: [PATCH v4 00/11] thermal: samsung: Add support for Google GS101 TMU

Alexey Klimov
2026-05-01T13:13:11Z

On Thu Apr 23, 2026 at 4:22 PM BST, Tudor Ambarus wrote:
> Add support for the Thermal Management Unit (TMU) on the Google GS101
> SoC.
>
> The GS101 TMU implementation utilizes a hybrid architecture where
> management is shared between the kernel and the Alive Clock and
> Power Manager (ACPM) firmware. This hybrid ACPM TMU architecture is
> also present on other Samsung Exynos SoCs (e.g., AutoV920, Exynos850).
>
> Dependencies
> ============
> - context dependency on the ACPM fixes sent at:
> Link: https://lore.kernel.org/linux-samsung-soc/20260423-acpm-fixes-sashiko-reports-v1-0-2217b790925e@linaro.org/T/#t
> - cleanup and prep firmware patches 2, 3, 4, 5, 6, 7: required by the
> thermal driver (patch 8).
> - bindings (patch 1): required for DTS validation.
> - thermal driver patch 8: required by defconfig (patch 11) - logical
> dependency.

I've took series locally using b4 and result doesn't compile:

CC [M] drivers/firmware/samsung/exynos-acpm.o
drivers/firmware/samsung/exynos-acpm.c:485:13: error: static declaration of ‘acpm_set_xfer’ follows non-static declaration
485 | static void acpm_set_xfer(struct acpm_xfer *xfer, u32 *cmd, size_t cmdcnt,
| ^~~~~~~~~~~~~
In file included from drivers/firmware/samsung/exynos-acpm.c:31:
drivers/firmware/samsung/exynos-acpm.h:20:6: note: previous declaration of ‘acpm_set_xfer’ with type ‘void(struct acpm_xfer *, u32 *, size_t, unsigned int, bool)’ {aka ‘void(struct acpm_xfer *, unsigned int *, long unsigned int, unsigned int, _Bool)’}
20 | void acpm_set_xfer(struct acpm_xfer *xfer, u32 *cmd, size_t cmdcnt,
| ^~~~~~~~~~~~~
drivers/firmware/samsung/exynos-acpm.c:485:13: warning: ‘acpm_set_xfer’ defined but not used [-Wunused-function]
485 | static void acpm_set_xfer(struct acpm_xfer *xfer, u32 *cmd, size_t cmdcnt,
| ^~~~~~~~~~~~~
make[5]: *** [scripts/Makefile.build:289: drivers/firmware/samsung/exynos-acpm.o] Error 1

(applies cleanly though).

Could be related to "[PATCH v4 02/11] firmware: samsung: acpm: Consolidate
transfer initialization helper".

Anything missing from dependencies/prerequisites?

[..]

> Tudor Ambarus (11):
> dt-bindings: thermal: Add Google GS101 TMU
> firmware: samsung: acpm: Consolidate transfer initialization helper
> firmware: samsung: acpm: Annotate rx_data->cmd with __counted_by_ptr
> firmware: samsung: acpm: Drop redundant _ops suffix in acpm_ops members
> firmware: samsung: acpm: Make acpm_ops const and access via pointer
> firmware: samsung: acpm: Add TMU protocol support
> firmware: samsung: acpm: Add devm_acpm_get_by_phandle helper
> thermal: samsung: Add Exynos ACPM TMU driver GS101
> MAINTAINERS: Add entry for Samsung Exynos ACPM thermal driver
> arm64: dts: exynos: gs101: Add thermal management unit
> arm64: defconfig: enable Exynos ACPM thermal support
>
> .../bindings/thermal/google,gs101-tmu-top.yaml | 68 +++
> MAINTAINERS | 8 +
> arch/arm64/boot/dts/exynos/google/gs101-tmu.dtsi | 136 +++++
> arch/arm64/boot/dts/exynos/google/gs101.dtsi | 18 +
> arch/arm64/configs/defconfig | 1 +
> drivers/clk/samsung/clk-acpm.c | 8 +-
> drivers/firmware/samsung/Makefile | 1 +
> drivers/firmware/samsung/exynos-acpm-dvfs.c | 20 +-
> drivers/firmware/samsung/exynos-acpm-pmic.c | 20 +-
> drivers/firmware/samsung/exynos-acpm-tmu.c | 240 +++++++++
> drivers/firmware/samsung/exynos-acpm-tmu.h | 28 ++
> drivers/firmware/samsung/exynos-acpm.c | 113 +++--
> drivers/firmware/samsung/exynos-acpm.h | 2 +
> drivers/mfd/sec-acpm.c | 6 +-
> drivers/thermal/samsung/Kconfig | 17 +
> drivers/thermal/samsung/Makefile | 2 +
> drivers/thermal/samsung/acpm-tmu.c | 547 +++++++++++++++++++++
> .../linux/firmware/samsung/exynos-acpm-protocol.h | 32 +-
> 18 files changed, 1195 insertions(+), 72 deletions(-)
> ---
> base-commit: 2e68039281932e6dc37718a1ea7cbb8e2cda42e6
> change-id: 20260113-acpm-tmu-27e21f0e2c3b
> prerequisite-change-id: 20260423-acpm-fixes-sashiko-reports-ae28b6ed5581:v1
> prerequisite-patch-id: 18d89d0e2bc0efe2cb366746ac4db36f4682f061
> prerequisite-patch-id: eb4f90add371877a1930c442c5464c4da7242889
> prerequisite-patch-id: 021cd1ee6d2b93f554dd5098cd1158977294dc41
> prerequisite-patch-id: b5da16b5c6d6731ea519ed68302fd52ce57c7ffa

Best regards,
Alexey