Re: [PATCH v2 03/13] gpu: host1x: Migrate to generic dma context bus

Greg Kroah-Hartman
2026-04-23T13:40:29Z

On Thu, Apr 23, 2026 at 06:59:32PM +0530, Vishnu Reddy wrote:
> --- a/include/linux/host1x.h
> +++ b/include/linux/host1x.h
> @@ -462,7 +462,7 @@ struct host1x_memory_context {
> struct pid *owner;
>
> struct device_dma_parameters dma_parms;
> - struct device dev;
> + struct device *dev;

Ah, nice try, but no. You can't use a "generic" device for this type of
thing (i.e. your dma context bus device), as that's not what this device
really is. Add the needed logic to the bus this real device lives on,
don't try to work around it.

thanks,

greg k-h