Re: [PATCH 2/2] ASoC: dt-bindings: drop redundant wakeup-source definitions

Krzysztof Kozlowski
2026-04-23T09:19:55Z

On Thu, Apr 23, 2026 at 11:28:31AM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> The 'wakeup-source' property already has its type defined in the core

TYPES. It is plural.

> schema. A number of sound binding files redundantly specify the
> 'type: boolean' and provide descriptions which only repeat the generic
> meaning of the property.
> Drop these redundant definitions and descriptions to clean up the binding
> files and rely on the core schema instead.
> No functional change intended.
>
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
> Documentation/devicetree/bindings/sound/dialog,da7219.yaml | 5 +----
> Documentation/devicetree/bindings/sound/realtek,rt5514.yaml | 4 +---
> 2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> index 19137abdba3e..fab37cd92e0d 100644
> --- a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> +++ b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> @@ -45,10 +45,7 @@ properties:
> - wakeup
> - irq
>
> - wakeup-source:
> - type: boolean
> - description:
> - Flag to indicate this device can wake system (suspend/resume).
> + wakeup-source: true

That's wrong. Commit msg is making here false statements that it is
redundant. I checked (and you should too!) and driver does clearly
device_property_read_bool() thus the property CANNOT be the second type.

Best regards,
Krzysztof