Re: [PATCH 06/22] dt-bindings: iio: dac: ad5686: rework on power supplies

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]

On Fri, Apr 24, 2026 at 08:35:51AM +0100, Rodrigo Alencar wrote:
> On 26/04/23 06:32PM, Conor Dooley wrote:
> > On Wed, Apr 22, 2026 at 03:45:40PM +0100, Rodrigo Alencar via B4 Relay wrote:
> > > From: Rodrigo Alencar <rodrigo.alencar@analog.com>
> > > 
> > > Add supplies for VDD, VLOGIC and VREF input voltage pins. The vcc-supply
> > > property is deprecated. Certain devices require vref-supply to be
> > 
> > Why is it deprecated? Is the naming incorrect?
> 
> Yes, vcc does not exist. It is also misleading as it may sound as the input
> power supply, but in fact it is being used a voltage reference for the DAC output,
> which has a proper name, vref.

Please put this information in the commit message.

>  
> > > available once an internal reference voltage is absent. Still, this patch
> > > does not add those as 'required' so that the ABI is not broken.
> 
> ...
> 
> > > +  vref-supply:
> > > +    description:
> > > +      Reference voltage supply. If not supplied the internal reference is used.
> > > +
> > >    vcc-supply:
> > > -    description: If not supplied the internal reference is used.
> > > +    deprecated: true
> > > +    description: Use vref-supply instead.
> 
> -- 
> Kind regards,
> 
> Rodrigo Alencar

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]