From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A055F3264E6; Fri, 24 Apr 2026 17:11:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777050697; cv=none; b=hB1tVKHPjtthyxPLOUu10Y7XB6ut4lIuDttkCeSLi69EVROhSCh5QI0sUCcg5TCelhF15kMXX3DahOSr7qDLC/Hgh3gb9R2t6pw9sRa06HJG581kZq6TDnrRlBWW2MsCPGeMpsIYVkq4VDKw3AoHnBZZic/DHrWzJ28lA3qL1pk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777050697; c=relaxed/simple; bh=xLZz4WC8Bo8u0efX2LWmkvpBmMfi9ZcfdInsNPrIn4A=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=M+VfwIjLuGmlM/qRXvSSCShasYpcx94RqrBZ9iaVOFPHw8oxuyxcyD0whM8Tdzvm9HRRbunxTOJdOgVjBG9dUhoxjooA4RLJLmDFbadNyqOFkzD+DGcph+DCuaAFM1e+R1DJ/smhSFfacoY+GF4Vk07Qf3ST41Lq2QflpnovqB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mWBg9CoY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mWBg9CoY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 923C8C19425; Fri, 24 Apr 2026 17:11:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777050697; bh=xLZz4WC8Bo8u0efX2LWmkvpBmMfi9ZcfdInsNPrIn4A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mWBg9CoYIa1d+e43erewy3MvCpQVOp7TUxQ+7W2m9+oGX7OlGF2kD3C2JQdQaWThG TcE0jz3jmfNwMopsEE74S2AS8ObuSicruj1fl/Bgd1MZh8YMG447wSdsuHCKqa49Sd oiNury1DOjrJ2hteAhPSKUluuiz9zIlyR/mm5s11J+XrTRH749Vzovf8cs8xD1kWUU ZZeAAB+PqogvTfiSw+Aq3qVUNdm0pmiGp1Fp4aWQXeFzoHeSCQSlGJyp95PzTV7XFU 4daqLy0k9ZhK8KRLAKJc007LH8b0/dU9+0RHFG91hKJNw+kXq6fB+KQ+wQPR51UgoX IMYC6Kj6QTQPg== Date: Fri, 24 Apr 2026 18:11:25 +0100 From: Jonathan Cameron To: Rodrigo Alencar <455.rodrigo.alencar@gmail.com> Cc: Rodrigo Alencar via B4 Relay , rodrigo.alencar@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Auchter , linux-hardening@vger.kernel.org, Lars-Peter Clausen , Michael Hennerich , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kees Cook , "Gustavo A. R. Silva" , Philipp Zabel Subject: Re: [PATCH 21/22] iio: dac: ad5686: add triggered buffer support Message-ID: <20260424181125.7df826eb@jic23-huawei> In-Reply-To: References: <20260422-ad5313r-iio-support-v1-0-ed7dca001d1b@analog.com> <20260422-ad5313r-iio-support-v1-21-ed7dca001d1b@analog.com> <20260423192714.04eaa55e@jic23-huawei> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 24 Apr 2026 10:20:43 +0100 Rodrigo Alencar <455.rodrigo.alencar@gmail.com> wrote: > On 26/04/23 07:27PM, Jonathan Cameron wrote: > > On Wed, 22 Apr 2026 15:45:55 +0100 > > Rodrigo Alencar via B4 Relay wrote: > > ... > > > > +static irqreturn_t ad5686_trigger_handler(int irq, void *p) > > > +{ > > > + struct iio_poll_func *pf = p; > > > + struct iio_dev *indio_dev = pf->indio_dev; > > > + struct iio_buffer *buffer = indio_dev->buffer; > > > + struct ad5686_state *st = iio_priv(indio_dev); > > > + const struct iio_chan_spec *chan; > > > + u16 val[AD5686_MAX_CHANNELS]; > > > > I may be wrong but I suspect the static analysers won't like the > > fact that only part of this is initialised and they can't > > tell how much of it is then used. We might need some sanity checks > > to keep them happy even though we know they will always be fine > > (branch predictors should quickly make them near cost free). > > will just add = { } to end, so it get initialized to zero: > > u16 val[AD5686_MAX_CHANNELS] = { }; > > > > + int ret, ch, i = 0; > > > + bool async_update; > > > + u8 cmd; > > > + > > > + ret = iio_pop_from_buffer(buffer, val); > > At somepoint we should probably add a sanity check on buffer size to that. > > nothing to be done here then, I suppose that should be an API-level change > for iio_pop_from_buffer(). > Exactly. One for another day :) J > > > + if (ret) > > > + goto out; >