From: Jonathan Cameron <jic23@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: "Ariana Lazar" <ariana.lazar@microchip.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example
Date: Fri, 24 Apr 2026 18:44:54 +0100 [thread overview]
Message-ID: <20260424184454.74c3e7be@jic23-huawei> (raw)
In-Reply-To: <20260422-magnitude-improve-0266ea916c36@spud>
On Wed, 22 Apr 2026 17:54:25 +0100
Conor Dooley <conor@kernel.org> wrote:
> On Wed, Apr 22, 2026 at 02:56:59PM +0300, Ariana Lazar wrote:
> > Change example reg value from 0 to 0x60 in order to use a valid I2C address
> >
> > Signed-off-by: Ariana Lazar <ariana.lazar@microchip.com>
> > ---
> > Changes in v2:
> > - drop fixes from commit message
> > - keep just the address fix
> > - Link to v1: https://lore.kernel.org/r/20260420-mcp47feb02-fix6-v1-1-ae1808fea11d@microchip.com
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> pw-bot: not-applicable
>
> This really should be in series with your other patches, so that
> Jonathan doesn't have to figure out which order they apply in.
There doesn't seem to be an order... Either order of this
or the next one is failing. I'll apply them by hand.
Too many things in flight so I'm keen to merge some stuff.
So please check result.
Applied.
>
> > ---
> > Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> > index d2466aa6bda2106a8b695347a0edf38462294d03..350e80e4dbe05dd10e3c6fb00f74d58c56c54bc8 100644
> > --- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> > +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> > @@ -280,9 +280,9 @@ examples:
> >
> > #address-cells = <1>;
> > #size-cells = <0>;
> > - dac@0 {
> > + dac@60 {
> > compatible = "microchip,mcp47feb02";
> > - reg = <0>;
> > + reg = <0x60>;
> > vdd-supply = <&vdac_vdd>;
> > vref-supply = <&vref_reg>;
> >
> >
> > ---
> > base-commit: d2a4ec19d2a2e54c23b5180e939994d3da4a6b91
> > change-id: 20260417-mcp47feb02-fix6-bd6694d84750
> >
> > Best regards,
> > --
> > Ariana Lazar <ariana.lazar@microchip.com>
> >
prev parent reply other threads:[~2026-04-24 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 11:56 [PATCH v2] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example Ariana Lazar
2026-04-22 16:54 ` Conor Dooley
2026-04-24 17:44 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260424184454.74c3e7be@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy@kernel.org \
--cc=ariana.lazar@microchip.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox