From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 661562D5432; Sat, 25 Apr 2026 09:58:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777111129; cv=none; b=kBAHFeajjCqYwIvv7cLw3k2v/3dtBR7naTGbqVCNjW24Ktn8u+4R7m6k8JTkN3bWHWvI2jl50s85arnDZGL3U8NXP/R3k4f+IPS0dqQscjgbNqv+KePLtL2ZKjT5IDvcKNgt4gqlggZ05UReTyjOIzfqeBfDSvzwmJf8Yx3Sj2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777111129; c=relaxed/simple; bh=aazaLXG8kSAJ5nNWCvS05sFQTG0KWyaoWFm3XFwT0qE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NTXoQOXHK3Tja2xzRv7CK+iwtqwvr6Hj+pcrIQQyUj0Jio38AmtZ7b0Dw/qMqVWOBLYShExIJP6aQXTiSGlxw/mZXKE2hBVnyca/dv7qQrjo2AhleEvtg5ui6/gyd9AjIiQlL0F9vbXwwkzlmI6ogIoobVhR4VceuvflFw3chfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mBUxTg39; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mBUxTg39" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59CA4C2BCB0; Sat, 25 Apr 2026 09:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777111129; bh=aazaLXG8kSAJ5nNWCvS05sFQTG0KWyaoWFm3XFwT0qE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mBUxTg39e9CZyczDYRqwGcgbPCh/BoMhGud0fopjSmq4R2Afd5tLXFscbvNuxc3hd 1OV0C6BGTSDPHkWYJE7ERJAfMnapL6dRWD2lqxi3XWY2MkyViqdc7WbG7H33RO0xlu 2zLYvjj5NMWbn3I75KSbOWy9V7HMIutompkR+h+pWBpA10Aoxae9TOmk4C+bTEMsPQ Qy4rdeCl2uAWGDcJVxRGxJ0MhNKvLtlgGaR57v1jUrScs1SwIbwlPqeWqRaZJKSNYG HIzrAWwdodtzkQlLWtI1zcwxZ2xccx/PO+CHK9smSdmYa2+U+K3MJaLJ4XeLzm/bXe dh7MqIUdG1IPw== Date: Sat, 25 Apr 2026 11:58:47 +0200 From: Krzysztof Kozlowski To: Lukas Timmermann Cc: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Sam Ravnborg , Douglas Anderson , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexandre Marquet Subject: Re: [PATCH 5/5] ARM: dts: exynos: Add display support for exynos5250-manta Message-ID: <20260425-eccentric-amiable-fossa-fa1cae@quoll> References: <20260423-manta-display-v1-0-196f80c5673a@timmermann.space> <20260423-manta-display-v1-5-196f80c5673a@timmermann.space> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260423-manta-display-v1-5-196f80c5673a@timmermann.space> On Thu, Apr 23, 2026 at 11:14:41PM +0200, Lukas Timmermann wrote: > Adds the necessary entries for panel and backlight as > well as the fimd controller. > > Signed-off-by: Alexandre Marquet > Signed-off-by: Lukas Timmermann > --- > arch/arm/boot/dts/samsung/exynos5250-manta.dts | 99 ++++++++++++++++++++++++++ > 1 file changed, 99 insertions(+) > > diff --git a/arch/arm/boot/dts/samsung/exynos5250-manta.dts b/arch/arm/boot/dts/samsung/exynos5250-manta.dts > index 76d3657eb22f..eb97a28ff4e3 100644 > --- a/arch/arm/boot/dts/samsung/exynos5250-manta.dts > +++ b/arch/arm/boot/dts/samsung/exynos5250-manta.dts > @@ -25,6 +25,29 @@ aliases { > mmc1 = &mmc_1; /* WiFi */ > }; > > + backlight: backlight { > + compatible = "pwm-backlight"; > + pwms = <&pwm 0 1000000 0>; > + > + brightness-levels = <2 255>; /* TODO */ > + num-interpolated-steps = <254>; /* TODO */ > + default-brightness-level = <102>; /* TODO */ > + post-pwm-on-delay-ms = <97>; /* TODO */ > + > + power-supply = <&backlight_reg>; > + enable-gpios = <&gpg0 5 GPIO_ACTIVE_HIGH>; > + > + pinctrl-0 = <&led_bl_reset &pwm0_out>; > + pinctrl-names = "default"; > + }; > + > + backlight_reg: regulator-backlight { > + compatible = "regulator-fixed"; > + regulator-name = "APS_EN_18V"; > + pinctrl-0 = <&aps_en_18v>; > + pinctrl-names = "default"; No enable GPIO? No voltage? > + }; > + > /* Voltage source unknown */ > bmp180_vdda_reg: regulator-bmp180-vdda { > compatible = "regulator-fixed"; > @@ -105,6 +128,28 @@ multi-led { > leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>; > }; > > + panel { > + compatible = "samsung,ltl101dl02-002"; > + > + backlight = <&backlight>; > + power-supply = <&panel_reg>; > + enable-gpios = <&gph1 7 GPIO_ACTIVE_HIGH>; > + pinctrl-0 = <&lcd_en>; > + pinctrl-names = "default"; > + no-hpd; > + > + port { > + panel: endpoint { > + remote-endpoint = <&dp_out>; > + }; > + }; > + }; > + > + panel_reg: regulator-panel { > + compatible = "regulator-fixed"; > + regulator-name = "LCD_EN"; That's incomplete. You should have at least voltage. > + }; > + > pwrseq: mmc1-pwrseq { > compatible = "mmc-pwrseq-simple"; > > @@ -146,10 +191,36 @@ &cpu1 { > cpu-supply = <&buck2_reg>; > }; > > +&dp { > + status = "okay"; > + > + samsung,color-space = <0>; > + samsung,color-depth = <1>; > + samsung,link-rate = <0x0a>; > + samsung,lane-count = <4>; > + samsung,dynamic-range = <0>; > + samsung,ycbcr-coeff = <0>; > + > + ports { > + port { > + dp_out: endpoint { > + remote-endpoint = <&panel>; > + }; > + }; > + }; > +}; > + > &ehci { > status = "disabled"; > }; > > +&fimd { > + status = "okay"; > + > + assigned-clocks = <&clock CLK_MOUT_FIMD1>, <&clock CLK_MOUT_VPLL>; > + assigned-clock-parents = <&clock CLK_MOUT_VPLL>; > +}; > + > &i2c_1 { > status = "okay"; > > @@ -396,6 +467,12 @@ ldo25_reg: LDO25 { > }; > }; > > +&mali { > + status = "okay"; > + > + mali-supply = <&buck4_reg>; > +}; > + > &mixer { > status = "okay"; > }; > @@ -489,6 +566,14 @@ wlan_irq: wlan-irq-pins { > }; > > &pinctrl_1 { > + aps_en_18v: aps-en-18v-pins { > + samsung,pins = "gph1-6"; > + samsung,pin-function = ; /* TODO */ TODO why? IOW, what are you missing here? Was this tested? TODO note can stay, but I would prefer to see short comment explaining why. Best regards, Krzysztof