From: Jonathan Cameron <jic23@kernel.org>
To: Antony Kurniawan Soemardi <linux@smankusors.com>
Cc: "Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
phone-devel@vger.kernel.org,
"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v4 0/4] iio: adc: qcom-pm8xxx-xoadc: add support for reading channel labels from DT
Date: Sun, 26 Apr 2026 14:21:37 +0100 [thread overview]
Message-ID: <20260426142137.61072daf@jic23-huawei> (raw)
In-Reply-To: <20260426-pm8xxx-xoadc-label-v4-0-0ec782362615@smankusors.com>
On Sat, 25 Apr 2026 20:39:06 +0000 (UTC)
Antony Kurniawan Soemardi <linux@smankusors.com> wrote:
> This series adds support for reading channel labels from the device tree
> in the Qualcomm PM8xxx XOADC driver, along with the corresponding DT
> updates for the PM8921 PMIC. Also removes the redundant error logs when
> reading values, as returning -EINVAL and -ETIMEDOUT are sufficient to
> report failures.
>
> This series also includes minor refactors such as remove redundant
> error logging and constifying pointers where applicable.
>
> Tested on Sony Xperia SP (PM8921):
> > cat /sys/bus/iio/devices/iio\:device0/in_voltage7_label
> usb_vbus
> > cat /sys/bus/iio/devices/iio\:device0/in_temp12_label
> ref_muxoff
> > sensors
> iio_hwmon-isa-0000
> Adapter: ISA adapter
> vbat: 267.86 V
> dcin: 4.82 kV
> ...
> chg_temp: +1071.4°C
>
> Note: the sensor readings above are incorrect due to pending calibration
> fixes are not included in this series. This patch only addresses label
> visibility. The values are expected to be wrong until the calibration
> fixes lands separately.
> ---
> Changes in v4:
> - Constify pointers in read operations
Whilst I can't say I care that much about whether we mark everything we
could const, it does no harm.
Applied patches 2-4 to the testing branch of iio.git. I'll rebase that
on rc1 once available and push out as togreg which linux-next will pick up.
Thanks,
Jonathan
next prev parent reply other threads:[~2026-04-26 13:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 20:39 [PATCH v4 0/4] iio: adc: qcom-pm8xxx-xoadc: add support for reading channel labels from DT Antony Kurniawan Soemardi
2026-04-25 20:39 ` [PATCH v4 1/4] ARM: dts: qcom: pm8921: add labels for ADC channels Antony Kurniawan Soemardi
2026-04-25 20:39 ` [PATCH v4 2/4] iio: adc: qcom-pm8xxx-xoadc: remove redundant error logs when reading values Antony Kurniawan Soemardi
2026-04-27 7:53 ` Andy Shevchenko
2026-04-25 20:39 ` [PATCH v4 3/4] iio: adc: qcom-pm8xxx-xoadc: constify pointers in read operations Antony Kurniawan Soemardi
2026-04-27 7:58 ` Andy Shevchenko
2026-04-25 20:39 ` [PATCH v4 4/4] iio: adc: qcom-pm8xxx-xoadc: add support for reading channel labels Antony Kurniawan Soemardi
2026-04-26 13:21 ` Jonathan Cameron [this message]
2026-04-26 13:24 ` [PATCH v4 0/4] iio: adc: qcom-pm8xxx-xoadc: add support for reading channel labels from DT Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260426142137.61072daf@jic23-huawei \
--to=jic23@kernel.org \
--cc=andersson@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@smankusors.com \
--cc=nuno.sa@analog.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox