From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5B3B361DCA; Sun, 26 Apr 2026 13:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777209884; cv=none; b=EZ2Y+nSCJU+ZyIgCAFiAlflHy7DfcDPoKBm+0AW8a2NWMt7YjEWLTY9Neb208Qcg1SGafd7YzLxlMDVlQOmiH+VNC4ELSujFR6ok8LD8xpZvxIjtCyP7ApsMjaNOyDem3C81jDkghJ+O0Cf/KW4kiVefvzguDFmGPbGyCrayHeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777209884; c=relaxed/simple; bh=nFBOyJnmtVWgeJ1x8PETIvoT2Rkk0GN/0bvqZOX2iMk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dR56wX+pdhxYT0Tx3z3cc2ivkWAfdYg3GCPCul16boVUortcykfqztU7ux8iXDzzmU+NlJQHCM2pXBJnI/xz4kKyDO3/uJG7frPY6U8J9GPrI/VNG/m0ErFNAWaWbOp8cd87lmKIiolHndqMy4J31QVNo7Q6Iq27jRWoTitUeFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UfJ1650U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UfJ1650U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4C5DC2BCAF; Sun, 26 Apr 2026 13:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777209884; bh=nFBOyJnmtVWgeJ1x8PETIvoT2Rkk0GN/0bvqZOX2iMk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UfJ1650Ubn22q1FmfUfZ6Kq16AzHRVqpeFHwyiw4KlNJd1aC8tlrUVb1UU0AX4Lh8 CzP1wfVCyDUPL883vRf5BDMQEchWBFIpb0hD0db4K3tVq4rt9WUwm/H6Gu1vr7Rp9x hlA89oO7ZgbmCtm/w9LYYrmqehKvWa9LCCAKVwtFh4ELhWP5Oq5/gIZO3Huojzp7+O Lww2okFjdkDHwSncYxl10+GCObKCpSt6mvqDTT3YeP7uT13aI7GJQJs3Aqnlzon5+J QwQNs2FS+NvF2ggLSGfgLQMSwnBilQuSfkZ7/Fl8XPJGO1L5u4L3abnW2qV4fNV8nj RYb2me4wZvJ8Q== Date: Sun, 26 Apr 2026 14:24:34 +0100 From: Jonathan Cameron To: Antony Kurniawan Soemardi Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, Konrad Dybcio , Dmitry Baryshkov Subject: Re: [PATCH v4 0/4] iio: adc: qcom-pm8xxx-xoadc: add support for reading channel labels from DT Message-ID: <20260426142434.08412f47@jic23-huawei> In-Reply-To: <20260426142137.61072daf@jic23-huawei> References: <20260426-pm8xxx-xoadc-label-v4-0-0ec782362615@smankusors.com> <20260426142137.61072daf@jic23-huawei> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 26 Apr 2026 14:21:37 +0100 Jonathan Cameron wrote: > On Sat, 25 Apr 2026 20:39:06 +0000 (UTC) > Antony Kurniawan Soemardi wrote: >=20 > > This series adds support for reading channel labels from the device tree > > in the Qualcomm PM8xxx XOADC driver, along with the corresponding DT > > updates for the PM8921 PMIC. Also removes the redundant error logs when > > reading values, as returning -EINVAL and -ETIMEDOUT are sufficient to > > report failures. > >=20 > > This series also includes minor refactors such as remove redundant > > error logging and constifying pointers where applicable. > >=20 > > Tested on Sony Xperia SP (PM8921): =20 > > > cat /sys/bus/iio/devices/iio\:device0/in_voltage7_label =20 > > usb_vbus =20 > > > cat /sys/bus/iio/devices/iio\:device0/in_temp12_label =20 > > ref_muxoff =20 > > > sensors =20 > > iio_hwmon-isa-0000 > > Adapter: ISA adapter > > vbat: 267.86 V > > dcin: 4.82 kV > > ... > > chg_temp: +1071.4=C2=B0C > >=20 > > Note: the sensor readings above are incorrect due to pending calibration > > fixes are not included in this series. This patch only addresses label > > visibility. The values are expected to be wrong until the calibration > > fixes lands separately. =20 >=20 > > --- > > Changes in v4: > > - Constify pointers in read operations =20 > Whilst I can't say I care that much about whether we mark everything we > could const, it does no harm. >=20 > Applied patches 2-4 to the testing branch of iio.git. I'll rebase that > on rc1 once available and push out as togreg which linux-next will pick u= p. >=20 Backed out as this constification results in masses of discarded const marking warnings given some of these are passed into core code that isn't marked up. Keep any constifying to stuff that is isolated to this driver. J > Thanks, >=20 > Jonathan >=20