From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF9262E5B21; Tue, 28 Apr 2026 06:01:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777356082; cv=none; b=RO9l0TBoDmOR9jeXXzVf6Nt7rjlO/wQEjDuohLX+0dyuMNIfXoJLx9hiTWce9cgiR22SXeQrKJo7tX2ZQyeCa4ueUQoqUuKY/fTtcjJES9SAgwr8aiREug9QoX3JMxcFUM++o3Pj4YGr1BZLgc7XjNxMiY6ctKaAHnEwfuJbfy8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777356082; c=relaxed/simple; bh=v+Mvyg673DGKe6yZoQGc06NZvj6FBFDVdJZxb9VZvp0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=unyFJco+KWlUHGTAOqb3V8qQHUdH2UbRq9K3DzYtacbObtUOEx3z2TJOqiRcFjAqZ0/DyxQAPzfHDx7eFHrzxbSvzVR4uNLUZrjUeMwQlSoHS7iiYgWiOsHpEYZ6xW0soJyTfgLi3kcGzCRAQnP/EsYiuIQ+7Ki6mZ+tjHbg8vU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UjJk8EXv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UjJk8EXv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDD5DC2BCB3; Tue, 28 Apr 2026 06:01:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777356082; bh=v+Mvyg673DGKe6yZoQGc06NZvj6FBFDVdJZxb9VZvp0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UjJk8EXvGr0ICYCP8O6OFJfrzepw9yAcxWFLWskVCg/oNHJx9yvw/DLeByg00NCMq U4PZ/9+TriUhRn9ckLUTSIdjnzHtwRoGuA4cyTfQWGbVKcsKg6IAXy0F5rMcD7wPSN xJRcD9TDIYIOoFYY86Hns8WR7XMuIykpYTnl/iStYxceB8Mb4+8QylicX2cY60ZbGy Nyzk6tOMMtXD/Z681cQDlnT5QYDoWJhnCZdJlWcsG3nJJrenIA8Hrgg1LsDia3c1fR b2Y97E62vhS+UYUHD4xdxouGAwghIxcFEoZxe175QhITtpwZdoU37pk4Fiq5TvdvNj rgot+0K/xlujA== Date: Tue, 28 Apr 2026 08:01:19 +0200 From: Krzysztof Kozlowski To: Kaustabh Chakraborty Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Sebastian Reichel , =?utf-8?B?QW5kcsOp?= Draszik , Alexandre Belloni , Jonathan Corbet , Shuah Khan , Nam Tran , =?utf-8?B?xYF1a2FzeiBMZWJpZWR6acWEc2tp?= , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v5 03/11] dt-bindings: mfd: add documentation for S2MU005 PMIC Message-ID: <20260428-fortunate-olive-asp-fe4f53@quoll> References: <20260424-s2mu005-pmic-v5-0-fcbc9da5a004@disroot.org> <20260424-s2mu005-pmic-v5-3-fcbc9da5a004@disroot.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260424-s2mu005-pmic-v5-3-fcbc9da5a004@disroot.org> On Fri, Apr 24, 2026 at 01:09:02AM +0530, Kaustabh Chakraborty wrote: > Samsung's S2MU005 PMIC includes subdevices for a charger, an MUIC (Micro > USB Interface Controller), and flash and RGB LED controllers. > > Add the compatible and documentation for the S2MU005 PMIC. Also, add an > example for nodes for supported sub-devices, i.e. MUIC, flash LEDs, and > RGB LEDs. Charger sub-device uses the node of the parent. > > Signed-off-by: Kaustabh Chakraborty > --- > .../bindings/mfd/samsung,s2mu005-pmic.yaml | 120 +++++++++++++++++++++ > 1 file changed, 120 insertions(+) \r> > diff --git a/Documentation/devicetree/bindings/mfd/samsung,s2mu005-pmic.yaml b/Documentation/devicetree/bindings/mfd/samsung,s2mu005-pmic.yaml > new file mode 100644 > index 0000000000000..0e6afb7d2017b > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/samsung,s2mu005-pmic.yaml > @@ -0,0 +1,120 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/samsung,s2mu005-pmic.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung S2MU005 Power Management IC > + > +maintainers: > + - Kaustabh Chakraborty > + > +description: | > + The S2MU005 is a companion power management IC which includes subdevices for > + a charger controller, an MUIC (Micro USB Interface Controller), and flash and > + RGB LED controllers. > + > +allOf: > + - $ref: /schemas/power/supply/power-supply.yaml# > + > +properties: > + compatible: > + const: samsung,s2mu005-pmic > + > + flash: > + $ref: /schemas/leds/samsung,s2mu005-flash.yaml > + description: > + Child node describing flash LEDs. > + > + interrupts: > + maxItems: 1 > + > + muic: > + $ref: /schemas/extcon/samsung,s2mu005-muic.yaml# > + description: > + Child node describing MUIC device. > + > + multi-led: > + type: object > + > + allOf: > + - $ref: /schemas/leds/leds-class-multicolor.yaml# > + > + properties: > + compatible: > + const: samsung,s2mu005-rgb > + > + required: > + - compatible > + > + unevaluatedProperties: false > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@3d { > + compatible = "samsung,s2mu005-pmic"; > + reg = <0x3d>; > + interrupt-parent = <&gpa2>; > + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; > + > + monitored-battery = <&battery>; > + > + flash { > + compatible = "samsung,s2mu005-flash"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@0 { > + reg = <0>; > + color = ; > + function = LED_FUNCTION_FLASH; > + }; > + > + led@1 { > + reg = <1>; > + color = ; > + function = LED_FUNCTION_FLASH; > + function-enumerator = <1>; > + }; > + }; > + > + muic { > + compatible = "samsung,s2mu005-muic"; > + > + connector { > + compatible = "usb-b-connector"; > + label = "micro-USB"; > + type = "micro"; > + }; > + > + port { > + muic_to_usb: endpoint { > + remote-endpoint = <&usb_to_muic>; > + }; > + }; > + }; > + > + multi-led { > + compatible = "samsung,s2mu005-rgb"; > + color = ; > + function = LED_FUNCTION_INDICATOR; > + linux,default-trigger = "pattern"; > + }; > + }; > + }; > > -- > 2.53.0 >