Re: [PATCH v3 02/12] dt-bindings: media: qcom,glymur-iris: Add glymur video codec

Krzysztof Kozlowski
2026-04-28T06:14:52Z

On Tue, Apr 28, 2026 at 09:24:08AM +0530, Vishnu Reddy wrote:
> Add device tree binding for the Qualcomm Glymur Iris video codec. Glymur
> is a new generation of video IP that introduces a dual-core architecture.
> The second core brings its own power domain, clocks, and reset lines,
> requiring additional power domains and clocks in the power sequence.
>
> To accommodate glymur clock and power resources requirement, the maxItems
> constraints in qcom,venus-common.yaml are relaxed. This allows the glymur

This is a very confusing part of commit msg. You cannot relax the
constraints. Each device MUST have a specific, fixed constraint. It is
your task to be sure they are not relaxed.

> binding to inherit from the common venus schema without duplicating shared
> properties.

That's obvious. Why would new iris device schema not use common venus
schema? What is different here then that such possibility exists?

Best regards,
Krzysztof