From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 613F9410D21 for ; Wed, 29 Apr 2026 17:02:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777482125; cv=none; b=thUxRxZ6ZUU1/qKsNauseILMwdkBZ36VP/XwXhdhbVJGHHK+TAIKiSVGb0tkqnErAJAbfJH/nyOy00mzdjPn9PhJfgszsLf6LPLFZgGeqXji7lO1OrFSDJ5zkEhiJRnodt6FMaZdcCznkwVNB9dGtvUEGkkCtKbxynU1+gaOy2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777482125; c=relaxed/simple; bh=ovZTqUF5/g2sWp/btJDRSg/I1HuohA0bLfF+dYDDAN4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t2SBIQNbJFUoh5mm/m9nH4sMdNf0/ESd5PkNLuoSJJQoGyQQxLLcd/zA3r98n9+fNGCIJyi3X0LknkA6vIxWsI9JEPAgsWKS7V69J2QSZ0giD6ORiQb5lj0zmXPtFRH2kyelwIzrOt64inaXBbjVnhBPWanJrR3kKImLT+tu+a4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZCAbOsSh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HFmrMLOa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZCAbOsSh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HFmrMLOa" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63TFHCDI2094140 for ; Wed, 29 Apr 2026 17:02:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= j2Ivexwz+aHyP4Wah8ZSNwaKmGZD+PrFeXoflq99gDE=; b=ZCAbOsSh7jJfTWXJ YLq4yNxSyUKwYAnssN7pkdn5VXZlAxirYKuC/baaSghDv+96VC4QYsDXFx5ccyVy Z8WxtVSL74b/Ik2c7m165qfS8EHCNpbD91BBuG9X5qRpF0U3MEQ+r8zhukvcCZEM XULEqcO8TExlQdzL7vIqcUpU8eU5fYqdXBwkAqp1ti+U3uLz0NKOHIOUIVR9y4NT q8mzDTgRVdM4feTpL2CBrFTdgjIt2oJ38spRr3ueuc93gGXHtiZ+LY0mp0XODbsp Px5UGPqVuJZKKUICNciraysJTPrAzhnt9AAJf4bE0xiBiZnoAkmdhyqAGrq3Jyxp AFsNAQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dudh3tdet-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Apr 2026 17:02:00 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b241be0126so50495ad.3 for ; Wed, 29 Apr 2026 10:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777482119; x=1778086919; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j2Ivexwz+aHyP4Wah8ZSNwaKmGZD+PrFeXoflq99gDE=; b=HFmrMLOakOPIvIXrZZ7Yh6XHNKhLLkLjE3xXKe+F5jp4U1qbDls/9f6mxCe/Ysic9F /YKocdh6+dXqGEHDP0VqP3iBouH6kAp3VM4F1v7ZOtuOSOqC41i0Z3qGtYIH4XTpsAvM 6QeGDxzu30Psn2I2CZLB7XRUwddBUNLck6wPkT4RQkQZVleIZ9cPqyIEAqIjeJbT52GZ dMFrOC+RC+mqXjupJ7I8U5cKVTnkR4x9WMqQhAssPaj0bke/5ongYVWhOOODsG+4O06c fmeyV/lDtnnPlQ774/pxfkYzF75RocdijdBK7q4v8aSkZctWLEjtc2hzq6OHMub7++gT o5Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777482119; x=1778086919; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j2Ivexwz+aHyP4Wah8ZSNwaKmGZD+PrFeXoflq99gDE=; b=e+hJ1p2kIfrEe3RLghv3q2VklBTI3Fo2qL8h9RsL7wbqa/o9qZNURrlb7NyzUrFcIo /g+zVveBfbx5L/gnrtKSAChKlO5UN3S0BX6nh2TzCFPguoQsT4knVniD1r+JNIZrh7tQ QFF5TcZSd40eRVZ9wCjsKJwazf6Uo0cLVlB09qAvg2r5KlZ8RsBlFpecPVyHviDWxQD5 YhJlReT4NYXSusHhMj1+3AHMMatwnPDYKG3i25lREYdNSsn0dNhhrz/Hg7JS+BJAP92E f5aEkiJaCJcz3SfGVkVWh9dqPnvJiur8zVvJZ4R1Ut6rBVFxyJRWaSY7zTOvHlTNFEko VeDw== X-Forwarded-Encrypted: i=1; AFNElJ868MEq4n4aiRj5P2g7Q4Zwrhu7YLEAhAw67B2VOjbsyyQ4fOGHQOpViQyMjzF0Ofa0yrg4oOq+Behq@vger.kernel.org X-Gm-Message-State: AOJu0YwXF3OcfZDcfrvUrb9EyYvrnpik4gpnK5UbN3Gon83jSlRKECm1 wr/5OztaC8xPWGnv/XtezKTA4Z2ic2MNSnUr/ZH0Y5tFjAaHP61yBRkDy6o9KcfHpBk2eXNhvVl s8Q+pK6UyPcVKzGUvjNP9oqOTr3tQekg4R0ZjDem4bq8RC52EyA+JKQUnG4E2PQJP X-Gm-Gg: AeBDievWx9yHDPqnLT5CGj5ZuAKOZf0Qf8ONYeC01SQ/Hh1TTCVOfYDO85cynE+H672 Do/VO0Y8Km0dtXNaBrfgi+7tZmmOj4m0BnbDssUCSVCK0W8eHpQl0pqdtAYQpvnwNn3FxdZvlfA ExRfB/rZqNehh8E7+qoWF/+tYYmITUvFJgVQPfoA1QqnMBPHzKTPj8wrVAhzDYXqry11kucm8uM w8jEg7r5l3XaJbYfdSq1ng7smEFbaFtzcL79jaZ1FzWBqH1uSU1szaA2KLajZMLRKJMf0pKXije BHj+Gu0+0f5Gi6uRDl+GyJK4L7t3mc1xY78zEpNKxs6kF4KuhHK4JAZPZDcKuC5JOE/GUrtBoKf HwEqUl33bETyu7eMFMnm+myhJ4aW6JBybwZ0MT6PeXjWi8T8rghW0CUb1G0i8iTdmRvWo X-Received: by 2002:a17:902:c407:b0:2b4:5dad:2523 with SMTP id d9443c01a7336-2b9874c7e78mr50152355ad.35.1777482119102; Wed, 29 Apr 2026 10:01:59 -0700 (PDT) X-Received: by 2002:a17:902:c407:b0:2b4:5dad:2523 with SMTP id d9443c01a7336-2b9874c7e78mr50151905ad.35.1777482118618; Wed, 29 Apr 2026 10:01:58 -0700 (PDT) Received: from hu-vdadhani-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9887853a2sm29530195ad.18.2026.04.29.10.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 10:01:58 -0700 (PDT) From: Viken Dadhaniya Date: Wed, 29 Apr 2026 22:31:38 +0530 Subject: [PATCH v5 3/7] spi: spi-qcom-qspi: Add interconnect support for memory path Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260429-spi-nor-v5-3-993016c9711e@oss.qualcomm.com> References: <20260429-spi-nor-v5-0-993016c9711e@oss.qualcomm.com> In-Reply-To: <20260429-spi-nor-v5-0-993016c9711e@oss.qualcomm.com> To: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Viken Dadhaniya X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1777482100; l=4235; i=viken.dadhaniya@oss.qualcomm.com; s=20260324; h=from:subject:message-id; bh=ovZTqUF5/g2sWp/btJDRSg/I1HuohA0bLfF+dYDDAN4=; b=gxL6mgFY9dV5rNFOJLIQhaOWze1XUs8hM9+PuUYaer8dRy2UUpam/lQMrxLEUEJ6cbpTjMR7a q5PyTtqplVICwNR4yie4D4+2ZKbrF18vn6OuOlJXU5aBvkJaUThiPAq X-Developer-Key: i=viken.dadhaniya@oss.qualcomm.com; a=ed25519; pk=C39f+LOIGhh/02LQpT46TsUSXRvBn9qXC8Xb26KJ44Y= X-Proofpoint-GUID: mOvUyz8MVAiTml9gSVRzwn27yGky0Az5 X-Authority-Analysis: v=2.4 cv=A4dc+aWG c=1 sm=1 tr=0 ts=69f23988 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=S70kITjG2mzSNXz8RO8A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: mOvUyz8MVAiTml9gSVRzwn27yGky0Az5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI5MDE3MSBTYWx0ZWRfX0gUQgoBQPV6Q v2IudJVBa+DWxT5etZCiWAGtnDQpRoe3M6Db66I6g3Onx63XR+J5Bei8LTwBORLLc94oGQh6pjk e4Qre7YnKbIq1hjJ2t9877H944kjri2qfEwbhnHAGdvppGWUt5ChNK38E+K7pfs2hK5w/EyY/N8 HAPt5W6ui8LPe6SFeyU1UU8j11VgkV0dk1gjIbl0D2DrRdHvIGxJgnKW0XFEnl9xNTlF77uqXcz JVAQvHADLIBmRq5a1uxJvgqdMZ3A7u7JjhdfCHPzMHeAxyARlP7VI/tiGI1PQvQPec2R3gBQ6UA /XbszyMNz/LcBAVmmYEbjujAucFE309PF2sjhR264ODMzSgvXpoggIA46PZVnAhf7uE6x2fFM8Q KuszQli4bqdpXnqynHbIXfJOn3OL6blU8lkUpWbvUiCROhdtIOpCOVmSQ3ZPBlU3QA6N19Yh5/S 1VEGoMDowuLQQ9xbWWg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-29_01,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604290171 The QSPI controller has two interconnect paths: 1. qspi-config: CPU to QSPI controller for register access 2. qspi-memory: QSPI controller to memory for DMA operations Currently, the driver only manages the qspi-config path. Add support for the qspi-memory path to ensure proper bandwidth allocation for QSPI data transfers to/from memory. Enable and disable both paths during runtime PM transitions. Signed-off-by: Viken Dadhaniya --- drivers/spi/spi-qcom-qspi.c | 44 ++++++++++++++++++++++++++++++++++++++------ 1 file changed, 38 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index edfbf0b5d1fa..caf55a6f70b3 100644 --- a/drivers/spi/spi-qcom-qspi.c +++ b/drivers/spi/spi-qcom-qspi.c @@ -174,6 +174,7 @@ struct qcom_qspi { void *virt_cmd_desc[QSPI_MAX_SG]; unsigned int n_cmd_desc; struct icc_path *icc_path_cpu_to_qspi; + struct icc_path *icc_path_mem; unsigned long last_speed; /* Lock to protect data accessed by IRQs */ spinlock_t lock; @@ -272,7 +273,7 @@ static void qcom_qspi_handle_err(struct spi_controller *host, static int qcom_qspi_set_speed(struct qcom_qspi *ctrl, unsigned long speed_hz) { int ret; - unsigned int avg_bw_cpu; + unsigned int avg_bw_cpu, avg_bw_mem; if (speed_hz == ctrl->last_speed) return 0; @@ -285,7 +286,7 @@ static int qcom_qspi_set_speed(struct qcom_qspi *ctrl, unsigned long speed_hz) } /* - * Set BW quota for CPU. + * Set BW quota for CPU and memory paths. * We don't have explicit peak requirement so keep it equal to avg_bw. */ avg_bw_cpu = Bps_to_icc(speed_hz); @@ -296,6 +297,13 @@ static int qcom_qspi_set_speed(struct qcom_qspi *ctrl, unsigned long speed_hz) return ret; } + avg_bw_mem = Bps_to_icc(speed_hz); + ret = icc_set_bw(ctrl->icc_path_mem, avg_bw_mem, avg_bw_mem); + if (ret) { + dev_err(ctrl->dev, "ICC BW voting failed for memory: %d\n", ret); + return ret; + } + ctrl->last_speed = speed_hz; return 0; @@ -729,6 +737,14 @@ static int qcom_qspi_probe(struct platform_device *pdev) return dev_err_probe(dev, PTR_ERR(ctrl->icc_path_cpu_to_qspi), "Failed to get cpu path\n"); + ctrl->icc_path_mem = devm_of_icc_get(dev, "qspi-memory"); + if (IS_ERR(ctrl->icc_path_mem)) { + if (PTR_ERR(ctrl->icc_path_mem) != -ENODATA) + return dev_err_probe(dev, PTR_ERR(ctrl->icc_path_mem), + "Failed to get memory path\n"); + ctrl->icc_path_mem = NULL; + } + /* Set BW vote for register access */ ret = icc_set_bw(ctrl->icc_path_cpu_to_qspi, Bps_to_icc(1000), Bps_to_icc(1000)); @@ -827,9 +843,15 @@ static int __maybe_unused qcom_qspi_runtime_suspend(struct device *dev) goto err_enable_clk; } + ret = icc_disable(ctrl->icc_path_mem); + if (ret) { + dev_err_ratelimited(ctrl->dev, "ICC disable failed for memory: %d\n", ret); + goto err_enable_icc_cpu; + } + ret = pinctrl_pm_select_sleep_state(dev); if (ret) - goto err_enable_icc; + goto err_enable_icc_mem; /* Drop the performance state vote */ ret = dev_pm_opp_set_rate(dev, 0); @@ -840,7 +862,9 @@ static int __maybe_unused qcom_qspi_runtime_suspend(struct device *dev) err_select_default_state: pinctrl_pm_select_default_state(dev); -err_enable_icc: +err_enable_icc_mem: + icc_enable(ctrl->icc_path_mem); +err_enable_icc_cpu: icc_enable(ctrl->icc_path_cpu_to_qspi); err_enable_clk: if (clk_bulk_prepare_enable(QSPI_NUM_CLKS, ctrl->clks)) @@ -869,13 +893,21 @@ static int __maybe_unused qcom_qspi_runtime_resume(struct device *dev) goto err_select_sleep_state; } + ret = icc_enable(ctrl->icc_path_mem); + if (ret) { + dev_err_ratelimited(ctrl->dev, "ICC enable failed for memory: %d\n", ret); + goto err_disable_icc_cpu; + } + ret = clk_bulk_prepare_enable(QSPI_NUM_CLKS, ctrl->clks); if (ret) - goto err_disable_icc; + goto err_disable_icc_mem; return 0; -err_disable_icc: +err_disable_icc_mem: + icc_disable(ctrl->icc_path_mem); +err_disable_icc_cpu: icc_disable(ctrl->icc_path_cpu_to_qspi); err_select_sleep_state: pinctrl_pm_select_sleep_state(dev); -- 2.34.1