From: Krzysztof Kozlowski <krzk@kernel.org>
To: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
Cc: linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series
Date: Wed, 29 Apr 2026 08:28:57 +0200 [thread overview]
Message-ID: <20260429-steadfast-acoustic-degu-baebee@quoll> (raw)
In-Reply-To: <1777374569-59233-3-git-send-email-zaixiang.xu.dev@gmail.com>
On Tue, Apr 28, 2026 at 07:09:27PM +0800, Zaixiang Xu wrote:
> Add YAML devicetree binding schema for Sensirion SHT30 series and the
> compatible GXCAS GXHT30 sensors.
>
> Use fallback compatibles for compatible chips and add optional
> interrupts and vdd-supply properties.
>
> Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@gmail.com>
> ---
> .../bindings/hwmon/sensirion,sht30.yaml | 67 +++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> new file mode 100644
> index 000000000000..9b120f8d303c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/sensirion,sht30.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sensirion SHT3x and GXCAS GXHT30 humidity and temperature sensors
> +
> +maintainers:
> + - Zaixiang Xu <zaixiang.xu.dev@gmail.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - sensirion,sht30
> + - sensirion,sht31
> + - sensirion,sht35
> + - sensirion,sht85
> + - sensirion,sts30
> + - sensirion,sts31
> + - sensirion,sts32
> + - sensirion,sts35
I don't understand this - it AGAIN does not match the driver. Your
driver clearly claims all of these are compatible. But binding does not.
Explain the reasons in commit msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-29 6:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 11:09 [PATCH v6 0/4] hwmon: (sht3x) Add support for GXCAS GXHT30 Zaixiang Xu
2026-04-28 11:09 ` [PATCH v6 1/4] dt-bindings: vendor-prefixes: Add GXCAS Technology Zaixiang Xu
2026-04-28 11:09 ` [PATCH v6 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series Zaixiang Xu
2026-04-29 6:27 ` Krzysztof Kozlowski
2026-04-29 6:28 ` Krzysztof Kozlowski [this message]
2026-04-28 11:09 ` [PATCH v6 3/4] hwmon: (sht3x) Add devicetree support Zaixiang Xu
2026-04-28 11:09 ` [PATCH v6 4/4] hwmon: (sht3x) Add support for GXCAS GXHT30 Zaixiang Xu
2026-04-29 6:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429-steadfast-acoustic-degu-baebee@quoll \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=zaixiang.xu.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox