Re: [PATCH 2/3] arm64: qcom: imola: Move analogix video/audio output to dtso

Riccardo Mereu Linux Kernel
2026-05-05T14:16:18Z

On Thu, Apr 30, 2026 at 4:10 PM Konrad Dybcio
<konrad.dybcio@oss.qualcomm.com> wrote:
>
> On 4/30/26 3:21 PM, Riccardo Mereu wrote:
> > From: Riccardo Mereu <r.mereu@arduino.cc>
> >
> > This is done in order to support different video output over DSI.
> > Since audio part is linked to Analogix USB-C controller it is moved to
> > the same DTSO.
> >
> > Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> > ---
>
> [...]
>
> > + sound: sound {
> > + compatible = "qcom,qrb2210-sndcard";
> > + model = "Arduino-Imola-HPH-LOUT";
> > + audio-routing = "IN1_HPHL", "HPHL_OUT",
> > + "IN2_HPHR", "HPHR_OUT",
> > + "AMIC2", "MIC BIAS2";
>
> The commit message doesn't mention wiring this up, please split adding
> new features

Sorry for that, part of this is in a series that I was sure was added.
I'll make the dependence explicit in V2 cover letter.

> some of these have a double-space, please fix them up
[...]
> Let's keep a \n between the last property and the following subnode, file-wide
[...]
> 'co'dec < 'cp'u < 'p'latform, please

Thanks for the feedback, will fix this in V2

Best regards,
Riccardo