Re: [PATCH 2/3] arm64: qcom: imola: Move analogix video/audio output to dtso

Konrad Dybcio
2026-04-30T14:10:15Z

On 4/30/26 3:21 PM, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
>
> This is done in order to support different video output over DSI.
> Since audio part is linked to Analogix USB-C controller it is moved to
> the same DTSO.
>
> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> ---

[...]

> + sound: sound {
> + compatible = "qcom,qrb2210-sndcard";
> + model = "Arduino-Imola-HPH-LOUT";
> + audio-routing = "IN1_HPHL", "HPHL_OUT",
> + "IN2_HPHR", "HPHR_OUT",
> + "AMIC2", "MIC BIAS2";

The commit message doesn't mention wiring this up, please split adding
new features

[...]

> + mm3-dai-link {
> + link-name = "MultiMedia3";
> +
> + cpu {
> + sound-dai = <&q6asmdai MSM_FRONTEND_DAI_MULTIMEDIA3>;

some of these have a double-space, please fix them up

[...]

> + hph-playback-dai-link {
> + link-name = "HPH Playback";
> + cpu {

Let's keep a \n between the last property and the following subnode, file-wide

> + sound-dai = <&q6afedai RX_CODEC_DMA_RX_0>;
> + };
> +
> + platform {

'co'dec < 'cp'u < 'p'latform, please

Konrad